Return-Path: X-Original-To: apmail-apex-dev-archive@minotaur.apache.org Delivered-To: apmail-apex-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4AFE01839F for ; Tue, 29 Sep 2015 17:10:59 +0000 (UTC) Received: (qmail 30965 invoked by uid 500); 29 Sep 2015 17:10:59 -0000 Delivered-To: apmail-apex-dev-archive@apex.apache.org Received: (qmail 30903 invoked by uid 500); 29 Sep 2015 17:10:59 -0000 Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@apex.incubator.apache.org Delivered-To: mailing list dev@apex.incubator.apache.org Received: (qmail 30892 invoked by uid 99); 29 Sep 2015 17:10:58 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Sep 2015 17:10:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 88C1CC70EC for ; Tue, 29 Sep 2015 17:10:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.971 X-Spam-Level: X-Spam-Status: No, score=0.971 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Z32eTgIQbnWN for ; Tue, 29 Sep 2015 17:10:57 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id 608BD439D1 for ; Tue, 29 Sep 2015 17:10:57 +0000 (UTC) Received: (qmail 30886 invoked by uid 99); 29 Sep 2015 17:10:57 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Sep 2015 17:10:56 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D760CDFCCE; Tue, 29 Sep 2015 17:10:56 +0000 (UTC) From: ilooner To: dev@apex.incubator.apache.org Reply-To: dev@apex.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-apex-core pull request: APEX-157 #comment #resolve Added... Content-Type: text/plain Message-Id: <20150929171056.D760CDFCCE@git1-us-west.apache.org> Date: Tue, 29 Sep 2015 17:10:56 +0000 (UTC) Github user ilooner commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/81#discussion_r40699028 --- Diff: engine/src/test/java/com/datatorrent/stram/plan/logical/LogicalPlanTest.java --- @@ -683,7 +686,85 @@ public void testJdkSerializableOperator() throws Exception { Assert.assertNotNull("port object null", o1Clone.inport1); } - private static class TestStreamCodec implements StreamCodec { + @Test + public void testAttributeValuesSerializableCheck() throws NoSuchFieldException, SecurityException, IllegalArgumentException, IllegalAccessException + { + LogicalPlan dag = new LogicalPlan(); + Attribute attr = new Attribute(new TestAttributeValue(), new Object2String()); --- End diff -- new Attribute could be new Attribute<> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---