apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Priyanka Gugale <priya...@datatorrent.com>
Subject Re: Import order enforced by checkstyle
Date Wed, 30 Sep 2015 12:47:45 GMT
No, there are few classes in Apex-cor and Apex-malhar
e.g. StreamPersistanceTests, PojoUtilsTest etc. Even for Ingestion we used
to keep static imports on top.
We might have to change them once we add these templates.

-Priyanka

On Wed, Sep 30, 2015 at 5:08 PM, Thomas Weise <thomas@datatorrent.com>
wrote:

> Is it a binary file? If so, it does not belong into this repo.
>
> On Wed, Sep 30, 2015 at 2:31 AM, Chandni Singh <chandni@datatorrent.com>
> wrote:
>
> > Pramod,
> >
> > Please advise.
> >
> > Chandni
> >
> > On Tue, Sep 29, 2015 at 10:47 PM, Chandni Singh <chandni@datatorrent.com
> >
> > wrote:
> >
> > > Tim fixed the plugin. We can add the nbm file at the same location
> where
> > > we add the configuration for netbeans.
> > > The readme will let the users know that they need to install this
> version
> > > of Organize Imports.
> > >
> > > Chandni
> > >
> > > On Tue, Sep 29, 2015 at 6:51 PM, David Yan <david@datatorrent.com>
> > wrote:
> > >
> > >> I think it's important to have all 3 major IDE's to support whatever
> we
> > >> determine to be the import order.
> > >>
> > >> David
> > >> On Sep 29, 2015 6:42 PM, "Chandni Singh" <chandni@datatorrent.com>
> > wrote:
> > >>
> > >> > Hi,
> > >> >
> > >> > Looks like Netbeans- Organize Imports plugin doesn't let unmatched
> > >> imports
> > >> > to be in between different groups.
> > >> >
> > >> > It will only place at the bottom. The plugin has no way of
> specifying
> > >> > unmatched imports.
> > >> >
> > >> > Do we need to reconsider the import order when one of the IDEs
> doesn't
> > >> > provide such basic functionality?
> > >> >
> > >> > Chandni
> > >> >
> > >> >
> > >> >
> > >> > On Tue, Sep 29, 2015 at 10:42 AM, David Yan <david@datatorrent.com>
> > >> wrote:
> > >> >
> > >> > > +1!
> > >> > > On Sep 29, 2015 10:41 AM, "Thomas Weise" <thomas@datatorrent.com>
> > >> wrote:
> > >> > >
> > >> > > > Excellent!
> > >> > > >
> > >> > > > --
> > >> > > > sent from mobile
> > >> > > > On Sep 29, 2015 1:20 PM, "Chandni Singh" <
> chandni@datatorrent.com
> > >
> > >> > > wrote:
> > >> > > >
> > >> > > > > Thomas,
> > >> > > > >
> > >> > > > > I am creating configurations for intellij, eclipse
and
> netbeans
> > so
> > >> > that
> > >> > > > > will take care of setting the right import order (APEX-151).
> > >> > > > >
> > >> > > > > Chandni
> > >> > > > >
> > >> > > > >
> > >> > > > > On Tue, Sep 29, 2015 at 8:43 AM, Thomas Weise <
> > >> > thomas@datatorrent.com>
> > >> > > > > wrote:
> > >> > > > >
> > >> > > > > > My top criteria is automation in the IDE(s). Don't
want to
> > >> fiddle
> > >> > > with
> > >> > > > > > imports manually to keep checkstyle happy.
> > >> > > > > >
> > >> > > > > > Thomas
> > >> > > > > >
> > >> > > > > > On Tue, Sep 29, 2015 at 10:46 AM, Pramod Immaneni
<
> > >> > > > > pramod@datatorrent.com>
> > >> > > > > > wrote:
> > >> > > > > >
> > >> > > > > > > I would go with * imports after com.* otherwise
the other
> > >> points
> > >> > > you
> > >> > > > > > > mention are fine.  I agree with the point
that it is not
> > >> possible
> > >> > > to
> > >> > > > > > bunch
> > >> > > > > > > static with their groups in IntelliJ, if
it did it would
> be
> > >> > great.
> > >> > > I
> > >> > > > > > prefer
> > >> > > > > > > them at the bottom.
> > >> > > > > > >
> > >> > > > > > > Thanks
> > >> > > > > > >
> > >> > > > > > > On Tue, Sep 29, 2015 at 6:49 AM, Chandni
Singh <
> > >> > > > > chandni@datatorrent.com>
> > >> > > > > > > wrote:
> > >> > > > > > >
> > >> > > > > > > > I see a difference between your suggestion
and Chetan's
> > >> import
> > >> > > > order.
> > >> > > > > > > >
> > >> > > > > > > > com.datatorrent.* is always the lowest
one and I think
> > >> static
> > >> > > > imports
> > >> > > > > > are
> > >> > > > > > > > not at the bottom in Chetan's.  Static
imports for each
> > >> group
> > >> > are
> > >> > > > > > present
> > >> > > > > > > > below that group. His order is something
like:
> > >> > > > > > > >
> > >> > > > > > > > com.* imports
> > >> > > > > > > >
> > >> > > > > > > > org.* imports
> > >> > > > > > > >
> > >> > > > > > > > org.apache.* imports
> > >> > > > > > > >
> > >> > > > > > > > * imports
> > >> > > > > > > >
> > >> > > > > > > > com.*
> > >> > > > > > > >
> > >> > > > > > > > com.datatorrent.* imports
> > >> > > > > > > >
> > >> > > > > > > > Chetan please confirm.
> > >> > > > > > > >
> > >> > > > > > > > About static imports I think it should
be either top or
> > >> bottom
> > >> > > > > because
> > >> > > > > > it
> > >> > > > > > > > is quite difficult to configure the
in-flow order with
> > >> > > > > > eclipse/intellij.
> > >> > > > > > > >
> > >> > > > > > > > Chandni
> > >> > > > > > > >
> > >> > > > > > > >
> > >> > > > > > > > On Tue, Sep 29, 2015 at 4:11 AM, Pramod
Immaneni <
> > >> > > > > > pramod@datatorrent.com
> > >> > > > > > > >
> > >> > > > > > > > wrote:
> > >> > > > > > > >
> > >> > > > > > > > > I prefer the following order which
I borrowed from
> > Chetan
> > >> a
> > >> > > while
> > >> > > > > > back
> > >> > > > > > > > >
> > >> > > > > > > > > all java/javax imports
> > >> > > > > > > > >
> > >> > > > > > > > > com.* imports
> > >> > > > > > > > >
> > >> > > > > > > > > org.* imports
> > >> > > > > > > > >
> > >> > > > > > > > > org.apache.* imports
> > >> > > > > > > > >
> > >> > > > > > > > > com.datatorrent.* imports
> > >> > > > > > > > >
> > >> > > > > > > > > * imports
> > >> > > > > > > > >
> > >> > > > > > > > > all static imports
> > >> > > > > > > > >
> > >> > > > > > > > > The rationale is as you go down
the list you have more
> > >> > > > > > > > control/flexibility
> > >> > > > > > > > > on names for what you want to include.
> > >> > > > > > > > >
> > >> > > > > > > > > Thanks
> > >> > > > > > > > >
> > >> > > > > > > > > On Mon, Sep 28, 2015 at 7:48 PM,
Chandni Singh <
> > >> > > > > > > chandni@datatorrent.com>
> > >> > > > > > > > > wrote:
> > >> > > > > > > > >
> > >> > > > > > > > > > Hi All,
> > >> > > > > > > > > >
> > >> > > > > > > > > > If you have issues with the
current import order,
> > please
> > >> > > > respond
> > >> > > > > to
> > >> > > > > > > > this
> > >> > > > > > > > > > thread.
> > >> > > > > > > > > >
> > >> > > > > > > > > > I don't have any strong opinions
on the order of
> > static
> > >> and
> > >> > > 3rd
> > >> > > > > > party
> > >> > > > > > > > > > library imports because I
seldom refer to imports
> and
> > >> to me
> > >> > > in
> > >> > > > > this
> > >> > > > > > > > case
> > >> > > > > > > > > > only consistency is of utmost
importance.
> > >> > > > > > > > > >
> > >> > > > > > > > > > If ordering of imports or
placement of static
> imports
> > >> are
> > >> > > very
> > >> > > > > > > > important
> > >> > > > > > > > > to
> > >> > > > > > > > > > you then please respond here.
> > >> > > > > > > > > >
> > >> > > > > > > > > > Also Checkstyle is mature
enough to handle different
> > >> styles
> > >> > > of
> > >> > > > > > import
> > >> > > > > > > > > > placement so we don't need
more plugins to achieve
> > this.
> > >> > > > > > > > > >
> > >> > > > > > > > > > We need to reach on a consensus
soon so that already
> > >> merged
> > >> > > > > > > checkstyle
> > >> > > > > > > > > rule
> > >> > > > > > > > > > can be modified.
> > >> > > > > > > > > >
> > >> > > > > > > > > > Chandni
> > >> > > > > > > > > >
> > >> > > > > > > > > >
> > >> > > > > > > > > > On Fri, Sep 25, 2015 at 4:58
PM, Chandni Singh <
> > >> > > > > > > > chandni@datatorrent.com>
> > >> > > > > > > > > > wrote:
> > >> > > > > > > > > >
> > >> > > > > > > > > > > Hi,
> > >> > > > > > > > > > >
> > >> > > > > > > > > > > Following is the import
order:
> > >> > > > > > > > > > >
> > >> > > > > > > > > > > The import order is following:
> > >> > > > > > > > > > >
> > >> > > > > > > > > > > all static imports
> > >> > > > > > > > > > >
> > >> > > > > > > > > > > all java/javax imports
> > >> > > > > > > > > > >
> > >> > > > > > > > > > > org.* imports
> > >> > > > > > > > > > >
> > >> > > > > > > > > > > com.* imports
> > >> > > > > > > > > > >
> > >> > > > > > > > > > > * imports
> > >> > > > > > > > > > >
> > >> > > > > > > > > > > com.datatorrent.* imports
> > >> > > > > > > > > > >
> > >> > > > > > > > > > > Each group is lexicographically
sorted and
> separated
> > >> by
> > >> > an
> > >> > > > > empty
> > >> > > > > > > > line.
> > >> > > > > > > > > > > Please configure your
IDEs to do so.
> > >> > > > > > > > > > >
> > >> > > > > > > > > > > I am working on APEX-151
<
> > >> > > > > > > > https://malhar.atlassian.net/browse/APEX-151
> > >> > > > > > > > > >
> > >> > > > > > > > > > meanwhile
> > >> > > > > > > > > > > to provide settings for
commonly used IDEs.
> > >> > > > > > > > > > >
> > >> > > > > > > > > > > Thanks,
> > >> > > > > > > > > > > Chandni
> > >> > > > > > > > > > >
> > >> > > > > > > > > > >
> > >> > > > > > > > > > >
> > >> > > > > > > > > >
> > >> > > > > > > > >
> > >> > > > > > > >
> > >> > > > > > >
> > >> > > > > >
> > >> > > > >
> > >> > > >
> > >> > >
> > >> >
> > >>
> > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message