apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chetan Narsude <che...@datatorrent.com>
Subject Re: [GitHub] incubator-apex-core pull request: APEX-157 #comment #resolve Added...
Date Tue, 29 Sep 2015 19:48:49 GMT
This qualifies as a bug fix (or feature fix) which moves part of the
validation from later phase to the earlier phase.

Comments?


On Tue, Sep 29, 2015 at 12:37 PM, ishark <git@git.apache.org> wrote:

> Github user ishark commented on a diff in the pull request:
>
>
> https://github.com/apache/incubator-apex-core/pull/81#discussion_r40718327
>
>     --- Diff: engine/src/test/resources/testTopology.json ---
>     @@ -25,7 +25,7 @@
>                "attributes": {
>                  "UNIFIER_LIMIT": 8,
>                  "STREAM_CODEC" : {
>     -              "com.datatorrent.common.codec.JsonStreamCodec" : {}
>     +
> "com.datatorrent.stram.plan.logical.LogicalPlanConfigurationTest$TestStreamCodec"
> : {}
>                  }
>     --- End diff --
>
>     Yes, the test fails with the original JSON. So I changed the stream
> codec class in JSON.
>     It does make the change backword incompatible due to an additional
> validation. However, if attribute values are not serializable, the app
> currently fails during deployment. we need to catch attribute
> serializability in validate phase itself.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message