Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2D08D200C37 for ; Sun, 19 Mar 2017 22:15:38 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 2B890160B8E; Sun, 19 Mar 2017 21:15:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7C3A8160B6D for ; Sun, 19 Mar 2017 22:15:37 +0100 (CET) Received: (qmail 85193 invoked by uid 500); 19 Mar 2017 21:15:36 -0000 Mailing-List: contact commits-help@apex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@apex.apache.org Delivered-To: mailing list commits@apex.apache.org Received: (qmail 85183 invoked by uid 99); 19 Mar 2017 21:15:36 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 19 Mar 2017 21:15:36 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 9AB32DFE1D; Sun, 19 Mar 2017 21:15:36 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: ramapex@apache.org To: commits@apex.apache.org Date: Sun, 19 Mar 2017 21:15:36 -0000 Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: [1/2] apex-malhar git commit: APEXMALHAR-2445 During recovery no need to write to WindowDataManger if window id <= LargestCompleted Window ID archived-at: Sun, 19 Mar 2017 21:15:38 -0000 Repository: apex-malhar Updated Branches: refs/heads/master c46398f11 -> 89b29378e APEXMALHAR-2445 During recovery no need to write to WindowDataManger if window id <= LargestCompleted Window ID Project: http://git-wip-us.apache.org/repos/asf/apex-malhar/repo Commit: http://git-wip-us.apache.org/repos/asf/apex-malhar/commit/8c538a00 Tree: http://git-wip-us.apache.org/repos/asf/apex-malhar/tree/8c538a00 Diff: http://git-wip-us.apache.org/repos/asf/apex-malhar/diff/8c538a00 Branch: refs/heads/master Commit: 8c538a003e9d26388df633f07f3e9bb9a639736c Parents: 7f1abca Author: Sandesh Hegde Authored: Wed Mar 15 11:24:08 2017 -0700 Committer: Sandesh Hegde Committed: Wed Mar 15 12:37:32 2017 -0700 ---------------------------------------------------------------------- .../malhar/kafka/KafkaSinglePortExactlyOnceOutputOperator.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/apex-malhar/blob/8c538a00/kafka/src/main/java/org/apache/apex/malhar/kafka/KafkaSinglePortExactlyOnceOutputOperator.java ---------------------------------------------------------------------- diff --git a/kafka/src/main/java/org/apache/apex/malhar/kafka/KafkaSinglePortExactlyOnceOutputOperator.java b/kafka/src/main/java/org/apache/apex/malhar/kafka/KafkaSinglePortExactlyOnceOutputOperator.java index a8e333f..75af448 100644 --- a/kafka/src/main/java/org/apache/apex/malhar/kafka/KafkaSinglePortExactlyOnceOutputOperator.java +++ b/kafka/src/main/java/org/apache/apex/malhar/kafka/KafkaSinglePortExactlyOnceOutputOperator.java @@ -182,7 +182,11 @@ public class KafkaSinglePortExactlyOnceOutputOperator extends AbstractKafkaOu @Override public void endWindow() { - if (!partialWindowTuples.isEmpty() && windowId > windowDataManager.getLargestCompletedWindow()) { + if (windowId <= windowDataManager.getLargestCompletedWindow()) { + return; + } + + if (!partialWindowTuples.isEmpty()) { throw new RuntimeException("Violates Exactly once. Not all the tuples received after operator reset."); }