Mailing-List: contact commits-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: 243826 <git@git.apache.org>
To: commits@apex.incubator.apache.org
Reply-To: commits@apex.incubator.apache.org
References: <git-pr-81-incubator-apex-core@git.apache.org>
In-Reply-To: <git-pr-81-incubator-apex-core@git.apache.org>
Subject: [GitHub] incubator-apex-core pull request: APEX-157 #comment #resolve
 Added...
Content-Type: text/plain
Message-Id: <20150928202130.2CA96DFBE6@git1-us-west.apache.org>
Date: Mon, 28 Sep 2015 20:21:30 +0000 (UTC)

Github user 243826 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/81#discussion_r40600289
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
    @@ -1333,6 +1333,13 @@ public void validate() throws ConstraintViolationException
     
           OperatorMeta.PortMapping portMapping = n.getPortMapping();
     
    +      // Check all attributes are serializable
    +      for (Entry<Attribute<?>, Object> entry : n.getAttributes().entrySet()) {
    --- End diff --
    
    just as a practice - when doing validation - please report all the validation errors all at once wherever possible instead of one at a time.
    
    Here: can you collect all the attribute serialization problems and report them at once?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---