apex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ishark <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEX-92 #Comment #resolve
Date Mon, 28 Sep 2015 23:52:56 GMT
Github user ishark commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/68#discussion_r40620622
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/StreamingAppMasterService.java ---
    @@ -880,6 +883,20 @@ private void execute() throws YarnException, IOException
             if (0 != exitStatus) {
               if (allocatedContainer != null) {
                 numFailedContainers.incrementAndGet();
    +            if (exitStatus != 1) {
    +              // If container failure due to framework
    +              AtomicInteger failedTimes = new AtomicInteger(1);
    +              String hostname = allocatedContainer.container.getNodeId().getHost();
    +              if (failedContainersMap.containsKey(hostname)) {
    --- End diff --
    
    ConcurrentMap is needed only if later down the line, we want to expose failure count per
hostname as part of ClusterAppStats. Similar to getFailedContainers (returns total number
of failures)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message