apex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vrozov <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEX-164 - Changed log4j level t...
Date Mon, 28 Sep 2015 21:29:58 GMT
Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/92#discussion_r40608131
  
    --- Diff: apex-app-archetype/src/main/resources/archetype-resources/src/test/resources/log4j.properties
---
    @@ -1,4 +1,4 @@
    -log4j.rootLogger=DEBUG,CONSOLE
    +log4j.rootLogger=INFO,CONSOLE
    --- End diff --
    
    In this case should not it be log4j.rootLogger=ALL,CONSOLE? What if user decides to use
trace or own custom level, not debug? Using DEBUG level sounds related to the level used by
com.datatorrent loggers.
    
    I'll make the change and exclude archetype resource from the commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message