From dev-return-5113-archive-asf-public=cust-asf.ponee.io@any23.apache.org Fri Feb 9 07:14:05 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 1AC36180654 for ; Fri, 9 Feb 2018 07:14:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0A7D4160C4A; Fri, 9 Feb 2018 06:14:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4E7B9160C5D for ; Fri, 9 Feb 2018 07:14:04 +0100 (CET) Received: (qmail 8337 invoked by uid 500); 9 Feb 2018 06:14:03 -0000 Mailing-List: contact dev-help@any23.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@any23.apache.org Delivered-To: mailing list dev@any23.apache.org Received: (qmail 8326 invoked by uid 99); 9 Feb 2018 06:14:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Feb 2018 06:14:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E1431C0115 for ; Fri, 9 Feb 2018 06:14:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id LlpjIfZoPm4Q for ; Fri, 9 Feb 2018 06:14:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 8F1B35F24A for ; Fri, 9 Feb 2018 06:14:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D1039E019C for ; Fri, 9 Feb 2018 06:14:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3202F240FA for ; Fri, 9 Feb 2018 06:14:00 +0000 (UTC) Date: Fri, 9 Feb 2018 06:14:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@any23.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ANY23-264) Upgrade to use public commons-csv instead of custom SNAPSHOT MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ANY23-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357970#comment-16357970 ] ASF GitHub Bot commented on ANY23-264: -------------------------------------- GitHub user HansBrende opened a pull request: https://github.com/apache/any23/pull/63 ANY23-264 Upgrade to use public commons-csv instead of custom SNAPSHOT I upgraded the commons-csv dependency from `1.0-SNAPSHOT-rev1148315` to `1.5`. On running `mvn clean install`, all tests pass. A couple of minor code changes I made along the way: 1. Deleted dead code in `if (delimiter.length() != 1 || delimiter.equals(""))` 2. Added a null-check in `CSVExtractor.processHeader()` 3. Deleted `NULL_CHAR = ' '` from `CSVReaderBuilder`. Not sure why that was being used as a comment marker--guessing it was meant to disable comments during strategy testing, which the default `CSVFormat` does already. 4. Deleted non-standard use of the character `'` for encapsulation. Not sure why that was being used as such. Both `CSVFormat.DEFAULT` and the defunct `CSVStrategy.DEFAULT_STRATEGY`, as well as the RFC 4180 standard use `"` as the encapsulation character. You can merge this pull request into a Git repository by running: $ git pull https://github.com/HansBrende/any23 ANY23-264 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/any23/pull/63.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #63 ---- commit 7a7db20069da63bb1312dd12820c2f2ca301856f Author: Hans Date: 2018-02-09T05:27:30Z ANY23-264 Upgrade to use public commons-csv instead of custom SNAPSHOT ---- > Upgrade to use public commons-csv instead of custom SNAPSHOT > ------------------------------------------------------------ > > Key: ANY23-264 > URL: https://issues.apache.org/jira/browse/ANY23-264 > Project: Apache Any23 > Issue Type: Improvement > Affects Versions: 1.1 > Reporter: Lewis John McGibbney > Assignee: Hans Brende > Priority: Major > Fix For: 2.3 > > > Unbeknown to me, it appears that commons-csv finally released a couple of artifacts which means we can drop support of our [old SNAPSHOT dependency and makeshift repository|http://svn.apache.org/repos/asf/any23/repo-ext/org/apache/commons/commons-csv/] in favor of a nice new shiny public artifact > http://search.maven.org/#artifactdetails|org.apache.commons|commons-csv|1.1|jar -- This message was sent by Atlassian JIRA (v7.6.3#76005)