any23-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lewismc <...@git.apache.org>
Subject [GitHub] any23 issue #60: ANY23-291 Allow JSONLD scripts to be located anywhere in do...
Date Fri, 09 Feb 2018 22:15:42 GMT
Github user lewismc commented on the issue:

    https://github.com/apache/any23/pull/60
  
    1. Look at the call to [extractJSONLDScript](https://github.com/apache/any23/blob/master/core/src/main/java/org/apache/any23/extractor/html/EmbeddedJSONLDExtractor.java#L81-L82)
we use it further down. 
    2. Yes this could probably be cleaned up, it is a bit messy right now.
    3. Right now yes it is correct but I am not sure if it is the intended behavior. When
i originally added the logic, it was what I wrote... if it does not make sense then please
send a PR and we can clean it up.
    
    For reference on extraction results, please see the following test files [html-embedded-jsonld-extractor-multiple.html
    ](https://github.com/apache/any23/blob/master/test-resources/src/test/resources/html/html-embedded-jsonld-extractor-multiple.html)
and [html-embedded-jsonld-extractor.html
    ](https://github.com/apache/any23/blob/master/test-resources/src/test/resources/html/html-embedded-jsonld-extractor.html)



---

Mime
View raw message