any23-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ANY23-327) Wrong error messages
Date Mon, 29 Jan 2018 05:54:00 GMT

    [ https://issues.apache.org/jira/browse/ANY23-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342932#comment-16342932
] 

ASF GitHub Bot commented on ANY23-327:
--------------------------------------

Github user HansBrende commented on a diff in the pull request:

    https://github.com/apache/any23/pull/62#discussion_r164340771
  
    --- Diff: core/src/main/java/org/apache/any23/rdf/RDFUtils.java ---
    @@ -528,10 +528,10 @@ public static boolean isAbsoluteIRI(String href) {
                 new java.net.URI(href.trim());
    --- End diff --
    
    On an unrelated note, why are we testing this on `href.trim()` instead of just `href`?

    `RDFUtils.iri(href)` does *not* call `href.trim()`!


> Wrong error messages
> --------------------
>
>                 Key: ANY23-327
>                 URL: https://issues.apache.org/jira/browse/ANY23-327
>             Project: Apache Any23
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 2.2
>            Reporter: Jacek Grzebyta
>            Priority: Minor
>
> I found that parsing string values gives following error. My intention was in that case
string should be parsed into Literal value.
> {code:java}
> // 969  [main] ERROR org.apache.any23.rdf.RDFUtils  - Error processing href: M20
> java.lang.IllegalArgumentException: Not a valid (absolute) IRI: M20
>     at org.eclipse.rdf4j.model.impl.SimpleIRI.setIRIString(SimpleIRI.java:76)
>     at org.eclipse.rdf4j.model.impl.SimpleIRI.<init>(SimpleIRI.java:65)
>     at org.eclipse.rdf4j.model.impl.AbstractValueFactory.createIRI(AbstractValueFactory.java:88)
>     at org.apache.any23.rdf.RDFUtils.isAbsoluteIRI(RDFUtils.java:527)
>     at org.apache.any23.rdf.RDFUtils.makeIRI(RDFUtils.java:602)
>     at org.apache.any23.extractor.yaml.ElementsProcessor.asModel(ElementsProcessor.java:115)
>     at org.apache.any23.extractor.yaml.ElementsProcessor.lambda$processMap$0(ElementsProcessor.java:164)
>     at java.util.LinkedHashMap$LinkedKeySet.forEach(LinkedHashMap.java:559)
>     at org.apache.any23.extractor.yaml.ElementsProcessor.processMap(ElementsProcessor.java:151)
>     at org.apache.any23.extractor.yaml.ElementsProcessor.asModel(ElementsProcessor.java:113)
>     at org.apache.any23.extractor.yaml.ElementsProcessor.processList(ElementsProcessor.java:195)
>     at org.apache.any23.extractor.yaml.ElementsProcessor.asModel(ElementsProcessor.java:111)
>     at org.apache.any23.extractor.yaml.ElementsProcessor.lambda$processMap$0(ElementsProcessor.java:164)
>     at java.util.LinkedHashMap$LinkedKeySet.forEach(LinkedHashMap.java:559)
>     at org.apache.any23.extractor.yaml.ElementsProcessor.processMap(ElementsProcessor.java:151)
>     at org.apache.any23.extractor.yaml.ElementsProcessor.asModel(ElementsProcessor.java:113)
>     at org.apache.any23.extractor.yaml.ElementsProcessor.processList(ElementsProcessor.java:195)
>     at org.apache.any23.extractor.yaml.ElementsProcessor.asModel(ElementsProcessor.java:111)
>     at org.apache.any23.extractor.yaml.ElementsProcessor.lambda$processMap$0(ElementsProcessor.java:164)
>     at java.util.LinkedHashMap$LinkedKeySet.forEach(LinkedHashMap.java:559)
>     at org.apache.any23.extractor.yaml.ElementsProcessor.processMap(ElementsProcessor.java:151)
>     at org.apache.any23.extractor.yaml.ElementsProcessor.asModel(ElementsProcessor.java:113)
>     at org.apache.any23.extractor.yaml.YAMLExtractor.run(YAMLExtractor.java:77)
>     at org.apache.any23.extractor.yaml.YAMLExtractor.run(YAMLExtractor.java:40)
>     at org.apache.any23.extractor.SingleDocumentExtraction.runExtractor(SingleDocumentExtraction.java:470)
>     at org.apache.any23.extractor.SingleDocumentExtraction.run(SingleDocumentExtraction.java:258)
>     at org.apache.any23.Any23.extract(Any23.java:300)
>     at org.apache.any23.Any23.extract(Any23.java:452)
>     at org.apache.any23.cli.Rover.performExtraction(Rover.java:180)
>     at org.apache.any23.cli.Rover.run(Rover.java:213)
>     at org.apache.any23.cli.ToolRunner.execute(ToolRunner.java:136)
>     at org.apache.any23.cli.ToolRunner.main(ToolRunner.java:69)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message