any23-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ANY23-291) JSON-LD should be looked up in entire HTML document, not just in <head>
Date Thu, 25 Jan 2018 05:33:01 GMT

    [ https://issues.apache.org/jira/browse/ANY23-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338750#comment-16338750
] 

Hudson commented on ANY23-291:
------------------------------

SUCCESS: Integrated in Jenkins build Any23-trunk #1527 (See [https://builds.apache.org/job/Any23-trunk/1527/])
ANY23-291 Allow JSONLD scripts to be located anywhere in document (Hans: rev d69558268b5d8e8d57f00d94b864c54ec2eaf75f)
* (edit) core/src/main/java/org/apache/any23/extractor/html/EmbeddedJSONLDExtractor.java
* (add) test-resources/src/test/resources/html/html-body-embedded-jsonld-extractor.html
* (add) test-resources/src/test/resources/html/html-head-and-body-embedded-jsonld-extractor.html
* (edit) core/src/test/java/org/apache/any23/extractor/html/EmbeddedJSONLDExtractorTest.java


> JSON-LD should be looked up in entire HTML document, not just in <head>
> -----------------------------------------------------------------------
>
>                 Key: ANY23-291
>                 URL: https://issues.apache.org/jira/browse/ANY23-291
>             Project: Apache Any23
>          Issue Type: Improvement
>          Components: extractors
>    Affects Versions: 1.2
>            Reporter: Thomas Francart
>            Assignee: Hans Brende
>            Priority: Minor
>             Fix For: 2.2
>
>         Attachments: example-embedded-jsonld.html
>
>
> In org.apache.any23.extractor.html.EmbeddedJSONLDExtractor.extractJSONLDScript(), I think
this line :
> List<Node> scriptNodes = DomUtils.findAll(in, "/HTML/HEAD/SCRIPT");
> is too restrictive. scripts containing json-ld can be placed anywhere in the page, and
actually some CMS/Wordpress plugin inserting JSON-LD are generating their output in the body,
not in the head.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message