any23-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From imduffy15 <...@git.apache.org>
Subject [GitHub] any23 pull request #47: Support attribute content on all fields.
Date Wed, 08 Nov 2017 14:05:52 GMT
GitHub user imduffy15 opened a pull request:

    https://github.com/apache/any23/pull/47

    Support attribute content on all fields.

    <sometag content="something" /> should be considered, regardless if `content` is
not a valid
    attribute of `sometag`.
    
    The specification for microdata[1] details that an elements content attribute should be
considered
    before text content.
    
    Any23 doesn't currently do this, it only considers `content` for `meta` tags which is
the only
    HTML tag which is suppose to have a `content` but not all sites follow HTML specifications.
    
    Updating the microdata parser to be able to get `content` from any element should it exist.
    
    [1] https://www.w3.org/TR/microdata/#values
    
    Signed-off-by: Ian Duffy <ian.duffy@zalando.ie>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/imduffy15/any23 master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/any23/pull/47.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #47
    
----
commit 28a68b535285f9d084725728f758272a3eda21be
Author: Ian Duffy <ian.duffy@zalando.ie>
Date:   2017-11-08T13:59:42Z

    Support attribute content on all fields.
    
    <sometag content="something" /> should be considered, regardless if `content` is
not a valid
    attribute of `sometag`.
    
    The specification for microdata[1] details that an elements content attribute should be
considered
    before text content.
    
    Any23 doesn't currently do this, it only considers `content` for `meta` tags which is
the only
    HTML tag which is suppose to have a `content` but not all sites follow HTML specifications.
    
    Updating the microdata parser to be able to get `content` from any element should it exist.
    
    [1] https://www.w3.org/TR/microdata/#values
    
    Signed-off-by: Ian Duffy <ian.duffy@zalando.ie>

----


---

Mime
View raw message