any23-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lewismc <...@git.apache.org>
Subject [GitHub] any23 pull request #34: ANY23-304 Add extractor for OpenIE
Date Thu, 02 Mar 2017 01:19:34 GMT
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/any23/pull/34#discussion_r103831681
  
    --- Diff: openie/src/test/java/org/apache/any23/openie/OpenIEExtractorTest.java ---
    @@ -0,0 +1,88 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *  http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.any23.openie;
    +
    +import java.io.ByteArrayOutputStream;
    +import java.io.IOException;
    +
    +import org.apache.any23.extractor.ExtractionContext;
    +import org.apache.any23.extractor.ExtractionException;
    +import org.apache.any23.extractor.ExtractionParameters;
    +import org.apache.any23.extractor.ExtractionResult;
    +import org.apache.any23.extractor.ExtractionResultImpl;
    +import org.apache.any23.extractor.openie.OpenIEExtractor;
    +import org.apache.any23.rdf.RDFUtils;
    +import org.apache.any23.util.StreamUtils;
    +import org.apache.any23.writer.RDFXMLWriter;
    +import org.apache.any23.writer.TripleHandler;
    +import org.apache.any23.writer.TripleHandlerException;
    +import org.eclipse.rdf4j.model.IRI;
    +import org.junit.After;
    +import org.junit.Before;
    +import org.junit.Test;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +/**
    + * @author lewismc
    + *
    + */
    +public class OpenIEExtractorTest {
    +
    +    private static final Logger logger = LoggerFactory.getLogger(OpenIEExtractorTest.class);
    +
    +    private OpenIEExtractor extractor;
    +
    +    @Before
    +    public void setUp() throws Exception {
    +        extractor = new OpenIEExtractor();
    +    }
    +
    +    @After
    +    public void tearDown() throws Exception {
    +        extractor = null;
    +    }
    +
    +    //@Ignore("This typically results in a JVM crash... disabled for the time being.")
    +    @Test
    +    public void testExtractFromHTMLDocument() 
    +      throws IOException, ExtractionException, TripleHandlerException {
    +        final IRI uri = RDFUtils.iri("http://podaac.jpl.nasa.gov/aquarius");
    +        extract(uri, "/org/apache/any23/extractor/openie/example-openie.html");
    +    }
    +    
    +    public void extract(IRI uri, String filePath) 
    +      throws IOException, ExtractionException, TripleHandlerException {
    +      ByteArrayOutputStream baos = new ByteArrayOutputStream();
    --- End diff --
    
    @ansell can you please elaborate? Its my understanding that we require the ```ByteArrayOutputStream```
as it acts as a parameter for each ```TripleHandler``` implementation e.g. ```RDFXMLWriter(baos)```.
    I would be happy to stream the extractions as an attempt to mitigate against OOM, however
this would be after the extraction right? Not before, therefore I'm not sure how much memory
we would be saving.
    
    If you could clarify it would be appreciated. Thanks.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message