any23-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michele Mostarda <michele.mosta...@gmail.com>
Subject Re: GSoC 2015 with Apache any23
Date Mon, 29 Jun 2015 07:55:41 GMT
Great Nisala,
   I had a quick look at your latest commit and you did a very good catch.
Thanks for the refactoring.

Best
Michele

On 28 June 2015 at 19:20, Nisala Mendis <nisala12@gmail.com> wrote:

> hi michele,
> i have made changes according to your instructions and added feather test
> cases.[1] added another weekly report to the wiki.
> i already started implementing rest of the microformats2 extractors.
> [1] https://github.com/nisalanirmana/any23/commits/gsoc_2015
>
>
> On Mon, Jun 22, 2015 at 2:07 PM, Nisala Mendis <nisala12@gmail.com> wrote:
>
>> Hi Michele,
>> I must really thankful for you taking time to review my work. Thanks for
>> the suggestions too, I will improve my code and try to write code as much
>> as generic possible using identifying prefixes. Thanks again.
>> Regards
>> Nisala
>>
>> On Mon, Jun 22, 2015 at 1:36 PM, Michele Mostarda <
>> michele.mostarda@gmail.com> wrote:
>>
>>> Hi All,
>>>
>>> On 22 June 2015 at 04:12, Nisala Mendis <nisala12@gmail.com> wrote:
>>>
>>>> Hi all,
>>>> Here with I have attached a detailed analysis of diference between
>>>> microfrmats 1 and 2. see this link [1].
>>>> As a sample I have implemented extractors HAdr and HGeo with relavant
>>>> unit test cases. According to the Microformats 2 spec HAdr can have HGeo
as
>>>> a nested property. I have includes the sample test cases to cover this
>>>> scenario. See my fork under gsoc_2015 branch [2] please see the recent
>>>> commit added HAdr and HGeo Extractors support. I can basically cover the
>>>> rest of the using this approach. I am expecting a feedback so that I can
>>>> move forward. Also note I have added week 2 and week 3 reports to the wiki
>>>>
>>>> [1]
>>>> https://docs.google.com/document/d/17DXcr8jv7D41FOuR1Rba0Ex-4VVheMNInmBSygkih5E/edit?usp=sharing
>>>>
>>> Really interesting report, I added a small comment on it.
>>>
>>>> [2] https://github.com/nisalanirmana/any23/commits/gsoc_2015
>>>>
>>>>
>>> core/src/main/java/org/apache/any23/extractor/html/microformats2/HAdrExtractor.java
>>> Quick suggestion based on a really superficial analysis of your code:
>>> isn't better to write a general logic to manage property extraction based
>>> on the identification of prefixes?
>>> First identify a node "h-*" and then identify children "p-*" "u-*",
>>> "dt-*" and so on.
>>> You would write less, more robust and more maintainable code.
>>>
>>> regards,nisala
>>>>
>>> Best
>>> Michele
>>>
>>>>
>>>> On Monday, June 15, 2015, Michele Mostarda <michele.mostarda@gmail.com>
>>>> wrote:
>>>>
>>>>> Great job Nisala!
>>>>> Best
>>>>> Michele
>>>>>
>>>>> On 13 June 2015 at 20:28, Lewis John Mcgibbney <
>>>>> lewis.mcgibbney@gmail.com> wrote:
>>>>>
>>>>>> Excellent Nisala.
>>>>>> I committed your patch and your report looks good for now I am making
>>>>>> some comments.
>>>>>> Lewis
>>>>>>
>>>>>> On Mon, Jun 8, 2015 at 10:36 AM, Nisala Mendis <nisala12@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi Lewis,
>>>>>>> Please note that I have added week 1 report and added a comment
>>>>>>> attached patch to the jira[1].
>>>>>>> [1]https://issues.apache.org/jira/browse/ANY23-185
>>>>>>> Regards
>>>>>>> Nisala
>>>>>>>
>>>>>>> On Mon, Jun 1, 2015 at 12:45 AM, Lewis John Mcgibbney <
>>>>>>> lewis.mcgibbney@gmail.com> wrote:
>>>>>>>
>>>>>>>>
>>>>>>>> https://cwiki.apache.org/confluence/display/ANY23/Google+Summer+of+Code#GoogleSummerofCode-ProjectReports
>>>>>>>>
>>>>>>>> On Sun, May 31, 2015 at 12:09 PM, Lewis John Mcgibbney <
>>>>>>>> lewis.mcgibbney@gmail.com> wrote:
>>>>>>>>
>>>>>>>>> Hi Nisala,
>>>>>>>>>
>>>>>>>>> On Sun, May 31, 2015 at 11:10 AM, Nisala Mendis <
>>>>>>>>> nisala12@gmail.com> wrote:
>>>>>>>>>
>>>>>>>>>> Hi Lewis,
>>>>>>>>>> I really apologize for not sending any updates via
private mails,
>>>>>>>>>> I had uploaded my proposal already even before the
GSoC selection period,
>>>>>>>>>> Once again I apologize for not informing you by mail
this since I assumed
>>>>>>>>>> you noticed it.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Thanks for the update and no problems at all. It was
just a bit
>>>>>>>>> concerning that around a month had gone by and we hadn't
heard from you :)
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> I started working things bit out waited to give you
an update
>>>>>>>>>> some concrete work. You can find my proposal in [1].
>>>>>>>>>> [1]
>>>>>>>>>> https://cwiki.apache.org/confluence/display/ANY23/Google+Summer+of+Code
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> I've added a section for your reports.
>>>>>>>>> Please begin to populate the page based upon anything
you've been
>>>>>>>>> doing.
>>>>>>>>> Thank you for writing to us, it's very much appreciated.
>>>>>>>>> Lewis
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> *Lewis*
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> *Lewis*
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Michele Mostarda
>>>>> Senior Software Engineer
>>>>> skype: michele.mostarda
>>>>> phone: +39 327 01 86 259
>>>>> twitter: micmos
>>>>> email: me@michelemostarda.it
>>>>> website: http://michelemostarda.it
>>>>>
>>>>
>>>
>>>
>>> --
>>> Michele Mostarda
>>> Senior Software Engineer
>>> skype: michele.mostarda
>>> phone: +39 327 01 86 259
>>> twitter: micmos
>>> email: me@michelemostarda.it
>>> website: http://michelemostarda.it
>>>
>>
>>
>


-- 
Michele Mostarda
Senior Software Engineer
skype: michele.mostarda
phone: +39 327 01 86 259
twitter: micmos
email: me@michelemostarda.it
website: http://michelemostarda.it

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message