Return-Path: X-Original-To: apmail-any23-dev-archive@www.apache.org Delivered-To: apmail-any23-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3F5D917A24 for ; Tue, 31 Mar 2015 01:32:53 +0000 (UTC) Received: (qmail 8105 invoked by uid 500); 31 Mar 2015 01:32:53 -0000 Delivered-To: apmail-any23-dev-archive@any23.apache.org Received: (qmail 8055 invoked by uid 500); 31 Mar 2015 01:32:53 -0000 Mailing-List: contact dev-help@any23.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@any23.apache.org Delivered-To: mailing list dev@any23.apache.org Received: (qmail 8044 invoked by uid 99); 31 Mar 2015 01:32:53 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Mar 2015 01:32:53 +0000 Date: Tue, 31 Mar 2015 01:32:53 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@any23.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ANY23-247) FIX Attribute name "itemscope" associated with an element type "html" must be followed by the ' = ' character. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ANY23-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387787#comment-14387787 ] ASF GitHub Bot commented on ANY23-247: -------------------------------------- Github user ansell commented on the pull request: https://github.com/apache/any23/pull/17#issuecomment-87894632 Could you rebase your branch onto upstream master and try again? The place where the error started to become visible as a test failure (when I started rethrowing an exception that was being swallowed incorrectly) is on the current master, but your master branch is 4 commits behind that so the test will still silently succeed on your branch. > FIX Attribute name "itemscope" associated with an element type "html" must be followed by the ' = ' character. > -------------------------------------------------------------------------------------------------------------- > > Key: ANY23-247 > URL: https://issues.apache.org/jira/browse/ANY23-247 > Project: Apache Any23 > Issue Type: Improvement > Affects Versions: 1.1 > Reporter: Lewis John McGibbney > Assignee: Lewis John McGibbney > Fix For: 1.3 > > > In the following markup > {code} > > > > > > > ... > {code} > Due to the absence of any subsequent value for *itemscope*, we get the following error in our web server logs > {code} > [Fatal Error] :2:185: Attribute name "itemscope" associated with an element type "html" must be followed by the ' = ' character. > {code} > Although the markup semantics are incorrect, Any23 should simply perform a check for the itemscope value being null, if this is the case then add *=""*, there is a precedent for us doing something like this before, I just cant find the ticket right now! > The code we need to add is present within either > core/src/main/java/org/apache/any23/extractor/microdata/ItemScope.java > core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)