any23-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andy Seaborne <a...@apache.org>
Subject Re: [VOTE] Release Apache Any23 0.8.0
Date Sat, 04 May 2013 15:19:24 GMT
Review of Any23 0.8.0 (vote called 2/5/2013)

- No license header on 3 source files.
- Not sure about NOTICE/LICENSE because MIT software included in source.

otherwise looks OK.

== Process

Signature on source release (zip and tar.gz): good

Build from git tag: yes

Build from source: yes

LICENSE and NOTICE:

NOTICE for the source-release file is minimal.

LICENSE is Apache only (assumes no inclusions of source from BSD e.g. 
Sesame because BSD says:
"""
Redistributions of source code must retain the above copyright notice, 
this list of conditions and the following disclaimer.
"""
)


** No license header on 3 source files:


./core/src/main/java/org/apache/any23/extractor/csv/CSVExtractorFactory.java


./core/src/test/java/org/apache/any23/extractor/example/ExampleExtractorFactory.java


./plugins/office-scraper/src/main/java/org/apache/any23/plugin/officescraper/ExcelExtractorFactory.java

** JQuery is MIT:
   ./service/src/main/webapp/resources/js/jquery-1.7.2.min.js

which includes:
"""
The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.
"""

so I expected something in NOTICE and LICENSE because it is not in 
jquery-1.7.2.min.js itself and this condition is inherited by any one 
redistributing Any23.

== Other

+ DISCLAIMER is an empty file.
+ Top level LICENSE-header.txt is confusing - there is a real 
LICENSE.txt as well (put in a subdirectory?)

Mime
View raw message