Mailing-List: contact user-help@ant.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Ant Users List" <user@ant.apache.org>
Received-SPF: pass (nike.apache.org: local policy)
From: "Bailey, Darragh" <dbailey@hp.com>
To: Ant Users List <user@ant.apache.org>
Date: Fri, 12 Nov 2010 15:10:25 +0000
Subject: RE: Apply argument wrapping with msiexec
Thread-Topic: Apply argument wrapping with msiexec
Thread-Index: AcuBG9nPwsIgL3kJRlq/zw9SOCbTxwAcxn7wADidc9A=
Message-ID: 
 <FF452E17060D614D89BF7FD3A07A88335601FEA81E@GVW1115EXC.americas.hpqcorp.net>
References: 
 <FF452E17060D614D89BF7FD3A07A88335601F9496F@GVW1115EXC.americas.hpqcorp.net>
 <20101110211057.GA17419@nmhq.net>
 <FF452E17060D614D89BF7FD3A07A88335601F95540@GVW1115EXC.americas.hpqcorp.net>
In-Reply-To: 
 <FF452E17060D614D89BF7FD3A07A88335601F95540@GVW1115EXC.americas.hpqcorp.net>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

> > [1] From ProcessImpl.java version 1.32, 06/03/22,
> >     from my version of JDK 1.6:
> >=20
> >     StringBuilder cmdbuf =3D new StringBuilder(80);
> >     for (int i =3D 0; i < cmd.length; i++) {
> >         if (i > 0) {
> >             cmdbuf.append(' ');
> >         }
> >         String s =3D cmd[i];
> >         if (s.indexOf(' ') >=3D 0 || s.indexOf('\t') >=3D 0) {
> >             if (s.charAt(0) !=3D '"') {
> >                 cmdbuf.append('"');
> >                 cmdbuf.append(s);
> >                 if (s.endsWith("\\")) {
> >                     cmdbuf.append("\\");
> >                 }
> >                 cmdbuf.append('"');
> >             } else if (s.endsWith("\"")) {
> >                 /* The argument has already been quoted. */
> >                 cmdbuf.append(s);
> >             } else {
> >                 /* Unmatched quote for the argument. */
> >                 throw new IllegalArgumentException();
> >             }
> >         } else {
> >             cmdbuf.append(s);
> >         }
> >     }
>=20
> That is interesting, it makes the assumption that if the arg=20
> doesn't start with quotes and has whitespace, then it needs=20
> quoting. A simple if crude fix would be to swap the first 2 tests.
>=20
> Thanks for looking into it in detail.


Seems like the bug in quoting on windows via java's ProcessImpl is not new.

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=3D6550942
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=3D6468220
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=3D6511002

Doesn't seem like they are interested in fixing this one.

I managed to put together a workaround that solves the problem for me

    <exec executable=3D"cmd" failonerror=3D"true" outputproperty=3D"extract=
.dir.short" >
      <arg value=3D"/q" />
      <arg value=3D"/c" />
      <arg value=3D'for %A in ("${build.dir}/extract/msi") do echo %~sfA' /=
>
    </exec>

Basically gives me the 8.3 path without spaces which avoids the problem alt=
ogether.

Not the nicest solution, but relatively quick.

--
Regards,
Darragh Bailey

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@ant.apache.org
For additional commands, e-mail: user-help@ant.apache.org