Return-Path: 
 <user-return-69318-apmail-ant-user-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-user-archive@www.apache.org
Received: (qmail 40378 invoked from network); 5 Nov 2009 17:29:16 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 5 Nov 2009 17:29:16 -0000
Received: (qmail 89880 invoked by uid 500); 5 Nov 2009 17:29:15 -0000
Delivered-To: apmail-ant-user-archive@ant.apache.org
Received: (qmail 89804 invoked by uid 500); 5 Nov 2009 17:29:15 -0000
Mailing-List: contact user-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:user-unsubscribe@ant.apache.org>
List-Help: <mailto:user-help@ant.apache.org>
List-Post: <mailto:user@ant.apache.org>
List-Id: "Ant Users List" <user.ant.apache.org>
Reply-To: "Ant Users List" <user@ant.apache.org>
Delivered-To: mailing list user@ant.apache.org
Received: (qmail 89794 invoked by uid 99); 5 Nov 2009 17:29:15 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Nov 2009 17:29:15 +0000
X-ASF-Spam-Status: No, hits=-2.1 required=5.0
	tests=AWL,BAYES_00
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: local policy)
Received: from [12.107.188.150] (HELO mx1.compuware.com) (12.107.188.150)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Nov 2009 17:29:12 +0000
Received: from nasa-dtw-ex009.nasa.cpwr.corp (unknown [10.10.0.230])
	by mx1.compuware.com (Postfix) with ESMTP id AD18672D2C9
	for <user@ant.apache.org>; Thu,  5 Nov 2009 17:28:51 +0000 (GMT)
Received: from nasa-dtw-ex004.nasa.cpwr.corp ([10.10.1.107]) by
 nasa-dtw-ex009.nasa.cpwr.corp with Microsoft SMTPSVC(6.0.3790.3959);
	 Thu, 5 Nov 2009 12:28:51 -0500
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Subject: RE: Creating a fileset from a list of filenames
Date: Thu, 5 Nov 2009 12:28:51 -0500
Message-ID: 
 <C5000C4CBA7C604A963A765AF2771DB405634349@nasa-dtw-ex004.nasa.cpwr.corp>
In-Reply-To: <F67BA1A4-14A9-4425-94BC-13A0FB6573D8@gmail.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Creating a fileset from a list of filenames
Thread-Index: AcpePOckhuZAIAqmQGaituUjRICUxgAAGpvw
References: 
 <C5000C4CBA7C604A963A765AF2771DB40563431A@nasa-dtw-ex004.nasa.cpwr.corp>
 <896914.78779.qm@web55101.mail.re4.yahoo.com>
 <C5000C4CBA7C604A963A765AF2771DB405634345@nasa-dtw-ex004.nasa.cpwr.corp>
 <F67BA1A4-14A9-4425-94BC-13A0FB6573D8@gmail.com>
From: "Wray, Nathan" <Nathan.Wray@compuware.com>
To: "Ant Users List" <user@ant.apache.org>
X-OriginalArrivalTime: 05 Nov 2009 17:28:51.0590 (UTC)
 FILETIME=[7108D260:01CA5E3D]

It's not very typical to see an app aware of its environment when you're
running ant under cygwin.  The list of files dumped from the xmlproperty
for instance is identical.


-----Original Message-----
From: Matt Benson [mailto:gudnabrsam@gmail.com]=20
Sent: Thursday, November 05, 2009 12:24 PM
To: Ant Users List
Subject: Re: Creating a fileset from a list of filenames


On Nov 5, 2009, at 11:07 AM, Wray, Nathan wrote:

> Matt, David;
>
> Using pathconvert/fileset worked 90% of the time.  For some reason =20
> it failed under cygwin and instead of seeing the one changed file =20
> it would seek all the files from the base directory (I'd assume a =20
> globmapper failure, but I never found the exact issue).

This is almost certainly due to the differences between path =20
separators... the svn commands you use to generate the list are =20
windows-based.

-Matt

>
> I was surprised to find that the project already had ant-contrib =20
> installed, so I was able to use <for> after all:
>
> <for list=3D"${svnstat.status.target.entry.path}" =
param=3D"modifiedFile">
>   <sequential>
>   <if>
>     <matches pattern=3D"^.*?\.java$" string=3D"@{modifiedFile}" />
>     <then>
>       <checkstyle
>         config=3D"${basedir}/Checkstyle.xml"
>         failOnViolation=3D"true"
>         maxErrors=3D"25"
>         maxWarnings=3D"25"
>         file=3D"@{modifiedFile}"
>>
>       </checkstyle>
>     </then>
>     <!-- this "else" is debugging info
>     <else>
>        <echo message=3D"Skipping file, not java: @{modifiedFile}" />
>     </else>
>     -->
>   </if>
>   </sequential>
>  </for>
>
> One downside of processing each file individually is that the =20
> target fails after the first failed file; in a perfect world I'll =20
> figure out how to report all of the failures in every file, and =20
> then have the outer task fail.
>
> Thanks for your help!
> Nathan
>
> -----Original Message-----
> From: Matt Benson [mailto:gudnabrsam@yahoo.com]
> Sent: Tuesday, November 03, 2009 8:59 AM
> To: Ant Users List
> Subject: Re: Creating a fileset from a list of filenames
>
>
>
> --- On Tue, 11/3/09, Wray, Nathan <Nathan.Wray@compuware.com> wrote:
>
>> From: Wray, Nathan <Nathan.Wray@compuware.com>
>> Subject: Creating a fileset from a list of filenames
>> To: user@ant.apache.org
>> Date: Tuesday, November 3, 2009, 7:16 AM
>> Hi All;
>>
>>
>>
>> I'm trying to identify modified java files in an SVN
>> working copy and
>> run checkstyle on these files.  So far I've got a
>> property with a list
>> of everything modified like:
>>
>>
>>
>> /path/file1;/path/file2;/path/file3
>>
>>
>>
>> It seems like I need something the opposite of pathconvert
>> to turn this
>> property into a FileSet.
>>
>
> If you needed the new fileset for a task that had been updated to =20
> use resource collections, you could use the paths you have directly =20
> in a <files> collection.  However, since <checkstyle> doesn't seem =20
> to support the broader resource collection interface, it will be a =20
> bit more complicated.  See below:
>
>
>> Any suggestions?  The relevant part of my build file
>> follows:
>>
>>
>>
>> <exec executable=3D"svn"
>> outputproperty=3D"svn.status.out">
>>
>> <arg value=3D"status" />
>>
>> <arg value=3D"${basedir}/.." />
>>
>> <arg value=3D"--xml" />
>>
>> </exec>
>>
>>
>>
>> <xmlproperty prefix=3D"svnstat" collapseattributes=3D"true"
>> delimiter=3D";">
>>
>> <propertyset>
>>
>> <propertyref name=3D"svn.status.out"/>
>>
>> </propertyset>
>>
>> </xmlproperty>
>>
>>
>>
>> <!--
>>
>> Now svnstat.status.target.entry.path contains all of the
>> modified files
>>
>> and folders as a semicolon separated list
>>
>> This needs to be filtered to just .java files
>>
>> -->
>>
>> <echo  message=3D"unfiltered list of modified files:
>> ${svnstat.status.target.entry.path}"/>
>>
>>
>>
>> <!--
>>
>> This fails, the list is not a pathid
>>
>> -->
>>
>> <checkstyle  config=3D"./Checkstyle.xml">
>>
>> <fileset pathid=3D"svnstat.status.target.entry.path"/>
>>
>> </checkstyle>
>>
>>
>
> This is untested, but:
>
> <pathconvert property=3D"includespattern" pathsep=3D",">
>   <path path=3D"${svnstat.status.target.entry.path}" />
>   <globmapper from=3D"${basedir}/*" to=3D"*" handledirsep=3D"true" />
> </pathconvert>
>
> And then your fileset would be:
>
> <fileset dir=3D"${basedir}" includes=3D"${includespattern}">
>   <filename name=3D"**/*.java" />
> </fileset>
>
> HTH,
> Matt
>>
>>
>>
>>
>>
>> Thank you
>>
>> Nathan
>>
>>
>>
>>
>>
>>
>> The contents of this e-mail are intended for the named
>> addressee only. It contains information that may be
>> confidential. Unless you are the named addressee or an
>> authorized designee, you may not copy or use it, or disclose
>> it to anyone else. If you received it in error please notify
>> us immediately and then destroy it.
>>
>>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@ant.apache.org
> For additional commands, e-mail: user-help@ant.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@ant.apache.org
> For additional commands, e-mail: user-help@ant.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@ant.apache.org
For additional commands, e-mail: user-help@ant.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@ant.apache.org
For additional commands, e-mail: user-help@ant.apache.org