ant-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: Ant 1.7.1 - concat function no longer returns an 'empty' file if no source resources are found...
Date Wed, 15 Oct 2008 04:17:47 GMT
On Tue, 14 Oct 2008, Mark Salter <marksalter@talktalk.net> wrote:

> I would like to understand the expected result of a concat step that
> 'finds' no source files.
> 
> I believe that prior to version 1.7.1 the resultant file could
> include header and footer even if the no other files went in.
> 
> With 1.7.1, class :-
> 
>    src/main/org/apache/tools/ant/taskdefs/Concat.java
> 
> checks for zero source and returns.

sounds like a regression, but if we "fixed" it, we'd break
compatibility with 1.7.1.

> The following patch would make it work for me, but is this a
> reasonable change to suggest?

I'd add a new attribute that controls what to do if there are no files
to concatenate.  The default value is up for debate, but I'd opt for
1.7.1's behavior myself.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@ant.apache.org
For additional commands, e-mail: user-help@ant.apache.org


Mime
View raw message