ant-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Reilly" <peter.kitt.rei...@gmail.com>
Subject Re: ConcurrentModificationException
Date Thu, 11 Jan 2007 20:49:52 GMT
On 1/11/07, Matt Benson <gudnabrsam@yahoo.com> wrote:
> I agree, Peter.  However, the patch I am currently
> testing adds synchro blocks to all Hashtable copies in
> PropertyHelper.  :)
I agree, I was just too lazy to do it for the rest!
Peter

>
> -Matt
>
> --- Peter Reilly <peter.kitt.reilly@gmail.com> wrote:
>
> > Looking at the code and the stack error, the
> > following patch may
> > fix the problem:
> > Index:
> > src/main/org/apache/tools/ant/PropertyHelper.java
> >
> ===================================================================
> > ---
> > src/main/org/apache/tools/ant/PropertyHelper.java
> > (revision 495336)
> > +++
> > src/main/org/apache/tools/ant/PropertyHelper.java
> > (working copy)
> > @@ -470,7 +470,9 @@
> >       *         (including user properties).
> >       */
> >      public Hashtable getProperties() {
> > -        return new Hashtable(properties);
> > +        synchronized (properties) {
> > +            return new Hashtable(properties);
> > +        }
> >          // There is a better way to save the
> > context. This shouldn't
> >          // delegate to next, it's for backward
> > compatibility only.
> >      }
> >
> >
> > On 1/11/07, Thomas Voigt <tv_spambox@gmx.de> wrote:
> > > Hi,
> > >
> > > -------- Original-Nachricht --------
> > > Datum: Thu, 11 Jan 2007 11:23:50 -0600
> > > Von: "Andrew Close" <aclose@gmail.com>
> > > An: "Ant Users List" <user@ant.apache.org>
> > > Betreff: Re: ConcurrentModificationException
> > >
> > > > On 1/11/07, Thomas Voigt <tv_spambox@gmx.de>
> > wrote:
> > > > > Hi,
> > > > >
> > > > > we recently started to get
> > ConcurrentModificationExceptions with ant.
> > > > </snipped>
> > > >
> > > > are you testing this script out on your single
> > processor development
> > > > machine?  i've had problems with using thread
> > arguments on single
> > > > processor machines...
> > >
> > > No, but there are parts of the build that are
> > single threaded because we build a large number of
> > libraries that can't be easily parallelized, and the
> > error only occurs in the <parallel> sections.
> > >
> > > Regards, Thomas
> > >
> > > --
> > > Der GMX SmartSurfer hilft bis zu 70% Ihrer
> > Onlinekosten zu sparen!
> > > Ideal für Modem und ISDN:
> > http://www.gmx.net/de/go/smartsurfer
> > >
> > >
> >
> ---------------------------------------------------------------------
> > > To unsubscribe, e-mail:
> > user-unsubscribe@ant.apache.org
> > > For additional commands, e-mail:
> > user-help@ant.apache.org
> > >
> > >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail:
> > user-unsubscribe@ant.apache.org
> > For additional commands, e-mail:
> > user-help@ant.apache.org
> >
> >
>
>
>
>
> ____________________________________________________________________________________
> Have a burning question?
> Go to www.Answers.yahoo.com and get answers from real people who know.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@ant.apache.org
> For additional commands, e-mail: user-help@ant.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@ant.apache.org
For additional commands, e-mail: user-help@ant.apache.org


Mime
View raw message