From user-return-58992-apmail-ant-user-archive=ant.apache.org@ant.apache.org Fri Dec 08 17:42:45 2006
Return-Path: <user-return-58992-apmail-ant-user-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-user-archive@www.apache.org
Received: (qmail 92597 invoked from network); 8 Dec 2006 17:42:44 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 8 Dec 2006 17:42:44 -0000
Received: (qmail 28055 invoked by uid 500); 8 Dec 2006 17:42:15 -0000
Delivered-To: apmail-ant-user-archive@ant.apache.org
Received: (qmail 28019 invoked by uid 500); 8 Dec 2006 17:42:15 -0000
Mailing-List: contact user-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:user-unsubscribe@ant.apache.org>
List-Help: <mailto:user-help@ant.apache.org>
List-Post: <mailto:user@ant.apache.org>
List-Id: "Ant Users List" <user.ant.apache.org>
Reply-To: "Ant Users List" <user@ant.apache.org>
Delivered-To: mailing list user@ant.apache.org
Received: (qmail 27920 invoked by uid 99); 8 Dec 2006 17:42:14 -0000
Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Dec 2006 09:42:13 -0800
X-ASF-Spam-Status: No, hits=2.0 required=10.0
	tests=HTML_MESSAGE,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (herse.apache.org: domain of mlgiroux@gmail.com designates 64.233.166.183 as permitted sender)
Received: from [64.233.166.183] (HELO py-out-1112.google.com) (64.233.166.183)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Dec 2006 09:41:57 -0800
Received: by py-out-1112.google.com with SMTP id a29so451577pyi
        for <user@ant.apache.org>; Fri, 08 Dec 2006 09:41:36 -0800 (PST)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:mime-version:content-type;
        b=GPVsWHndiSqOuDohNEycqEe4p7qwRAuGNqvf+NAR/HadazkJNC+bPbYNJZmkKflLIo0WjmXj3O/NmU9/7+7nuUTZqQjHJZOY6UL/gDZ4fPfmCQDGVi6VFD4XYdkWKC4IJc3FfNBMgE++tyPY2F40ITuiPjFKIkfJx3POB/N/k50=
Received: by 10.35.121.2 with SMTP id y2mr4075057pym.1165599695872;
        Fri, 08 Dec 2006 09:41:35 -0800 (PST)
Received: by 10.35.128.11 with HTTP; Fri, 8 Dec 2006 09:41:35 -0800 (PST)
Message-ID: <5ea470920612080941o2266438eh6e53682becbffa5@mail.gmail.com>
Date: Fri, 8 Dec 2006 10:41:35 -0700
From: "Michael Giroux" <mlgiroux@gmail.com>
To: "Ant Users List" <user@ant.apache.org>
Subject: Invalid use of string utils in
MIME-Version: 1.0
Content-Type: multipart/alternative; 
	boundary="----=_Part_72703_29458313.1165599695834"
X-Virus-Checked: Checked by ClamAV on apache.org

------=_Part_72703_29458313.1165599695834
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Following is an excerpt from $ANT_HOME/etc/junit-noframes.xsl.

<!--
    template that will convert a carriage return into a br tag
    @param word the text from which to convert CR to BR tag
-->
<xsl:template name="br-replace">
    <xsl:param name="word"/>
    <xsl:param name="br"><br/></xsl:param>
    <xsl:value-of select='stringutils:replace(string($word),"&#xA;",$br)'/>
</xsl:template>

The purpose of the template is to convert new-lines to <br/> tags in text
such as stack traces. This template does not insert the desired <br/> tags
and only deletes the new-lines that are found.

I chased this for a week in the XALAN mailing list to learn that this is not
valid.

I was able to accomplish the desired effect (preserving formatting of the
stack trace) by adding <pre> ... </pre>  tags to the generated HTML and
removing the call to the br-replace template.  My solution is shown below.

Perhaps someone on the dev team could consider this for ANT 1.7?

Michael Giroux

<!-- Style for the error and failure in the tescase template -->
<xsl:template name="display-failures">
    <xsl:choose>
        <xsl:when test="not(@message)">N/A</xsl:when>
        <xsl:otherwise>
            <xsl:value-of select="@message"/>
        </xsl:otherwise>
    </xsl:choose>
    <!-- display the stacktrace -->
*    <pre>*
    <code>
        <br/>
        <xsl:value-of select="." />
*        <!--
        <xsl:call-template name="br-replace">
            <xsl:with-param name="word" select="."/>
        </xsl:call-template>
         -->
*    </code>
*    </pre>*
    <!-- the later is better but might be problematic for non-21"
monitors... -->
    <!--pre><xsl:value-of select="."/></pre-->
</xsl:template>

------=_Part_72703_29458313.1165599695834--