ant-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: Extension of the Javah-Task
Date Wed, 20 Apr 2005 19:08:54 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, 20 Apr 2005, Karsten Klohs <taiko@upb.de> wrote:

> | I agree.  Native support for filesets would be the cleanest
> | solution.
> |>>I appreciate any comments to this idea.
> |
> |
> | All it takes is somebody who does the coding and supplies a patch ;-)
> 
> here you are ;-)

Not really, I don't see any way to set fs.

> Can any Ant developer comment on the code snippet at the end of the
> mail?

(1) No need to extend Javah, just add the code to the original task.

(2) Use addFileset(FileSet fs) and add fs to collection on each
invocation, you get support for multiple FileSets for free.

(3) Unit test is missing 8-)

(4) Documentation patch is missing.

> - Transform a file name to a full qualified path name by stripping
> the ".class" suffix and replacing all "file.separtor" occurrences
> with the character "."

Follow Matt's idea and leave that to mappers.

> - simulate the insertion of a nested class attribute in the original
> implementation

I'd place the logic into Javah#getClasses and the rest of the task
would remain the same.

> - what shall the task do, if the file given file is not a class file
> i.e. it is not ending with ".class"? Acutally, it throws a
> BuildException (yes, I am paranoid ;-) )

Reasonable.

> - The implicit convention, is that the full file name exactly
> corresponds to the full class name. How can this restriction be
> relaxed?

Why?  If you allow multiple filesets, users can always use one per
class hierarchy root.

> Can anybody tell me how such issues are usually discussed because I
> am not sure that implementation and integration details belong in
> this user list.

dev@ant.apache.org

Cheers

        Stefan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQFCZqjBohFa4V9ri3IRAqAAAKCPucYF6cTmyIcAvRoQjyGuqt40AwCdEVqo
x4isvX/G1GTJfmdItGJGpk0=
=3fFl
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@ant.apache.org
For additional commands, e-mail: user-help@ant.apache.org


Mime
View raw message