ant-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Benson <gudnabr...@yahoo.com>
Subject Changing method signatures WAS Re: Extension of the Javah-Task
Date Wed, 20 Apr 2005 19:33:47 GMT
--- Stefan Bodewig <bodewig@apache.org> wrote:
> On Wed, 20 Apr 2005, Matt Benson
> <gudnabrsam@yahoo.com> wrote:
> 
> >> (2) Use addFileset(FileSet fs) and add fs to
> collection on each
> >> invocation, you get support for multiple FileSets
> for free.
> > 
> > Better yet, use add(FileSet fs) just because you
> can.
> 
> True, a good place to turn it into
> add(ResourceCollection) later.

Where do we stand on that? i.e. the above requires
3rd-party code to recompile, or we can be nice and
turn:

public void add(FileSet fs) {
  /* a Collection */ c.add(fs);
}

to:

public void add(FileSet fs) {
  add((ResourceCollection) fs);
}

public void add(ResourceCollection rc) {
  c.add(rc);
}

Also, for tasks like this where the nested element
should provide files that have a basedir, does it make
sense to provide support for generic
ResourceCollections, or should these be restricted to
FileSets because they a) exist and b) have a definite
base ?  I have been thinking the latter.

-Matt

> 
> Stefan
> 
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> user-unsubscribe@ant.apache.org
> For additional commands, e-mail:
> user-help@ant.apache.org
> 
> 

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@ant.apache.org
For additional commands, e-mail: user-help@ant.apache.org


Mime
View raw message