ant-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Donal Quinlan <do...@savvion.com>
Subject Re: exit code
Date Thu, 17 Apr 2003 00:23:57 GMT
Thanks Antoine and Steve. I have submitted

19099 <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19099>



Donal

Antoine Levy-Lambert wrote:

>Donal,
>
>in an Ant source download, there is a path called src/etc/testcases
>
>You should add something specific demonstrating your new features in
>src/etc/testcases/taskdefs/java.xml
>and
>src/testcases/org/apache/tools/ant/taskdefs/JavaTest.java
>
>
>these files are the one doing the tests on the Java task
>
>if you install your compiled version of ant, then do the following
>
>ant -D'testcase=org.apache.tools.ant.taskdefs.JavaTest' run-single-test
>
>you can check that the testcase is still working.
>
>Antoine
>----- Original Message -----
>From: "Donal Quinlan" <donal@savvion.com>
>To: "Ant Users List" <user@ant.apache.org>
>Sent: Wednesday, April 16, 2003 12:57 AM
>Subject: Re: exit code
>
>
>  
>
>>I have the cvs diff's for the src and the html ready. I cannot find
>>examples/templates to follow for testing in  Bugzilla. Obviously I can
>>test it, but what is the convention for testing? I can't see anything in
>>Bugzilla that includes junit tests in the patch enhancement. I am new to
>>Bugzilla and could be missing something completely obvious.
>>
>>Donal
>>
>>Steve Loughran wrote:
>>
>>    
>>
>>>Donal Quinlan wrote:
>>>
>>>      
>>>
>>>>I want to avoid using <exec> because of all the os issues it will
>>>>        
>>>>
>cause.
>  
>
>>>>However I successfully grafted the resultproperty code from
>>>>ExecTask.java and put it into a custom java task (which was a copy of
>>>>Java.java). This worked like a dream.
>>>>
>>>>   <taskdef name="resultjava"
>>>>            classname="com.savvion.tools.ant.taskdefs.ResultJava"/>
>>>>....
>>>>     <resultjava classname="com.installshield.isje.ISJE" fork="true"
>>>>failonerror="false"
>>>>           resultproperty="exitcode"
>>>>           dir="${mp50.dir}" jvm="${mp50.jvm}">
>>>>....
>>>>
>>>>     <condition property="good.installer.build">
>>>>       <or>
>>>>         <equals arg1="${exitcode}" arg2="0" />
>>>>         <equals arg1="${exitcode}" arg2="-1" />
>>>>       </or>
>>>>     </condition>
>>>>     <fail unless="${good.installer.build}"
>>>>           message="More than just warnings occurred when building
>>>>MultiPlatform installer, exitcode = ${exitcode}"/>
>>>>
>>>>This was so simple to add, I think it should be made part of the
>>>>normal <java> task. I would be willing to do it (because it's simple
>>>>:-)  )
>>>>        
>>>>
>>>Post it as a bugzilla patch, along with test and the doc changes then :)
>>>
>>>-steve
>>>
>>>
>>>---------------------------------------------------------------------
>>>To unsubscribe, e-mail: user-unsubscribe@ant.apache.org
>>>For additional commands, e-mail: user-help@ant.apache.org
>>>
>>>      
>>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: user-unsubscribe@ant.apache.org
>>For additional commands, e-mail: user-help@ant.apache.org
>>
>>    
>>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: user-unsubscribe@ant.apache.org
>For additional commands, e-mail: user-help@ant.apache.org
>
>  
>



Mime
View raw message