ant-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran" <stev...@iseran.com>
Subject Re: ant-developers. Change of behaviour of <websphere> element nested in <ejbjar>
Date Wed, 23 Oct 2002 16:52:56 GMT

----- Original Message -----
From: "George Spalding" <georgespalding@yahoo.com>
To: <ant-user@jakarta.apache.org>
Sent: Tuesday, October 22, 2002 11:54 PM
Subject: ant-developers. Change of behaviour of <websphere> element nested
in <ejbjar>


> Hi all.
>
> Theres feature in the <weblogic> nested task
> that I would like to change.
> Although there are errors in the ejbdeployment, ant does not fail.
>
> Quotation from the build log:
> ...
> [ejbdeploy] [*Error] /logistics-integration.jar(Class:........
> [ejbdeploy] [*Warning] /logistics-integration.jar(Method: cr....
> [ejbdeploy] [*Error] /logistics-integration.jar(Class:...
> [ejbdeploy] [*Error] ejbModule/META-INF/ejb-jar.xml(En....
> [ejbdeploy] Shutting down workbench.
> [ejbdeploy] Execution Halted: Validation Errors Reported
> [ejbdeploy] 3 Errors, 1 Warnings, 0 Informational Messages
> [ejbdeploy] Java Result: 1
> ...
> BUILD SUCCESSFUL
> Total time: 38 seconds
>
> I tracked the problem down to
> org\apache\tools\ant\taskdefs\optional\ejb\WebsphereDeploymentTool.java
>
> When I modified the existing java task to fail on error:
> javaTask.setFailonerror(true)
> it behaves the way I want it to.
>
> Now, what do you think? Isn't this the way we all want it to work?!
> Perhaps some users want to be able to go on with their other nested
> ejbjar tasks (such as jboss...) one could have an attribute
> "failonerror" either in the ejbjar or websphere task, that controls
> this.
>
> As I'm not a committer, (I lack the skills and time) can You help me
> with this? It may just be a matter of reviewing and committing my
> changes. If you think they're good enough, that is...  ;)

This is really the kind of thing to cover in ant-dev.

-I believe you are correct, failonerror is the behaviour one would expect
-but now we are probably constrained by compatibility to leave it off by
default
-the fix is to add a failonerror attribute, default false.


--
To unsubscribe, e-mail:   <mailto:ant-user-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-user-help@jakarta.apache.org>


Mime
View raw message