Return-Path: Delivered-To: apmail-jakarta-ant-user-archive@apache.org Received: (qmail 29861 invoked from network); 2 Jan 2002 10:16:37 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 2 Jan 2002 10:16:37 -0000 Received: (qmail 27721 invoked by uid 97); 2 Jan 2002 10:16:42 -0000 Delivered-To: qmlist-jakarta-archive-ant-user@jakarta.apache.org Received: (qmail 27686 invoked by uid 97); 2 Jan 2002 10:16:41 -0000 Mailing-List: contact ant-user-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Users List" Reply-To: "Ant Users List" Delivered-To: mailing list ant-user@jakarta.apache.org Received: (qmail 27675 invoked from network); 2 Jan 2002 10:16:40 -0000 Message-ID: <00b201c18c54$c2ebf670$0801a8c0@cv.hp.com> From: "Steve Loughran" To: "Ant Users List" References: Subject: Re: TelnetTask.java Date: Mon, 24 Dec 2001 00:26:58 -0800 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2600.0000 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000 X-ECS-MailScanner: Found to be clean X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Johannes, adding regexp support would indeed make telnet more robust. why dont you submit it to ant-dev, having a look at the ant task guidelines first about a) how to submit changes to a task, b) what is expected in documentation and changes, c) why tabs are not allowed in the source. Looking at the code, I think it'd be critical to copy the regexp mapper and use the regexp library support found in org.apache.tools.ant.util.regexp, particularly: org.apache.tools.ant.util.regexp.RegexpMatcher; org.apache.tools.ant.util.regexp.RegexpMatcherFactory; This regexp package provides a layer of indirection and will pick up on any of the supported regexp implementations found on the classpath, rather than have support for a single one hard coded into a task. If you can add that, and still ensure that telnet runs without any regexp package being present (dont want to break someone elses build), then you would probably stand a good chance of getting it into the build. ----- Original Message ----- From: "Johannes van der Merwe" To: Sent: Sunday, December 23, 2001 23:09 Subject: TelnetTask.java > I have added regular expression capabilities to TelnetTask.java so that one > can build more sophisticated sequences-I also made some new attributes: > flags defaults to RE.MULTILINE, and verbose to false. One can specify either > a string or regex. I have changed the while loops a bit in the > waitForRegex() function(please check whether this kind of logic make more > sense), and made it return a string - this helps a lot with debugging > sequences. The default flags is 8, meaning multiline recognition. > > Kind regards > Jo van der Merwe > ---------------------------------------------------------------------------- ---- > -- > To unsubscribe, e-mail: > For additional commands, e-mail: -- To unsubscribe, e-mail: For additional commands, e-mail: