ant-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Hatcher" <jakarta-...@ehatchersolutions.com>
Subject Re: Javascript errors
Date Thu, 27 Sep 2001 20:47:29 GMT
Here are some pointers.   Script.java does this:

            addBeans(project.getProperties());
            addBeans(project.getUserProperties());
            addBeans(project.getTargets());
            addBeans(project.getReferences());

These are the things it provides to the script.  The caveat is that addBeans
skips any items that have characters in their name that are not part of
valid Java identifiers (perhaps a modification to replace illegal characters
with underscores would be more appropriate).  It would be a one-line change
to have "project" accessible like this:

    beans.put("project", getProject());

My concerns are that there could be a clash if there was a property, target,
or reference named "project" - so adding that line could potentially break
backwards compatibility, but its unlikely and seems like a good change to
make.

    Erik


----- Original Message -----
From: "Robert Seeger" <rseeger@nortelnetworks.com>
To: <ant-user@jakarta.apache.org>
Sent: Thursday, September 27, 2001 1:04 PM
Subject: Re: Javascript errors


> Sounds like that's a great way to solve my problem. I'll take a look at
the
> code and see if I can figure it out myself. I doubt I'll find the time
> anytime soon (leaving on my honeymoon this weekend), but I can try :)
>
> Thanks,
> Rob Seeger
>
> At 12:06 PM 9/27/01 -0700, you wrote:
> >This problem actually could be alleviated with a patch to the <script>
task
> >such that the project reference was fed to BSF with the name "project"
> >rather than as the name of the project.   I've got a few such similar
> >patches on my to-do list for the <script> task to make using it easier.
I
> >won't have time to get to this patch very soon though, but it appears to
be
> >a straightforward change.
> >
> >    Erik
> >
> >
> >----- Original Message -----
> >From: "Robert Seeger" <rseeger@nortelnetworks.com>
> >To: <ant-user@jakarta.apache.org>
> >Sent: Thursday, September 27, 2001 11:16 AM
> >Subject: Re: Javascript errors
> >
> >
> >> I guess the thing is that I'm trying to follow the previous design
> >> decisions used to the makefiles, and that isn't the best way to go
about
> >> using Ant. Since I have a lot of experience with make, and little with
> >Ant,
> >> it would make my life easier. However, it seems certain things are easy
to
> >> do with make, and hard to do with Ant, and vice versa.
> >>
> >> The reason for using different project names for each subpackage,
however,
> >> is to distinguish between them. I don't really see the reason to use a
> >> project name unless you're going to use it to distinguish the projects
in
> >> some way.
> >>
> >> As an aside, can you have more than one project in a build.xml file? If
> >> not, is there a reason why the javascript code needs to use the project
> >> name, rather than some keyword, like "project"?
> >>
> >> Rob Seeger
> >>
> >> At 10:44 AM 9/27/01 -0700, you wrote:
> >> >--- Robert Seeger <rseeger@nortelnetworks.com> wrote:
> >> >> *sigh* I was afraid it would wind up coming down to that.
> >> >
> >> >Why "sigh"? What does having a different <project> name for each of
the
> >> >sub-buildfiles do for you? Do you use it some way? If you need some
> >> >property to distinguish each package, you can always just define a
> >> >"package" property to be the name you'd previously used as <project>'s
> >> >name.
> >> >
> >> >Diane
> >> >
> >> >
> >> >
> >> >=====
> >> >(holtdl@yahoo.com)
> >> >
> >> >
> >> >
> >> >__________________________________________________
> >> >Do You Yahoo!?
> >> >Listen to your Yahoo! Mail messages from any phone.
> >> >http://phone.yahoo.com
> >> >
> >> ========================================
> >> Robert Seeger
> >> Network Engineer
> >> Nortel Networks
> >>
> >> Telephone: (518)237-2087
> >> Pager: (800)SKY-8888  Pin#1264792
> >> Fax: (518)237-4190
> >> Email: rseeger@nortelnetworks.com
> >> Address: 224 5th Ave, Apt#2
> >> Lansingburgh, NY 12182
> >> ========================================
> >>
> >
> >
> ========================================
> Robert Seeger
> Network Engineer
> Nortel Networks
>
> Telephone: (518)237-2087
> Pager: (800)SKY-8888  Pin#1264792
> Fax: (518)237-4190
> Email: rseeger@nortelnetworks.com
> Address: 224 5th Ave, Apt#2
> Lansingburgh, NY 12182
> ========================================
>


Mime
View raw message