ant-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Les Hughes <leslie.hug...@rubus.com>
Subject RE: P4 Optional Tasks
Date Fri, 29 Jun 2001 10:02:00 GMT

Hi,

The use of an array instead of a single string was a bug fix submitted by
someone a while back. I guess the reporting side wasn't updated at the same
time to reflect the change in how p4base does exec.

Diane, could you commit a patch for this?

Thanks,

Les


> -----Original Message-----
> From: Diane Holt [mailto:holtdl@yahoo.com]
> Sent: 29 June 2001 02:59
> To: ant-user@jakarta.apache.org
> Subject: RE: P4 Optional Tasks
> 
> 
> --- Kazandjian Erik <Erik.Kazandjian@siemens.atea.be> wrote:
> > I made a small sync.xml (Which I added to this mail) When I run ant
> > -buildfile sunc.xml -verbose 
> > 
> > I get :
> > >Ant version 1.3 compiled on March 2 2001
> > 
> [snip]
> > >sync:
> > >   [p4sync] Execing sync  
> > >   [p4sync] Execing [Ljava.lang.String;@3753f8
> 
> The second "Execing ..." logging output is funky because it's 
> an array of
> strings rather than a string. I couldn't find anything on the 
> Java site
> that said how to print out that sort of thing, so I converted 
> it "by hand"
> (which is probably way wrong) to a string, then referenced that in the
> call to log() -- in P4Base.java:
> 
>     148             commandline.createArgument().setLine(command);
>     149
>     150             String[] cmdline = commandline.getCommandline() ;
>     151             String cmdl = "";
>     152             for (int i=0 ; i < cmdline.length ; i++)
>     153             {
>     154                 cmdl += cmdline[i] + " ";
>     155             }
>     156             log("Execing " + cmdl, Project.MSG_VERBOSE);
>     157
> 
> But at least now it prints out what the command actually is:
> 
>    [p4sync] Execing sync
>    [p4sync] Execing p4 -udianeh -s sync
>    [p4sync] File(s) up-to-date.
> 
> So you might want to modify your P4Base.java for now (as 
> above, or in some
> more correct way, if you know Java :), so you can at least 
> see what the
> actual command line is, to make sure that's at least okay. As to your
> actual problem:
> 
> > >   [p4sync] Unknown command.  Try 'p4 help' for info.
> > 
> > >BUILD SUCCESSFUL
> >
> > It looks like the build has succeeded (BUILD SUCCESSFUL) 
> but I am a bit
> > worried about the messages that p4sync gives me. Is this normal?
> 
> It's really peculiar that the build succeeds, since the P4* 
> tasks look for
> "error:" and throw a BuildException when the output has one, 
> and since you
> said you could run 'p4 -s <somecommand>' and get the expected prefixed
> output, it's really hard to say why that would be failing to 
> catch "error:
> Unknown command. Try 'p4 help' for info.", since cleary that 
> has "error:"
> in it (and I modified P4Sync.java to send 'p4 -s foo', just 
> in case, and I
> definitely got a build failure).
> 
> Diane
> 
> 
> =====
> (holtdl@yahoo.com)
> 
> 
> 
> __________________________________________________
> Do You Yahoo!?
> Get personalized email addresses from Yahoo! Mail
> http://personal.mail.yahoo.com/
> 

Mime
View raw message