ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IVY-1104) ivy.deps.changed does not work with extra attributes
Date Thu, 02 Aug 2018 05:40:00 GMT

    [ https://issues.apache.org/jira/browse/IVY-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566377#comment-16566377
] 

ASF GitHub Bot commented on IVY-1104:
-------------------------------------

Github user aprelev commented on the issue:

    https://github.com/apache/ant-ivy/pull/73
  
    @twogee, why don't we just stick with deterministic encoding like 
    ```Java
    extra-<qualifiedName> // e.g. extra-e:foo, extra-m:classifier, extra-foo
    ```
    since both `'-'` and `':'` are allowed name characters? This would also incur minimum
changes to the codebase: literally passing `::getQualifiedExtraAttributes()` to `XmlReportWriter::extraToString()`
so qualifiers can be picked up by `XmlReportParser::startElement()` automatically.
    
    Or, if you want to avoid using `':'` in the report (if original `extra-` prefix was supposed
to replace the namespace, as you guessed it was), we could use another deterministic encoding
like
    ```Java
    extra-<qualifier>-<name> // e.g. extra-e-foo, extra-m-classifier, extra--foo
    ```
    which would require additional encoding and decoding overhead in both XML report parser
and writer, but otherwise imply no restrictions on naming?
    
    Also, in the name of code clarity and with respect to single responsibility principle,
in my opinion, it would be better if `ExtendableItemHelper` handled both encoding and decoding
of attributes (as of now, encoding is handled by `XmlReportWriter::extraToString()`).


> ivy.deps.changed does not work with extra attributes
> ----------------------------------------------------
>
>                 Key: IVY-1104
>                 URL: https://issues.apache.org/jira/browse/IVY-1104
>             Project: Ivy
>          Issue Type: Bug
>            Reporter: Juha Ranta
>            Priority: Major
>
> If you have extra attributes in module B and then do resolve in module A which depends
on B, the property ivy.deps.changed is always set to true. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message