ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IVY-1104) ivy.deps.changed does not work with extra attributes
Date Fri, 03 Aug 2018 21:48:00 GMT

    [ https://issues.apache.org/jira/browse/IVY-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568833#comment-16568833
] 

ASF GitHub Bot commented on IVY-1104:
-------------------------------------

Github user aprelev commented on a diff in the pull request:

    https://github.com/apache/ant-ivy/pull/73#discussion_r207675516
  
    --- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java ---
    @@ -193,16 +193,8 @@ public void startElement(String uri, String localName, String qName,
                             String branch = attributes.getValue("branch");
                             String revision = attributes.getValue("revision");
                             Map<String, String> extraAttributes = new HashMap<>();
    --- End diff --
    
    It was, until I reused code for attributes extraction from `ExtendableItemHelper`. 


> ivy.deps.changed does not work with extra attributes
> ----------------------------------------------------
>
>                 Key: IVY-1104
>                 URL: https://issues.apache.org/jira/browse/IVY-1104
>             Project: Ivy
>          Issue Type: Bug
>            Reporter: Juha Ranta
>            Priority: Major
>
> If you have extra attributes in module B and then do resolve in module A which depends
on B, the property ivy.deps.changed is always set to true. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message