ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bode...@apache.org
Subject [06/11] ant git commit: Let’s use doclint
Date Sun, 10 Dec 2017 07:58:51 GMT
http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/compilers/JavacExternal.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/compilers/JavacExternal.java b/src/main/org/apache/tools/ant/taskdefs/compilers/JavacExternal.java
index ab28454..e227ecf 100644
--- a/src/main/org/apache/tools/ant/taskdefs/compilers/JavacExternal.java
+++ b/src/main/org/apache/tools/ant/taskdefs/compilers/JavacExternal.java
@@ -66,9 +66,9 @@ public class JavacExternal extends DefaultCompilerAdapter {
 
     /**
      * helper method to execute our command on VMS.
-     * @param cmd
-     * @param firstFileName
-     * @return
+     * @param cmd Commandline
+     * @param firstFileName int
+     * @return boolean
      */
     private boolean execOnVMS(Commandline cmd, int firstFileName) {
         File vmsFile = null;

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/condition/Http.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/condition/Http.java b/src/main/org/apache/tools/ant/taskdefs/condition/Http.java
index 4c04278..0958c2d 100644
--- a/src/main/org/apache/tools/ant/taskdefs/condition/Http.java
+++ b/src/main/org/apache/tools/ant/taskdefs/condition/Http.java
@@ -67,7 +67,7 @@ public class Http extends ProjectComponent implements Condition {
      *
      * @param method The HTTP request method to use. Valid values are
      *               the same as those accepted by the
-     *               HttpURLConnection.setRequestMetho d() method,
+     *               HttpURLConnection.setRequestMethod() method,
      *               such as "GET", "HEAD", "TRACE", etc. The default
      *               if not specified is "GET".
      *
@@ -82,6 +82,8 @@ public class Http extends ProjectComponent implements Condition {
     /**
      * Whether redirects sent by the server should be followed,
      * defaults to true.
+     *
+     * @param f boolean
      * @since Ant 1.9.7
      */
     public void setFollowRedirects(boolean f) {

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/condition/IsLastModified.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/condition/IsLastModified.java b/src/main/org/apache/tools/ant/taskdefs/condition/IsLastModified.java
index ddacd99..a8bdbba 100644
--- a/src/main/org/apache/tools/ant/taskdefs/condition/IsLastModified.java
+++ b/src/main/org/apache/tools/ant/taskdefs/condition/IsLastModified.java
@@ -153,8 +153,8 @@ public class IsLastModified extends ProjectComponent implements Condition {
 
     /**
      * evaluate the condition
-     * @return true or false depending on the compoarison mode and the time of the resource
-     * @throws BuildException
+     * @return true or false depending on the comparison mode and the time of the resource
+     * @throws BuildException if something goes wrong
      */
     public boolean eval() throws BuildException {
         validate();

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/condition/IsReachable.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/condition/IsReachable.java b/src/main/org/apache/tools/ant/taskdefs/condition/IsReachable.java
index e699da1..e673b82 100644
--- a/src/main/org/apache/tools/ant/taskdefs/condition/IsReachable.java
+++ b/src/main/org/apache/tools/ant/taskdefs/condition/IsReachable.java
@@ -187,7 +187,7 @@ public class IsReachable extends ProjectComponent implements Condition {
                 //utterly implausible, but catered for anyway
                 throw new BuildException("When calling " + reachableMethod);
             } catch (final InvocationTargetException e) {
-                //assume this is an IOexception about un readability
+                //assume this is an IOException about un readability
                 final Throwable nested = e.getTargetException();
                 log(ERROR_ON_NETWORK + target + ": " + nested.toString());
                 //any kind of fault: not reachable.

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/condition/Os.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/condition/Os.java b/src/main/org/apache/tools/ant/taskdefs/condition/Os.java
index 974c396..7bd5b01 100644
--- a/src/main/org/apache/tools/ant/taskdefs/condition/Os.java
+++ b/src/main/org/apache/tools/ant/taskdefs/condition/Os.java
@@ -102,8 +102,8 @@ public class Os implements Condition {
 
     /**
      * OpenJDK is reported to call MacOS X "Darwin"
-     * @see https://issues.apache.org/bugzilla/show_bug.cgi?id=44889
-     * @see https://issues.apache.org/jira/browse/HADOOP-3318
+     * @see <a href="https://issues.apache.org/bugzilla/show_bug.cgi?id=44889">Bugzilla</a>
+     * @see <a href="https://issues.apache.org/jira/browse/HADOOP-3318">Jira</a>
      */
     private static final String DARWIN = "darwin";
 
@@ -126,8 +126,8 @@ public class Os implements Condition {
     /**
      * Sets the desired OS family type
      *
-     * @param f      The OS family type desired<br>
-     *               Possible values:<br>
+     * @param f      The OS family type desired
+     *               <p>Possible values:</p>
      *               <ul>
      *               <li>dos</li>
      *               <li>mac</li>

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/condition/ResourceExists.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/condition/ResourceExists.java b/src/main/org/apache/tools/ant/taskdefs/condition/ResourceExists.java
index feda65b..0e4de58 100644
--- a/src/main/org/apache/tools/ant/taskdefs/condition/ResourceExists.java
+++ b/src/main/org/apache/tools/ant/taskdefs/condition/ResourceExists.java
@@ -32,6 +32,8 @@ public class ResourceExists extends ProjectComponent implements Condition {
 
     /**
      * The resource to test.
+     *
+     * @param r Resource
      */
     public void add(Resource r) {
         if (resource != null) {

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java b/src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java
index b4b51ce..81dadfd 100644
--- a/src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java
+++ b/src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java
@@ -42,36 +42,24 @@ import org.apache.tools.ant.util.FileUtils;
  *
  * It produces an XML output representing the list of changes.
  * <pre>
- * <font color=#0000ff>&lt;!-- Root element --&gt;</font>
- * <font color=#6a5acd>&lt;!ELEMENT</font> changelog <font color=#ff00ff>
- * (entry</font><font color=#ff00ff>+</font><font color=#ff00ff>)
- * </font><font color=#6a5acd>&gt;</font>
- * <font color=#0000ff>&lt;!-- CVS Entry --&gt;</font>
- * <font color=#6a5acd>&lt;!ELEMENT</font> entry <font color=#ff00ff>
- * (date,author,file</font><font color=#ff00ff>+</font><font color=#ff00ff>,msg)
- * </font><font color=#6a5acd>&gt;</font>
- * <font color=#0000ff>&lt;!-- Date of cvs entry --&gt;</font>
- * <font color=#6a5acd>&lt;!ELEMENT</font> date <font color=#ff00ff>(#PCDATA)
- * </font><font color=#6a5acd>&gt;</font>
- * <font color=#0000ff>&lt;!-- Author of change --&gt;</font>
- * <font color=#6a5acd>&lt;!ELEMENT</font> author <font color=#ff00ff>(#PCDATA)
- * </font><font color=#6a5acd>&gt;</font>
- * <font color=#0000ff>&lt;!-- List of files affected --&gt;</font>
- * <font color=#6a5acd>&lt;!ELEMENT</font> msg <font color=#ff00ff>(#PCDATA)
- * </font><font color=#6a5acd>&gt;</font>
- * <font color=#0000ff>&lt;!-- File changed --&gt;</font>
- * <font color=#6a5acd>&lt;!ELEMENT</font> file <font color=#ff00ff>
- * (name,revision,prevrevision</font><font color=#ff00ff>?</font>
- * <font color=#ff00ff>)</font><font color=#6a5acd>&gt;</font>
- * <font color=#0000ff>&lt;!-- Name of the file --&gt;</font>
- * <font color=#6a5acd>&lt;!ELEMENT</font> name <font color=#ff00ff>(#PCDATA)
- * </font><font color=#6a5acd>&gt;</font>
- * <font color=#0000ff>&lt;!-- Revision number --&gt;</font>
- * <font color=#6a5acd>&lt;!ELEMENT</font> revision <font color=#ff00ff>
- * (#PCDATA)</font><font color=#6a5acd>&gt;</font>
- * <font color=#0000ff>&lt;!-- Previous revision number --&gt;</font>
- * <font color=#6a5acd>&lt;!ELEMENT</font> prevrevision <font color=#ff00ff>
- * (#PCDATA)</font><font color=#6a5acd>&gt;</font>
+ * &lt;!-- Root element --&gt;
+ * &lt;!ELEMENT changelog (entry+)&gt;
+ * &lt;!-- CVS Entry --&gt;
+ * &lt;!ELEMENT entry (date,author,file+,msg)&gt;
+ * &lt;!-- Date of cvs entry --&gt;
+ * &lt;!ELEMENT date (#PCDATA)&gt;
+ * &lt;!-- Author of change --&gt;
+ * &lt;!ELEMENT author (#PCDATA)&gt;
+ * &lt;!-- List of files affected --&gt;
+ * &lt;!ELEMENT msg (#PCDATA)&gt;
+ * &lt;!-- File changed --&gt;
+ * &lt;!ELEMENT file (name,revision,prevrevision?)&gt;
+ * &lt;!-- Name of the file --&gt;
+ * &lt;!ELEMENT name (#PCDATA)&gt;
+ * &lt;!-- Revision number --&gt;
+ * &lt;!ELEMENT revision (#PCDATA)&gt;
+ * &lt;!-- Previous revision number --&gt;
+ * &lt;!ELEMENT prevrevision (#PCDATA)&gt;
  * </pre>
  *
  * @since Ant 1.5
@@ -191,6 +179,7 @@ public class ChangeLogTask extends AbstractCvsTask {
      * Whether to use rlog against a remote repository instead of log
      * in a working copy's directory.
      *
+     * @param remote boolean
      * @since Ant 1.8.0
      */
     public void setRemote(final boolean remote) {

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/cvslib/CvsTagDiff.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/cvslib/CvsTagDiff.java b/src/main/org/apache/tools/ant/taskdefs/cvslib/CvsTagDiff.java
index 6f17402..79111bd 100644
--- a/src/main/org/apache/tools/ant/taskdefs/cvslib/CvsTagDiff.java
+++ b/src/main/org/apache/tools/ant/taskdefs/cvslib/CvsTagDiff.java
@@ -45,9 +45,9 @@ import org.w3c.dom.Element;
  * Examines the output of cvs rdiff between two tags.
  *
  * It produces an XML output representing the list of changes.
- * <PRE>
+ * <pre>
  * &lt;!-- Root element --&gt;
- * &lt;!ELEMENT tagdiff ( entry+ ) &gt;
+ * &lt;!ELEMENT tagdiff (entry+) &gt;
  * &lt;!-- Start tag of the report --&gt;
  * &lt;!ATTLIST tagdiff startTag NMTOKEN #IMPLIED &gt;
  * &lt;!-- End tag of the report --&gt;
@@ -58,16 +58,16 @@ import org.w3c.dom.Element;
  * &lt;!ATTLIST tagdiff endDate NMTOKEN #IMPLIED &gt;
  *
  * &lt;!-- CVS tag entry --&gt;
- * &lt;!ELEMENT entry ( file ) &gt;
+ * &lt;!ELEMENT entry (file) &gt;
  * &lt;!-- File added, changed or removed --&gt;
- * &lt;!ELEMENT file ( name, revision?, prevrevision? ) &gt;
+ * &lt;!ELEMENT file (name, revision?, prevrevision?) &gt;
  * &lt;!-- Name of the file --&gt;
- * &lt;!ELEMENT name ( #PCDATA ) &gt;
+ * &lt;!ELEMENT name (#PCDATA) &gt;
  * &lt;!-- Revision number --&gt;
- * &lt;!ELEMENT revision ( #PCDATA ) &gt;
+ * &lt;!ELEMENT revision (#PCDATA) &gt;
  * &lt;!-- Previous revision number --&gt;
- * &lt;!ELEMENT prevrevision ( #PCDATA ) &gt;
- * </PRE>
+ * &lt;!ELEMENT prevrevision (#PCDATA) &gt;
+ * </pre>
  *
  * @since Ant 1.5
  * @ant.task name="cvstagdiff"

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/email/EmailAddress.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/email/EmailAddress.java b/src/main/org/apache/tools/ant/taskdefs/email/EmailAddress.java
index edc9c9d..25e3555 100644
--- a/src/main/org/apache/tools/ant/taskdefs/email/EmailAddress.java
+++ b/src/main/org/apache/tools/ant/taskdefs/email/EmailAddress.java
@@ -92,15 +92,15 @@ public class EmailAddress {
             }
         }
 
-        // DEBUG: System.out.println( email );
+        // DEBUG: System.out.println(email);
         if (end == 0) {
             end = len;
         }
-        // DEBUG: System.out.println( "address: " + start + " " + end );
+        // DEBUG: System.out.println("address: " + start + " " + end);
         if (nEnd == 0) {
             nEnd = len;
         }
-        // DEBUG: System.out.println( "name: " + nStart + " " + nEnd );
+        // DEBUG: System.out.println("name: " + nStart + " " + nEnd);
 
         this.address = trim(email.substring(start, end), true);
         this.name = trim(email.substring(nStart, nEnd), false);

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/email/EmailTask.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/email/EmailTask.java b/src/main/org/apache/tools/ant/taskdefs/email/EmailTask.java
index 0a5bc68..7657794 100644
--- a/src/main/org/apache/tools/ant/taskdefs/email/EmailTask.java
+++ b/src/main/org/apache/tools/ant/taskdefs/email/EmailTask.java
@@ -111,6 +111,7 @@ public class EmailTask extends Task {
 
     /**
      * Set the user for SMTP auth; this requires JavaMail.
+     *
      * @param user the String username.
      * @since Ant 1.6
      */
@@ -120,6 +121,7 @@ public class EmailTask extends Task {
 
     /**
      * Set the password for SMTP auth; this requires JavaMail.
+     *
      * @param password the String password.
      * @since Ant 1.6
      */
@@ -129,6 +131,7 @@ public class EmailTask extends Task {
 
     /**
      * Set whether to send data over SSL.
+     *
      * @param ssl boolean; if true SSL will be used.
      * @since Ant 1.6
      */
@@ -139,6 +142,7 @@ public class EmailTask extends Task {
     /**
      * Set whether to allow authentication to switch to a TLS
      * connection via STARTTLS.
+     *
      * @param b boolean; if true STARTTLS will be supported.
      * @since Ant 1.8.0
      */
@@ -425,6 +429,7 @@ public class EmailTask extends Task {
      * <p>Even with this property set to true the task will still fail
      * if the mail couldn't be sent to any recipient at all.</p>
      *
+     * @param b boolean
      * @since Ant 1.8.0
      */
     public void setIgnoreInvalidRecipients(boolean b) {

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/email/Mailer.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/email/Mailer.java b/src/main/org/apache/tools/ant/taskdefs/email/Mailer.java
index 4aaa982..352ae0b 100644
--- a/src/main/org/apache/tools/ant/taskdefs/email/Mailer.java
+++ b/src/main/org/apache/tools/ant/taskdefs/email/Mailer.java
@@ -74,6 +74,8 @@ public abstract class Mailer {
 
     /**
      * Whether the port has been explicitly specified by the user.
+     *
+     * @param explicit boolean
      * @since Ant 1.8.2
      */
     public void setPortExplicitlySpecified(boolean explicit) {
@@ -82,6 +84,8 @@ public abstract class Mailer {
 
     /**
      * Whether the port has been explicitly specified by the user.
+     *
+     * @return boolean
      * @since Ant 1.8.2
      */
     protected boolean isPortExplicitlySpecified() {
@@ -151,9 +155,9 @@ public abstract class Mailer {
     }
 
     /**
-     * Set the replyto addresses.
+     * Set the replyTo addresses.
      *
-     * @param list a vector of reployTo addresses.
+     * @param list a vector of replyTo addresses.
      * @since Ant 1.6
      */
     public void setReplyToList(Vector<EmailAddress> list) {
@@ -247,6 +251,7 @@ public abstract class Mailer {
      * <p>Even with this property set to true the task will still fail
      * if the mail couldn't be sent to any recipient at all.</p>
      *
+     * @param b boolean
      * @since Ant 1.8.0
      */
     public void setIgnoreInvalidRecipients(boolean b) {
@@ -256,6 +261,7 @@ public abstract class Mailer {
     /**
      * Whether invalid recipients should be ignored.
      *
+     * @return boolean
      * @since Ant 1.8.0
      */
     protected boolean shouldIgnoreInvalidRecipients() {
@@ -267,7 +273,6 @@ public abstract class Mailer {
      * header.
      *
      * @return the current date in SMTP suitable format.
-     *
      * @since Ant 1.5
      */
     protected final String getDate() {

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/launcher/CommandLauncher.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/launcher/CommandLauncher.java b/src/main/org/apache/tools/ant/taskdefs/launcher/CommandLauncher.java
index f39fff0..cc9fb88 100644
--- a/src/main/org/apache/tools/ant/taskdefs/launcher/CommandLauncher.java
+++ b/src/main/org/apache/tools/ant/taskdefs/launcher/CommandLauncher.java
@@ -131,6 +131,9 @@ public class CommandLauncher {
     /**
      * Obtains the shell launcher configured for the given project or
      * the default shell launcher.
+     *
+     * @param project Project
+     * @return CommandLauncher
      */
     public static CommandLauncher getShellLauncher(Project project) {
         CommandLauncher launcher = extractLauncher(ANT_SHELL_LAUNCHER_REF_ID,
@@ -145,6 +148,9 @@ public class CommandLauncher {
     /**
      * Obtains the VM launcher configured for the given project or
      * the default VM launcher.
+     *
+     * @param project Project
+     * @return CommandLauncher
      */
     public static CommandLauncher getVMLauncher(Project project) {
         CommandLauncher launcher = extractLauncher(ANT_VM_LAUNCHER_REF_ID,
@@ -192,6 +198,9 @@ public class CommandLauncher {
 
     /**
      * Sets the VM launcher to use for the given project.
+     *
+     * @param project Project
+     * @param launcher CommandLauncher
      */
     public static void setVMLauncher(Project project,
                                      CommandLauncher launcher) {
@@ -202,6 +211,9 @@ public class CommandLauncher {
 
     /**
      * Sets the shell launcher to use for the given project.
+     *
+     * @param project Project
+     * @param launcher CommandLauncher
      */
     public static void setShellLauncher(Project project,
                                         CommandLauncher launcher) {

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/ANTLR.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ANTLR.java b/src/main/org/apache/tools/ant/taskdefs/optional/ANTLR.java
index 605b336..ba8afd2 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/ANTLR.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/ANTLR.java
@@ -96,7 +96,7 @@ public class ANTLR extends Task {
 
     /**
      * The grammar file to process.
-     * @param target the gramer file
+     * @param target the grammar file
      */
     public void setTarget(File target) {
         log("Setting target to: " + target.toString(), Project.MSG_VERBOSE);

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/EchoProperties.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/EchoProperties.java b/src/main/org/apache/tools/ant/taskdefs/optional/EchoProperties.java
index 30bcc75..141ed17 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/EchoProperties.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/EchoProperties.java
@@ -55,35 +55,38 @@ import org.w3c.dom.Document;
 import org.w3c.dom.Element;
 
 /**
- *  Displays all the current properties in the build. The output can be sent to
- *  a file if desired. <P>
- *
- *  Attribute "destfile" defines a file to send the properties to. This can be
- *  processed as a standard property file later. <P>
- *
- *  Attribute "prefix" defines a prefix which is used to filter the properties
- *  only those properties starting with this prefix will be echoed. <P>
- *
- *  By default, the "failonerror" attribute is enabled. If an error occurs while
- *  writing the properties to a file, and this attribute is enabled, then a
- *  BuildException will be thrown. If disabled, then IO errors will be reported
- *  as a log statement, but no error will be thrown. <P>
- *
- *  Examples: <pre>
+ * Displays all the current properties in the build. The output can be sent to
+ * a file if desired.
+ * <p>
+ * Attribute "destfile" defines a file to send the properties to. This can be
+ * processed as a standard property file later.
+ * </p>
+ * <p>
+ * Attribute "prefix" defines a prefix which is used to filter the properties
+ * only those properties starting with this prefix will be echoed.
+ * </p>
+ * <p>
+ * By default, the "failonerror" attribute is enabled. If an error occurs while
+ * writing the properties to a file, and this attribute is enabled, then a
+ * BuildException will be thrown. If disabled, then IO errors will be reported
+ * as a log statement, but no error will be thrown.
+ * </p>
+ * <p>Examples:</p><pre>
  *  &lt;echoproperties  /&gt;
- * </pre> Report the current properties to the log. <P>
- *
- *  <pre>
+ * </pre>
+ * Report the current properties to the log.
+ * <pre>
  *  &lt;echoproperties destfile="my.properties" /&gt;
- * </pre> Report the current properties to the file "my.properties", and will
- *  fail the build if the file could not be created or written to. <P>
- *
- *  <pre>
+ * </pre>
+ * Report the current properties to the file "my.properties", and will
+ * fail the build if the file could not be created or written to.
+ * <pre>
  *  &lt;echoproperties destfile="my.properties" failonerror="false"
  *      prefix="ant" /&gt;
- * </pre> Report all properties beginning with 'ant' to the file
- *  "my.properties", and will log a message if the file could not be created or
- *  written to, but will still allow the build to continue.
+ * </pre>
+ * Report all properties beginning with 'ant' to the file
+ * "my.properties", and will log a message if the file could not be created or
+ * written to, but will still allow the build to continue.
  *
  *@since      Ant 1.5
  */
@@ -115,15 +118,15 @@ public class EchoProperties extends Task {
     private File inFile = null;
 
     /**
-     *  File object pointing to the output file. If this is null, then
-     *  we output to the project log, not to a file.
+     * File object pointing to the output file. If this is null, then
+     * we output to the project log, not to a file.
      */
     private File destfile = null;
 
     /**
-     *  If this is true, then errors generated during file output will become
-     *  build errors, and if false, then such errors will be logged, but not
-     *  thrown.
+     * If this is true, then errors generated during file output will become
+     * build errors, and if false, then such errors will be logged, but not
+     * thrown.
      */
     private boolean failonerror = true;
 
@@ -151,7 +154,7 @@ public class EchoProperties extends Task {
      *  Set a file to store the property output.  If this is never specified,
      *  then the output will be sent to the Ant log.
      *
-     *@param destfile file to store the property output
+     * @param destfile file to store the property output
      */
     public void setDestfile(File destfile) {
         this.destfile = destfile;
@@ -162,7 +165,7 @@ public class EchoProperties extends Task {
      * If true, the task will fail if an error occurs writing the properties
      * file, otherwise errors are just logged.
      *
-     *@param  failonerror  <tt>true</tt> if IO exceptions are reported as build
+     * @param failonerror  <tt>true</tt> if IO exceptions are reported as build
      *      exceptions, or <tt>false</tt> if IO exceptions are ignored.
      */
     public void setFailOnError(boolean failonerror) {
@@ -171,15 +174,15 @@ public class EchoProperties extends Task {
 
 
     /**
-     *  If the prefix is set, then only properties which start with this
-     *  prefix string will be recorded. If regex is not set and  if this
-     *  is never set, or it is set to an empty string or <tt>null</tt>,
-     *  then all properties will be recorded. <P>
+     * If the prefix is set, then only properties which start with this
+     * prefix string will be recorded. If regex is not set and  if this
+     * is never set, or it is set to an empty string or <tt>null</tt>,
+     * then all properties will be recorded.
      *
-     *  For example, if the attribute is set as:
-     *    <PRE>&lt;echoproperties  prefix="ant." /&gt;</PRE>
-     *  then the property "ant.home" will be recorded, but "ant-example"
-     *  will not.
+     * <p>For example, if the attribute is set as:</p>
+     * <pre>&lt;echoproperties  prefix="ant." /&gt;</pre>
+     * then the property "ant.home" will be recorded, but "ant-example"
+     * will not.
      *
      * @param  prefix  The new prefix value
      */
@@ -194,15 +197,15 @@ public class EchoProperties extends Task {
     }
 
     /**
-     *  If the regex is set, then only properties whose names match it
-     *  will be recorded.  If prefix is not set and if this is never set,
-     *  or it is set to an empty string or <tt>null</tt>, then all
-     *  properties will be recorded.<P>
+     * If the regex is set, then only properties whose names match it
+     * will be recorded.  If prefix is not set and if this is never set,
+     * or it is set to an empty string or <tt>null</tt>, then all
+     * properties will be recorded.
      *
-     *  For example, if the attribute is set as:
-     *    <PRE>&lt;echoproperties  prefix=".*ant.*" /&gt;</PRE>
-     *  then the properties "ant.home" and "user.variant" will be recorded,
-     *  but "ant-example" will not.
+     * <p>For example, if the attribute is set as:</p>
+     * <pre>&lt;echoproperties  prefix=".*ant.*" /&gt;</pre>
+     * then the properties "ant.home" and "user.variant" will be recorded,
+     * but "ant-example" will not.
      *
      * @param  regex  The new regex value
      *
@@ -252,9 +255,9 @@ public class EchoProperties extends Task {
     }
 
     /**
-     *  Run the task.
+     * Run the task.
      *
-     *@exception  BuildException  trouble, probably file IO
+     * @exception BuildException  trouble, probably file IO
      */
     public void execute() throws BuildException {
         if (prefix != null && regex != null) {
@@ -368,10 +371,10 @@ public class EchoProperties extends Task {
 
 
     /**
-     *  Send the key/value pairs in the hashtable to the given output stream.
-     *  Only those properties matching the <tt>prefix</tt> constraint will be
-     *  sent to the output stream.
-     *  The output stream will be closed when this method returns.
+     * Send the key/value pairs in the hashtable to the given output stream.
+     * Only those properties matching the <tt>prefix</tt> constraint will be
+     * sent to the output stream.
+     * The output stream will be closed when this method returns.
      *
      * @param  allProps         propfile to save
      * @param  os               output stream
@@ -461,7 +464,7 @@ public class EchoProperties extends Task {
     }
 
     private List sortProperties(Properties props) {
-        //sort the list. Makes SCM and manual diffs easier.
+        // sort the list. Makes SCM and manual diffs easier.
         List sorted = new ArrayList(props.size());
         Enumeration e = props.propertyNames();
         while (e.hasMoreElements()) {
@@ -511,14 +514,14 @@ public class EchoProperties extends Task {
     }
 
     /**
-     *  JDK 1.2 allows for the safer method
-     *  <tt>Properties.store(OutputStream, String)</tt>, which throws an
-     *  <tt>IOException</tt> on an output error.
+     * JDK 1.2 allows for the safer method
+     * <tt>Properties.store(OutputStream, String)</tt>, which throws an
+     * <tt>IOException</tt> on an output error.
      *
-     *@param props the properties to record
-     *@param os record the properties to this output stream
-     *@param header prepend this header to the property output
-     *@exception IOException on an I/O error during a write.
+     * @param props the properties to record
+     * @param os record the properties to this output stream
+     * @param header prepend this header to the property output
+     * @exception IOException on an I/O error during a write.
      */
     protected void jdkSaveProperties(Properties props, OutputStream os,
                                      String header) throws IOException {
@@ -542,7 +545,7 @@ public class EchoProperties extends Task {
     /**
      * Uses the DocumentBuilderFactory to get a DocumentBuilder instance.
      *
-     * @return   The DocumentBuilder instance
+     * @return The DocumentBuilder instance
      */
     private static DocumentBuilder getDocumentBuilder() {
         try {

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/Javah.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/Javah.java b/src/main/org/apache/tools/ant/taskdefs/optional/Javah.java
index 06e1d11..bf2d679 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/Javah.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/Javah.java
@@ -411,6 +411,7 @@ public class Javah extends Task {
      * The classpath to use when loading the javah implementation
      * if it is not a built-in one.
      *
+     * @return Path
      * @since Ant 1.8.0
      */
     public Path createImplementationClasspath() {
@@ -419,6 +420,8 @@ public class Javah extends Task {
 
     /**
      * Set the adapter explicitly.
+     *
+     * @param adapter JavahAdapter
      * @since Ant 1.8.0
      */
     public void add(JavahAdapter adapter) {

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/Native2Ascii.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/Native2Ascii.java b/src/main/org/apache/tools/ant/taskdefs/optional/Native2Ascii.java
index 81a386f..2221e39 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/Native2Ascii.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/Native2Ascii.java
@@ -69,6 +69,7 @@ public class Native2Ascii extends MatchingTask {
 
     /**
      * The value of the reverse attribute.
+     *
      * @return the reverse attribute.
      * @since Ant 1.6.3
      */
@@ -89,6 +90,7 @@ public class Native2Ascii extends MatchingTask {
 
     /**
      * The value of the encoding attribute.
+     *
      * @return the encoding attribute.
      * @since Ant 1.6.3
      */
@@ -127,6 +129,7 @@ public class Native2Ascii extends MatchingTask {
 
     /**
      * Choose the implementation for this particular task.
+     *
      * @param impl the name of the implementation
      * @since Ant 1.6.3
      */
@@ -142,7 +145,6 @@ public class Native2Ascii extends MatchingTask {
      * Defines the FileNameMapper to use (nested mapper element).
      *
      * @return the mapper to use for file name translations.
-     *
      * @throws BuildException if more than one mapper is defined.
      */
     public Mapper createMapper() throws BuildException {
@@ -156,6 +158,7 @@ public class Native2Ascii extends MatchingTask {
 
     /**
      * A nested filenamemapper
+     *
      * @param fileNameMapper the mapper to add
      * @since Ant 1.6.3
      */
@@ -165,8 +168,8 @@ public class Native2Ascii extends MatchingTask {
 
     /**
      * Adds an implementation specific command-line argument.
-     * @return a ImplementationSpecificArgument to be configured
      *
+     * @return a ImplementationSpecificArgument to be configured
      * @since Ant 1.6.3
      */
     public ImplementationSpecificArgument createArg() {
@@ -180,6 +183,7 @@ public class Native2Ascii extends MatchingTask {
      * The classpath to use when loading the native2ascii
      * implementation if it is not a built-in one.
      *
+     * @return Path
      * @since Ant 1.8.0
      */
     public Path createImplementationClasspath() {
@@ -188,6 +192,8 @@ public class Native2Ascii extends MatchingTask {
 
     /**
      * Set the adapter explicitly.
+     *
+     * @param adapter Native2AsciiAdapter
      * @since Ant 1.8.0
      */
     public void add(Native2AsciiAdapter adapter) {

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/NetRexxC.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/NetRexxC.java b/src/main/org/apache/tools/ant/taskdefs/optional/NetRexxC.java
index dff24bc..3f85ed7 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/NetRexxC.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/NetRexxC.java
@@ -81,16 +81,15 @@ import org.apache.tools.ant.util.FileUtils;
  *
  * <p>When this task executes, it will recursively scan the srcdir
  * looking for NetRexx source files to compile. This task makes its
- * compile decision based on timestamp.
+ * compile decision based on timestamp.</p>
  * <p>Before files are compiled they and any other file in the
  * srcdir will be copied to the destdir allowing support files to be
  * located properly in the classpath. The reason for copying the source files
- * before the compile is that NetRexxC has only two destinations for classfiles:
+ * before the compile is that NetRexxC has only two destinations for classfiles:</p>
  * <ol>
  * <li>The current directory, and,</li>
  * <li>The directory the source is in (see sourcedir option)
  * </ol>
- *
  */
 public class NetRexxC extends MatchingTask {
 
@@ -565,7 +564,8 @@ public class NetRexxC extends MatchingTask {
     /**
      * Tells whether the trailing .keep in nocompile-mode should be removed
      * so that the resulting java source really ends on .java.
-     * This facilitates the use of the javadoc tool lateron.
+     * This facilitates the use of the javadoc tool later on.
+     * @param removeKeepExtension boolean
      */
     public void setRemoveKeepExtension(boolean removeKeepExtension) {
         this.removeKeepExtension = removeKeepExtension;

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/PropertyFile.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/PropertyFile.java b/src/main/org/apache/tools/ant/taskdefs/optional/PropertyFile.java
index 02106a9..f9f317c 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/PropertyFile.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/PropertyFile.java
@@ -56,16 +56,17 @@ import org.apache.tools.ant.util.LayoutPreservingProperties;
  *        &lt;entry key="product.version.major" type="int"  value="5"/&gt;
  *        &lt;entry key="product.version.minor" type="int"  value="0"/&gt;
  *        &lt;entry key="product.build.major"   type="int"  value="0" /&gt;
- *        &lt;entry key="product.build.minor"   type="int"  operation="+" /&gt;
- *        &lt;entry key="product.build.date"    type="date" value="now" /&gt;
+ *        &lt;entry key="product.build.minor"   type="int"  operation="+"/&gt;
+ *        &lt;entry key="product.build.date"    type="date" value="now"/&gt;
  *        &lt;entry key="intSet" type="int" operation="=" value="681"/&gt;
  *        &lt;entry key="intDec" type="int" operation="-"/&gt;
  *        &lt;entry key="StringEquals" type="string" value="testValue"/&gt;
  *     &lt;/propertyfile&gt;
  *   &lt;/target&gt;
  * </pre>
- *
+ * <p>
  * The &lt;propertyfile&gt; task must have:
+ * </p>
  * <ul>
  *   <li>file</li>
  * </ul>
@@ -77,8 +78,9 @@ import org.apache.tools.ant.util.LayoutPreservingProperties;
  *   <li>type</li>
  *   <li>value (the final four being eliminated shortly)</li>
  * </ul>
- *
+ * <p>
  * The &lt;entry&gt; task must have:
+ * </p>
  * <ul>
  *   <li>key</li>
  * </ul>
@@ -90,24 +92,29 @@ import org.apache.tools.ant.util.LayoutPreservingProperties;
  *   <li>default</li>
  *   <li>unit</li>
  * </ul>
- *
+ * <p>
  * If type is unspecified, it defaults to string.
- *
+ * </p>
  * Parameter values:
- * <ul>
- *   <li>operation:</li>
+ * <dl>
+ *   <dt>operation:</dt>
+ *   <dd>
  *   <ul>
  *     <li>"=" (set -- default)</li>
  *     <li>"-" (dec)</li>
  *     <li>"+" (inc)</li>
  *   </ul>
- *   <li>type:</li>
+ *   </dd>
+ *   <dt>type:</dt>
+ *   <dd>
  *   <ul>
  *     <li>"int"</li>
  *     <li>"date"</li>
  *     <li>"string"</li>
  *   </ul>
- *   <li>value:</li>
+ *   </dd>
+ *   <dt>value:</dt>
+ *   <dd>
  *   <ul>
  *     <li>holds the default value, if the property
  *              was not found in property file</li>
@@ -116,7 +123,8 @@ import org.apache.tools.ant.util.LayoutPreservingProperties;
  *              date/time and used even if a valid date was
  *              found in the property file.</li>
  *   </ul>
- * </ul>
+ *   </dd>
+ * </dl>
  *
  * <p>String property types can only use the "=" operation.
  * Int property types can only use the "=", "-" or "+" operations.<p>
@@ -246,6 +254,7 @@ public class PropertyFile extends Task {
     /**
      * optional flag to use original Java properties (as opposed to
      * layout preserving properties)
+     * @param val boolean
      */
     public void setJDKProperties(boolean val) {
         useJDKProperties = val;

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/ReplaceRegExp.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ReplaceRegExp.java b/src/main/org/apache/tools/ant/taskdefs/optional/ReplaceRegExp.java
index d088096..cf07885 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/ReplaceRegExp.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/ReplaceRegExp.java
@@ -148,6 +148,7 @@ public class ReplaceRegExp extends Task {
     /**
      * file for which the regular expression should be replaced;
      * required unless a nested fileset is supplied.
+     *
      * @param file The file for which the reg exp should be replaced.
      */
     public void setFile(File file) {
@@ -158,6 +159,7 @@ public class ReplaceRegExp extends Task {
     /**
      * the regular expression pattern to match in the file(s);
      * required if no nested &lt;regexp&gt; is used
+     *
      * @param match the match attribute.
      */
     public void setMatch(String match) {
@@ -174,6 +176,7 @@ public class ReplaceRegExp extends Task {
      * The substitution pattern to place in the file(s) in place
      * of the regular expression.
      * Required if no nested &lt;substitution&gt; is used
+     *
      * @param replace the replace attribute
      */
 
@@ -191,15 +194,16 @@ public class ReplaceRegExp extends Task {
      * The flags to use when matching the regular expression.  For more
      * information, consult the Perl5 syntax.
      * <ul>
-     *  <li>g : Global replacement.  Replace all occurrences found
-     *  <li>i : Case Insensitive.  Do not consider case in the match
+     *  <li>g : Global replacement.  Replace all occurrences found</li>
+     *  <li>i : Case Insensitive.  Do not consider case in the match</li>
      *  <li>m : Multiline.  Treat the string as multiple lines of input,
      *         using "^" and "$" as the start or end of any line, respectively,
-     *         rather than start or end of string.
-     *  <li> s : Singleline.  Treat the string as a single line of input, using
+     *         rather than start or end of string.</li>
+     *  <li>s : Singleline.  Treat the string as a single line of input, using
      *        "." to match any character, including a newline, which normally,
-     *        it would not match.
-     *</ul>
+     *        it would not match.</li>
+     * </ul>
+     *
      * @param flags the flags attribute
      */
     public void setFlags(String flags) {
@@ -244,8 +248,8 @@ public class ReplaceRegExp extends Task {
     /**
      * Specifies the encoding Ant expects the files to be in -
      * defaults to the platforms default encoding.
-     * @param encoding the encoding attribute
      *
+     * @param encoding the encoding attribute
      * @since Ant 1.6
      */
     public void setEncoding(String encoding) {
@@ -254,6 +258,7 @@ public class ReplaceRegExp extends Task {
 
     /**
      * list files to apply the replacement to
+     *
      * @param set the fileset element
      */
     public void addFileset(FileSet set) {
@@ -263,6 +268,7 @@ public class ReplaceRegExp extends Task {
     /**
      * Support arbitrary file system based resource collections.
      *
+     * @param rc ResourceCollection
      * @since Ant 1.8.0
      */
     public void addConfigured(ResourceCollection rc) {
@@ -294,6 +300,7 @@ public class ReplaceRegExp extends Task {
     /**
      * A substitution pattern.  You can use this element to refer to a previously
      * defined substitution pattern datatype instance.
+     *
      * @return the substitution pattern object to be configured as an element
      */
     public Substitution createSubstitution() {
@@ -310,6 +317,7 @@ public class ReplaceRegExp extends Task {
      * Whether the file timestamp shall be preserved even if the file
      * is modified.
      *
+     * @param b boolean
      * @since Ant 1.8.0
      */
     public void setPreserveLastModified(boolean b) {
@@ -344,7 +352,7 @@ public class ReplaceRegExp extends Task {
 
 
     /**
-     *  Perform the replacement on a file
+     * Perform the replacement on a file
      *
      * @param f the file to perform the replacement on
      * @param options the regular expressions options

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/Rpm.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/Rpm.java b/src/main/org/apache/tools/ant/taskdefs/optional/Rpm.java
index 765841d..d58238b 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/Rpm.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/Rpm.java
@@ -203,7 +203,7 @@ public class Rpm extends Task {
 
     /**
      * The directory which will have the expected
-     * subdirectories, SPECS, SOURCES, BUILD, SRPMS ; optional.
+     * subdirectories, SPECS, SOURCES, BUILD, SRPMS; optional.
      * If this isn't specified,
      * the <tt>baseDir</tt> value is used
      *

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/SchemaValidate.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/SchemaValidate.java b/src/main/org/apache/tools/ant/taskdefs/optional/SchemaValidate.java
index e57d6d2..30801de 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/SchemaValidate.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/SchemaValidate.java
@@ -224,7 +224,7 @@ public class SchemaValidate extends XMLValidateTask {
         //setFeature(XmlConstants.FEATURE_VALIDATION, false);
         setFeature(XmlConstants.FEATURE_NAMESPACES, true);
         if (!enableXercesSchemaValidation() && !enableJAXP12SchemaValidation()) {
-            //couldnt use the xerces or jaxp calls
+            //could not use xerces or jaxp calls
             throw new BuildException(ERROR_NO_XSD_SUPPORT);
         }
 
@@ -306,7 +306,7 @@ public class SchemaValidate extends XMLValidateTask {
         try {
             getXmlReader().setFeature(feature, value);
         } catch (SAXNotRecognizedException e) {
-            log("Not recognizied: " + feature, Project.MSG_VERBOSE);
+            log("Not recognized: " + feature, Project.MSG_VERBOSE);
         } catch (SAXNotSupportedException e) {
             log("Not supported: " + feature, Project.MSG_VERBOSE);
         }

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/Script.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/Script.java b/src/main/org/apache/tools/ant/taskdefs/optional/Script.java
index 2b8d9f6..a29347f 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/Script.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/Script.java
@@ -72,7 +72,7 @@ public class Script extends Task {
     }
 
     /**
-     * Load the script from an external file ; optional.
+     * Load the script from an external file; optional.
      *
      * @param fileName the name of the file containing the script source.
      */

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java b/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java
index 605aba9..569f5ed 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java
@@ -317,7 +317,6 @@ public class TraXLiaison implements XSLTLiaison4, ErrorListener, XSLTLoggerAware
 
     /**
      * Create a new transformer based on the liaison settings
-     * @throws Exception thrown if there is an error during creation.
      * @see #setStylesheet(java.io.File)
      * @see #addParam(java.lang.String, java.lang.String)
      * @see #setOutputProperty(java.lang.String, java.lang.String)

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.java b/src/main/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.java
index 05c043d..7b9d3bb 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.java
@@ -145,10 +145,10 @@ public class XMLValidateTask extends Task {
      * Specify the class name of the SAX parser to be used. (optional)
      * @param className should be an implementation of SAX2
      * <code>org.xml.sax.XMLReader</code> or SAX2 <code>org.xml.sax.Parser</code>.
-     * <p> if className is an implementation of
+     * <p>If className is an implementation of
      * <code>org.xml.sax.Parser</code>, {@link #setLenient(boolean)},
-     * will be ignored.
-     * <p> if not set, the default will be used.
+     * will be ignored.</p>
+     * <p>If not set, the default will be used.</p>
      * @see org.xml.sax.XMLReader
      * @see org.xml.sax.Parser
      */

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMCreateTask.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMCreateTask.java b/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMCreateTask.java
index 350d673..7777718 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMCreateTask.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMCreateTask.java
@@ -109,22 +109,22 @@ public class CCMCreateTask extends Continuus implements ExecuteStreamHandler {
         if (getPlatform() != null) {
             cmd.createArgument().setValue(FLAG_PLATFORM);
             cmd.createArgument().setValue(getPlatform());
-        } // end of if ()
+        }
 
         if (getResolver() != null) {
             cmd.createArgument().setValue(FLAG_RESOLVER);
             cmd.createArgument().setValue(getResolver());
-        } // end of if ()
+        }
 
         if (getSubSystem() != null) {
             cmd.createArgument().setValue(FLAG_SUBSYSTEM);
             cmd.createArgument().setValue("\"" + getSubSystem() + "\"");
-        } // end of if ()
+        }
 
         if (getRelease() != null) {
             cmd.createArgument().setValue(FLAG_RELEASE);
             cmd.createArgument().setValue(getRelease());
-        } // end of if ()
+        }
     }
 
 
@@ -319,15 +319,15 @@ public class CCMCreateTask extends Continuus implements ExecuteStreamHandler {
                 taskstring = taskstring.substring(0, taskstring.lastIndexOf(' ')).trim();
                 setTask(taskstring);
                 log("task is " + getTask(), Project.MSG_DEBUG);
-            } // end of if ()
+            }
         } catch (NullPointerException npe) {
-            log("error procession stream , null pointer exception", Project.MSG_ERR);
+            log("error procession stream, null pointer exception", Project.MSG_ERR);
             log(StringUtils.getStackTrace(npe), Project.MSG_ERR);
             throw new BuildException(npe.getClass().getName());
         } catch (Exception e) {
             log("error procession stream " + e.getMessage(), Project.MSG_ERR);
             throw new BuildException(e.getMessage());
-        } // end of try-catch
+        }
 
     }
 

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMReconfigure.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMReconfigure.java b/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMReconfigure.java
index 28f8064..35a0834 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMReconfigure.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMReconfigure.java
@@ -74,11 +74,11 @@ public class CCMReconfigure extends Continuus {
 
         if (isRecurse()) {
             cmd.createArgument().setValue(FLAG_RECURSE);
-        } // end of if ()
+        }
 
         if (isVerbose()) {
             cmd.createArgument().setValue(FLAG_VERBOSE);
-        } // end of if ()
+        }
 
         if (getCcmProject() != null) {
             cmd.createArgument().setValue(FLAG_PROJECT);

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCCheckin.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCCheckin.java b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCCheckin.java
index 371d418..f7c4a5f 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCCheckin.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCCheckin.java
@@ -29,6 +29,7 @@ import org.apache.tools.ant.types.Commandline;
  * <p>
  * The following attributes are interpreted:
  * <table border="1">
+ *   <caption>Task attributes</caption>
  *   <tr>
  *     <th>Attribute</th>
  *     <th>Values</th>

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCCheckout.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCCheckout.java b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCCheckout.java
index 0eaf09a..e60bfc9 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCCheckout.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCCheckout.java
@@ -30,6 +30,7 @@ import org.apache.tools.ant.types.Commandline;
  * <p>
  * The following attributes are interpreted:
  * <table border="1">
+ *   <caption>Task attributes</caption>
  *   <tr>
  *     <th>Attribute</th>
  *     <th>Values</th>

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCLock.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCLock.java b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCLock.java
index c273554..ba7def7 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCLock.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCLock.java
@@ -37,6 +37,7 @@ import org.apache.tools.ant.types.Commandline;
  * <p>
  * The following attributes are interpreted:
  * <table border="1">
+ *   <caption>Task attributes</caption>
  *   <tr>
  *     <th>Attribute</th>
  *     <th>Values</th>

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMkattr.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMkattr.java b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMkattr.java
index 128ea16..89b55f9 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMkattr.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMkattr.java
@@ -29,6 +29,7 @@ import org.apache.tools.ant.types.Commandline;
  * <p>
  * The following attributes are interpreted:
  * <table border="1">
+ *   <caption>Task attributes</caption>
  *   <tr>
  *     <th>Attribute</th>
  *     <th>Values</th>

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMkbl.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMkbl.java b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMkbl.java
index 82c9600..ac0f42b 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMkbl.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMkbl.java
@@ -28,6 +28,7 @@ import org.apache.tools.ant.types.Commandline;
  * <p>
  * The following attributes are interpreted:
  * <table border="1">
+ *   <caption>Task attributes</caption>
  *   <tr>
  *     <th>Attribute</th>
  *     <th>Values</th>

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMkdir.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMkdir.java b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMkdir.java
index 4c89539..441ff52 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMkdir.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMkdir.java
@@ -29,6 +29,7 @@ import org.apache.tools.ant.types.Commandline;
  * <p>
  * The following attributes are interpreted:
  * <table border="1">
+ *   <caption>Task attributes</caption>
  *   <tr>
  *     <th>Attribute</th>
  *     <th>Values</th>

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMkelem.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMkelem.java b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMkelem.java
index 94faa5a..53d2f0b 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMkelem.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMkelem.java
@@ -29,6 +29,7 @@ import org.apache.tools.ant.types.Commandline;
  * <p>
  * The following attributes are interpreted:
  * <table border="1">
+ *   <caption>Task attributes</caption>
  *   <tr>
  *     <th>Attribute</th>
  *     <th>Values</th>

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMklabel.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMklabel.java b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMklabel.java
index e3d288d..b1a9686 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMklabel.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMklabel.java
@@ -28,6 +28,7 @@ import org.apache.tools.ant.types.Commandline;
  * <p>
  * The following attributes are interpreted:
  * <table border="1">
+ *   <caption>Task attributes</caption>
  *   <tr>
  *     <th>Attribute</th>
  *     <th>Values</th>

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMklbtype.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMklbtype.java b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMklbtype.java
index 7bb7192..04db9cd 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMklbtype.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCMklbtype.java
@@ -28,6 +28,7 @@ import org.apache.tools.ant.types.Commandline;
  * <p>
  * The following attributes are interpreted:
  * <table border="1">
+ *   <caption>Task attributes</caption>
  *   <tr>
  *     <th>Attribute</th>
  *     <th>Values</th>

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCRmtype.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCRmtype.java b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCRmtype.java
index cef0c3a..82a9e63 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCRmtype.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCRmtype.java
@@ -28,6 +28,7 @@ import org.apache.tools.ant.types.Commandline;
  * <p>
  * The following attributes are interpreted:
  * <table border="1">
+ *   <caption>Task attributes</caption>
  *   <tr>
  *     <th>Attribute</th>
  *     <th>Values</th>
@@ -41,7 +42,7 @@ import org.apache.tools.ant.types.Commandline;
  *              eltype                         element type<br>
  *              hltype                         hyperlink type<br>
  *              lbtype                         label type<br>
- *              trtype                         trigger type<br>
+ *              trtype                         trigger type
  *      </td>
  *      <td>Yes</td>
  *   <tr>

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCUnCheckout.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCUnCheckout.java b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCUnCheckout.java
index 3c00e1a..6d7e488 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCUnCheckout.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCUnCheckout.java
@@ -29,6 +29,7 @@ import org.apache.tools.ant.types.Commandline;
  * <p>
  * The following attributes are interpreted:
  * <table border="1">
+ *   <caption>Task attributes</caption>
  *   <tr>
  *     <th>Attribute</th>
  *     <th>Values</th>

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCUnlock.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCUnlock.java b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCUnlock.java
index 4ca3e89..7d72726 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCUnlock.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCUnlock.java
@@ -34,6 +34,7 @@ import org.apache.tools.ant.types.Commandline;
  * <p>
  * The following attributes are interpreted:
  * <table border="1">
+ *   <caption>Task attributes</caption>
  *   <tr>
  *     <th>Attribute</th>
  *     <th>Values</th>

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCUpdate.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCUpdate.java b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCUpdate.java
index 712efdc..a8ee850 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCUpdate.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/CCUpdate.java
@@ -29,6 +29,7 @@ import org.apache.tools.ant.types.Commandline;
  * <p>
  * The following attributes are interpreted:
  * <table border="1">
+ *   <caption>Task attributes</caption>
  *   <tr>
  *     <th>Attribute</th>
  *     <th>Values</th>

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java b/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java
index 2cf335c..7b51133 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java
@@ -553,7 +553,7 @@ public class Depend extends MatchingTask {
      * warn when a class is out of date, but not deleted as its source is unknown.
      * MSG_WARN is the normal level, but we downgrade to MSG_VERBOSE for RMI files
      * if {@link #warnOnRmiStubs is false}
-     * @param affectedClassInfo info about the affectd class
+     * @param affectedClassInfo info about the affected class
      * @param affectedClass the name of the affected .class file
      * @param className the file that is triggering the out of dateness
      */

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/MethodHandleCPInfo.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/MethodHandleCPInfo.java b/src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/MethodHandleCPInfo.java
index e11e3aa..a5906c7 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/MethodHandleCPInfo.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/MethodHandleCPInfo.java
@@ -29,7 +29,7 @@ public class MethodHandleCPInfo extends ConstantPoolEntry {
 
     /** reference kind **/
     private ReferenceKind referenceKind;
-    /** Must be a valid index into the constant pool tabel. */
+    /** Must be a valid index into the constant pool table. */
     private int referenceIndex;
     /**
      * the index into the constant pool which defined the name and type

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/ejb/DescriptorHandler.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/DescriptorHandler.java b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/DescriptorHandler.java
index 158cba9..ac2aa72 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/DescriptorHandler.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/DescriptorHandler.java
@@ -175,7 +175,7 @@ public class DescriptorHandler extends org.xml.sax.HandlerBase {
 
     /**
      * Resolve the entity.
-     * @see org.xml.sax.EntityResolver#resolveEntity(String, String).
+     * @see org.xml.sax.EntityResolver#resolveEntity(String, String)
      * @param publicId The public identifier, or <code>null</code>
      *                 if none is available.
      * @param systemId The system identifier provided in the XML

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/ejb/EjbJar.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/EjbJar.java b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/EjbJar.java
index 6e7166b..0728b75 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/EjbJar.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/EjbJar.java
@@ -196,7 +196,7 @@ public class EjbJar extends MatchingTask {
      * Stores a handle to the directory to put the Jar files in. This is
      * only used by the generic deployment descriptor tool which is created
      * if no other deployment descriptor tools are provided. Normally each
-     * deployment tool will specify the desitination dir itself.
+     * deployment tool will specify the destination dir itself.
      */
     private File destDir;
 
@@ -481,11 +481,11 @@ public class EjbJar extends MatchingTask {
 
     /**
      * Sets the CMP version.
+     * Must be either <code>1.0</code> or <code>2.0</code>.
+     * Default is <code>1.0</code>.
+     * Initially, only the JBoss implementation does something specific for CMP 2.0.
      *
      * @param version CMP version.
-     * Must be either <code>1.0</code> or <code>2.0</code>.<br/>
-     * Default is <code>1.0</code>.<br/>
-     * Initially, only the JBoss implementation does something specific for CMP 2.0.<br/>
      * @since ant 1.6
      */
     public void setCmpversion(CMPVersion version) {

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/ejb/GenericDeploymentTool.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/GenericDeploymentTool.java b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/GenericDeploymentTool.java
index 43b9237..964a455 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/GenericDeploymentTool.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/GenericDeploymentTool.java
@@ -395,7 +395,7 @@ public class GenericDeploymentTool implements EJBDeploymentTool {
         try {
             handler = getDescriptorHandler(config.srcDir);
 
-            // Retrive the files to be added to JAR from EJB descriptor
+            // Retreive the files to be added to JAR from EJB descriptor
             Hashtable ejbFiles = parseEjbFiles(descriptorFileName, saxParser);
 
             // Add any support classes specified in the build file
@@ -649,7 +649,7 @@ public class GenericDeploymentTool implements EJBDeploymentTool {
     /**
      * Add any vendor specific files which should be included in the
      * EJB Jar.
-     * @param ejbFiles a hashtable entryname -> file.
+     * @param ejbFiles a hashtable entryname -&gt; file.
      * @param ddPrefix a prefix to use.
      */
     protected void addVendorFiles(Hashtable ejbFiles, String ddPrefix) {
@@ -660,7 +660,9 @@ public class GenericDeploymentTool implements EJBDeploymentTool {
     /**
      * Get the vendor specific name of the Jar that will be output. The modification date
      * of this jar will be checked against the dependent bean classes.
+     *
      * @param baseName the basename to use.
+     * @return File
      */
     File getVendorOutputJarFile(String baseName) {
         return new File(destDir, baseName + genericJarSuffix);

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/ejb/IPlanetDeploymentTool.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/IPlanetDeploymentTool.java b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/IPlanetDeploymentTool.java
index cbc8526..790cad6 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/IPlanetDeploymentTool.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/IPlanetDeploymentTool.java
@@ -35,9 +35,8 @@ import org.xml.sax.SAXException;
  * <code>ejbjar</code> task.  If only stubs and skeletons need to be generated
  * (in other words, if no JAR file needs to be created), refer to the
  * <code>iplanet-ejbc</code> task and the <code>IPlanetEjbcTask</code> class.
- * <p>
- * The following attributes may be specified by the user:
- *   <ul>
+ * <p>The following attributes may be specified by the user:</p>
+ * <ul>
  *     <li><i>destdir</i> -- The base directory into which the generated JAR
  *                           files will be written.  Each JAR file is written
  *                           in directories which correspond to their location
@@ -72,15 +71,14 @@ import org.xml.sax.SAXException;
  *     <li><i>suffix</i> -- String value appended to the JAR filename when
  *                          creating each JAR.  This attribute is not required
  *                          (if omitted, it defaults to ".jar").
- *   </ul>
- * <p>
- * For each EJB descriptor found in the "ejbjar" parent task, this deployment
+ * </ul>
+ * <p>For each EJB descriptor found in the "ejbjar" parent task, this deployment
  * tool will locate the three classes that comprise the EJB.  If these class
  * files cannot be located in the specified <code>srcdir</code> directory, the
  * task will fail.  The task will also attempt to locate the EJB stubs and
  * skeletons in this directory.  If found, the timestamps on the stubs and
  * skeletons will be checked to ensure they are up to date.  Only if these files
- * cannot be found or if they are out of date will ejbc be called.
+ * cannot be found or if they are out of date will ejbc be called.</p>
  *
  * @see    IPlanetEjbc
  */

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/ejb/IPlanetEjbc.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/IPlanetEjbc.java b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/IPlanetEjbc.java
index 76b61ae..447a288 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/IPlanetEjbc.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/IPlanetEjbc.java
@@ -54,16 +54,14 @@ import org.apache.tools.ant.util.StringUtils;
  * and skeletons in the specified destination directory.  Only if the stubs and
  * skeletons cannot be found or if they're out of date will the iPlanet
  * Application Server ejbc utility be run.
- * <p>
- * Because this class (and it's assorted inner classes) may be bundled into the
+ * <p>Because this class (and it's assorted inner classes) may be bundled into the
  * iPlanet Application Server distribution at some point (and removed from the
  * Ant distribution), the class has been written to be independent of all
  * Ant-specific classes.  It is also for this reason (and to avoid cluttering
  * the Apache Ant source files) that this utility has been packaged into a
- * single source file.
- * <p>
- * For more information on Ant Tasks for iPlanet Application Server, see the
- * <code>IPlanetDeploymentTool</code> and <code>IPlanetEjbcTask</code> classes.
+ * single source file.</p>
+ * <p>For more information on Ant Tasks for iPlanet Application Server, see the
+ * <code>IPlanetDeploymentTool</code> and <code>IPlanetEjbcTask</code> classes.</p>
  *
  * @see    IPlanetDeploymentTool
  * @see    IPlanetEjbcTask
@@ -327,15 +325,12 @@ public class IPlanetEjbc {
         } catch (IOException e) {
             System.out.println("An IOException has occurred while reading the "
                     + "XML descriptors (" + e.getMessage() + ").");
-            return;
         } catch (SAXException e) {
             System.out.println("A SAXException has occurred while reading the "
                     + "XML descriptors (" + e.getMessage() + ").");
-            return;
         } catch (IPlanetEjbc.EjbcException e) {
             System.out.println("An error has occurred while executing the ejbc "
                     + "utility (" + e.getMessage() + ").");
-            return;
         }
     }
 
@@ -417,7 +412,7 @@ public class IPlanetEjbc {
             args.append(arguments[i]).append(" ");
         }
 
-        /* If an iAS home directory is specified, prepend it to the commmand */
+        /* If an iAS home directory is specified, prepend it to the command */
         String command;
         if (iasHomeDir == null) {
             command = "";
@@ -1129,12 +1124,9 @@ public class IPlanetEjbc {
          * implementation) and returns the modification timestamp for the
          * "oldest" class.
          *
-         * @param classpath The classpath to be used to find the source EJB
-         *                  classes.  If <code>null</code>, the system classpath
-         *                  is used.
+         * @param buildDir  The directory to be used to find the source EJB
+         *                  classes.
          * @return The modification timestamp for the "oldest" EJB source class.
-         * @throws BuildException If one of the EJB source classes cannot be
-         *                        found on the classpath.
          */
         private long sourceClassesModified(File buildDir) {
             long latestModified; // The timestamp of the "newest" class
@@ -1223,16 +1215,14 @@ public class IPlanetEjbc {
         /**
          * Examines each of the EJB stubs and skeletons in the destination
          * directory and returns the modification timestamp for the "oldest"
-         * class. If one of the stubs or skeletons cannot be found, <code>-1
-         * </code> is returned.
+         * class. If one of the stubs or skeletons cannot be found,
+         * <code>-1</code> is returned.
          *
-         * @param dest The directory in which the EJB stubs and skeletons are
+         * @param destDir The directory in which the EJB stubs and skeletons are
          *             stored.
          * @return The modification timestamp for the "oldest" EJB stub or
-         *         skeleton.  If one of the classes cannot be found, <code>-1
-         *         </code> is returned.
-         * @throws BuildException If the canonical path of the destination
-         *                        directory cannot be found.
+         *         skeleton.  If one of the classes cannot be found,
+         *         <code>-1</code> is returned.
          */
         private long destClassesModified(File destDir) {
             String[] classnames = classesToGenerate(); // List of all stubs & skels

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/ejb/JbossDeploymentTool.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/JbossDeploymentTool.java b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/JbossDeploymentTool.java
index 79f4574..e6f8192 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/JbossDeploymentTool.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/JbossDeploymentTool.java
@@ -76,7 +76,6 @@ public class JbossDeploymentTool extends GenericDeploymentTool {
             log("Unable to locate jboss cmp descriptor. "
                 + "It was expected to be in "
                 + jbossCMPD.getPath(), Project.MSG_VERBOSE);
-            return;
         }
     }
 

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/ejb/OrionDeploymentTool.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/OrionDeploymentTool.java b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/OrionDeploymentTool.java
index 93bbbc0..02d646e 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/OrionDeploymentTool.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/OrionDeploymentTool.java
@@ -35,13 +35,15 @@ public class OrionDeploymentTool extends GenericDeploymentTool {
 
     protected static final String ORION_DD = "orion-ejb-jar.xml";
 
-
     /** Instance variable that stores the suffix for the jboss jarfile. */
     private String jarSuffix = ".jar";
 
     /**
      * Add any vendor specific files which should be included in the
      * EJB Jar.
+     *
+     * @param ejbFiles Hashtable&lt;String, File&gt;
+     * @param baseName String
      */
     protected void addVendorFiles(Hashtable ejbFiles, String baseName) {
         String ddPrefix = (usingBaseJarName() ? "" : baseName );
@@ -51,7 +53,6 @@ public class OrionDeploymentTool extends GenericDeploymentTool {
             ejbFiles.put(META_DIR + ORION_DD, orionDD);
         } else {
             log("Unable to locate Orion deployment descriptor. It was expected to be in " + orionDD.getPath(), Project.MSG_WARN);
-            return;
         }
 
     }
@@ -59,6 +60,8 @@ public class OrionDeploymentTool extends GenericDeploymentTool {
     /**
      * Get the vendor specific name of the Jar that will be output. The modification date
      * of this jar will be checked against the dependent bean classes.
+     *
+     * @param baseName String
      */
     File getVendorOutputJarFile(String baseName) {
         return new File(getDestDir(), baseName + jarSuffix);

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/ejb/WebsphereDeploymentTool.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/WebsphereDeploymentTool.java b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/WebsphereDeploymentTool.java
index 7114610..52668bd 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/WebsphereDeploymentTool.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/WebsphereDeploymentTool.java
@@ -158,7 +158,7 @@ public class WebsphereDeploymentTool extends GenericDeploymentTool {
     }
 
 
-    /** Sets the DB Vendor for the Entity Bean mapping ; optional.
+    /** Sets the DB Vendor for the Entity Bean mapping; optional.
      * <p>
      * Valid options can be obtained by running the following command:
      * <code>
@@ -268,7 +268,7 @@ public class WebsphereDeploymentTool extends GenericDeploymentTool {
     }
 
     /**
-     * Flag to use the WebSphere 3.5 compatible mapping rules ; optional, default false.
+     * Flag to use the WebSphere 3.5 compatible mapping rules; optional, default false.
      *
      * @param attr a <code>boolean</code> value.
      */
@@ -404,7 +404,7 @@ public class WebsphereDeploymentTool extends GenericDeploymentTool {
 
     /**
      * Add any vendor specific files which should be included in the EJB Jar.
-     * @param ejbFiles a hashtable entryname -> file.
+     * @param ejbFiles a hashtable entryname -&gt; file.
      * @param baseName a prefix to use.
      */
     protected void addVendorFiles(Hashtable ejbFiles, String baseName) {
@@ -466,7 +466,7 @@ public class WebsphereDeploymentTool extends GenericDeploymentTool {
                     log("Unable to locate the websphere Schema: "
                         + websphereSchema.getPath(), Project.MSG_VERBOSE);
                 }
-                // Theres nothing else to see here...keep moving sonny
+                // There is nothing else to see here...keep moving sonny
             } catch (Exception e) {
                 String msg = "Exception while adding Vendor specific files: "
                     + e.toString();

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/extension/Compatability.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/extension/Compatability.java b/src/main/org/apache/tools/ant/taskdefs/optional/extension/Compatability.java
index 2c06daf..cbc7f37 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/extension/Compatability.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/extension/Compatability.java
@@ -23,7 +23,7 @@ package org.apache.tools.ant.taskdefs.optional.extension;
  * of object.
  *
  * WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING
- *  This file is from excalibur.extension package. Dont edit this file
+ * This file is from excalibur.extension package. Do not edit this file
  * directly as there is no unit tests to make sure it is operational
  * in ant. Edit file in excalibur and run tests there before changing
  * ants file.

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/extension/Compatibility.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/extension/Compatibility.java b/src/main/org/apache/tools/ant/taskdefs/optional/extension/Compatibility.java
index bb28cd6..cfe12a1 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/extension/Compatibility.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/extension/Compatibility.java
@@ -23,7 +23,7 @@ package org.apache.tools.ant.taskdefs.optional.extension;
  * of object.
  *
  * WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING
- *  This file is from excalibur.extension package. Dont edit this file
+ * This file is from excalibur.extension package. Do not edit this file
  * directly as there is no unit tests to make sure it is operational
  * in ant. Edit file in excalibur and run tests there before changing
  * ants file.

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/extension/ExtensionUtil.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/extension/ExtensionUtil.java b/src/main/org/apache/tools/ant/taskdefs/optional/extension/ExtensionUtil.java
index ce66050..8f65fd4 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/extension/ExtensionUtil.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/extension/ExtensionUtil.java
@@ -45,7 +45,7 @@ public final class ExtensionUtil {
     /**
      * Convert a list of extensionAdapter objects to extensions.
      *
-     * @param adapters the list of ExtensionAdapterss to add to convert
+     * @param adapters the list of ExtensionAdapters to add to convert
      * @throws BuildException if an error occurs
      */
     static ArrayList toExtensions(final List adapters)
@@ -67,7 +67,7 @@ public final class ExtensionUtil {
      * Generate a list of extensions from a specified fileset.
      *
      * @param libraries the list to add extensions to
-     * @param fileset the filesets containing librarys
+     * @param fileset the filesets containing libraries
      * @throws BuildException if an error occurs
      */
     static void extractExtensions(final Project project,
@@ -199,7 +199,7 @@ public final class ExtensionUtil {
      *
      * @param file the file
      * @return the manifest
-     * @throws BuildException if errror occurs (file doesn't exist,
+     * @throws BuildException if error occurs (file doesn't exist,
      *         file not a jar, manifest doesn't exist in file)
      */
     static Manifest getManifest(final File file)

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibAvailableTask.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibAvailableTask.java b/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibAvailableTask.java
index cebcf0d..4cce0f5 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibAvailableTask.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibAvailableTask.java
@@ -37,7 +37,7 @@ public class JarLibAvailableTask extends Task {
     private File libraryFile;
 
     /**
-     * Filesets specifying all the librarys
+     * Filesets specifying all the libraries
      * to display information about.
      */
     private final Vector extensionFileSets = new Vector();

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibDisplayTask.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibDisplayTask.java b/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibDisplayTask.java
index da12cd0..d441b32 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibDisplayTask.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibDisplayTask.java
@@ -46,7 +46,7 @@ public class JarLibDisplayTask extends Task {
     private File libraryFile;
 
     /**
-     * Filesets specifying all the librarys
+     * Filesets specifying all the libraries
      * to display information about.
      */
     private final Vector libraryFileSets = new Vector();

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibManifestTask.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibManifestTask.java b/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibManifestTask.java
index 401dcfb..9941c86 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibManifestTask.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibManifestTask.java
@@ -251,8 +251,8 @@ public final class JarLibManifestTask extends Task {
      * Also use specified extensionKey so that can generate list of
      * optional dependencies as well.
      *
-     * @param size the number of librarys to list
-     * @param listPrefix the prefix for all librarys
+     * @param size the number of libraries to list
+     * @param listPrefix the prefix for all libraries
      * @param attributes the attributes to add key-value to
      * @param extensionKey the key to use
      */

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibResolveTask.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibResolveTask.java b/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibResolveTask.java
index c13194f..9ebb4e3 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibResolveTask.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibResolveTask.java
@@ -53,7 +53,7 @@ public class JarLibResolveTask extends Task {
 
     /**
      * Flag to indicate that you should check that
-     * the librarys resolved actually contain
+     * the libraries resolved actually contain
      * extension and if they don't then raise
      * an exception.
      */

http://git-wip-us.apache.org/repos/asf/ant/blob/67f29ce0/src/main/org/apache/tools/ant/taskdefs/optional/extension/LibFileSet.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/extension/LibFileSet.java b/src/main/org/apache/tools/ant/taskdefs/optional/extension/LibFileSet.java
index b21719e..94dc879 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/extension/LibFileSet.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/extension/LibFileSet.java
@@ -42,7 +42,7 @@ public class LibFileSet
     private boolean includeImpl;
 
     /**
-     * String that is the base URL for the librarys
+     * String that is the base URL for the libraries
      * when constructing the "Implementation-URL"
      * attribute. For instance setting the base to
      * "http://jakarta.apache.org/avalon/libs/" and then


Mime
View raw message