Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1CA90200D2C for ; Sun, 15 Oct 2017 07:25:35 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1B2A71609D5; Sun, 15 Oct 2017 05:25:35 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 699C8160BE6 for ; Sun, 15 Oct 2017 07:25:34 +0200 (CEST) Received: (qmail 79494 invoked by uid 500); 15 Oct 2017 05:25:33 -0000 Mailing-List: contact notifications-help@ant.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ant.apache.org Delivered-To: mailing list notifications@ant.apache.org Received: (qmail 79415 invoked by uid 99); 15 Oct 2017 05:25:33 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 15 Oct 2017 05:25:33 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id B3D53DF99F; Sun, 15 Oct 2017 05:25:30 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: bodewig@apache.org To: notifications@ant.apache.org Date: Sun, 15 Oct 2017 05:25:32 -0000 Message-Id: In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [3/3] ant git commit: Remove the redundant nullcheck of value known to be non-null. archived-at: Sun, 15 Oct 2017 05:25:35 -0000 Remove the redundant nullcheck of value known to be non-null. This statement contains a redundant check of a known non-null s against the constant null. http://findbugs.sourceforge.net/bugDescriptions.html#RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE Project: http://git-wip-us.apache.org/repos/asf/ant/repo Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/9ec11ae3 Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/9ec11ae3 Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/9ec11ae3 Branch: refs/heads/1.9.x Commit: 9ec11ae3b04d5a8389a6f90b70463f16ecd541a2 Parents: 20fe0ff Author: Kui LIU Authored: Sat Oct 14 17:20:29 2017 +0200 Committer: Stefan Bodewig Committed: Sun Oct 15 07:25:19 2017 +0200 ---------------------------------------------------------------------- src/main/org/apache/tools/ant/dispatch/DispatchUtils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ant/blob/9ec11ae3/src/main/org/apache/tools/ant/dispatch/DispatchUtils.java ---------------------------------------------------------------------- diff --git a/src/main/org/apache/tools/ant/dispatch/DispatchUtils.java b/src/main/org/apache/tools/ant/dispatch/DispatchUtils.java index 1a7c1f9..62dd88f 100644 --- a/src/main/org/apache/tools/ant/dispatch/DispatchUtils.java +++ b/src/main/org/apache/tools/ant/dispatch/DispatchUtils.java @@ -64,7 +64,7 @@ public class DispatchUtils { final Object o = actionM.invoke(dispatchable, (Object[]) null); if (o != null) { final String s = o.toString(); - if (s != null && s.trim().length() > 0) { + if (s.trim().length() > 0) { methodName = s.trim(); Method executeM = null; executeM = dispatchable.getClass().getMethod(