ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gin...@apache.org
Subject [3/3] ant-ivyde git commit: Checkstyle (whitespace, spellcheck, javadoc, braces, etc)
Date Sat, 28 Oct 2017 18:15:09 GMT
Checkstyle (whitespace, spellcheck, javadoc, braces, etc)

Project: http://git-wip-us.apache.org/repos/asf/ant-ivyde/repo
Commit: http://git-wip-us.apache.org/repos/asf/ant-ivyde/commit/fbb9bd31
Tree: http://git-wip-us.apache.org/repos/asf/ant-ivyde/tree/fbb9bd31
Diff: http://git-wip-us.apache.org/repos/asf/ant-ivyde/diff/fbb9bd31

Branch: refs/heads/master
Commit: fbb9bd31ec921641999df046cfba517ece2df5ae
Parents: e7bb8c2
Author: twogee <g.grigelionis@gmail.com>
Authored: Sat Oct 28 20:09:46 2017 +0200
Committer: twogee <g.grigelionis@gmail.com>
Committed: Sat Oct 28 20:09:46 2017 +0200

----------------------------------------------------------------------
 builder/component/build.properties              |  11 +-
 .../.project                                    |  12 +-
 .../resolvevisualizer/IvyNodeLabelProvider.java |  25 ++-
 .../MessageContentProvider.java                 |   5 +-
 .../ivyde/eclipse/resolvevisualizer/Plugin.java |   4 +-
 .../ResolveVisualizerContentProvider.java       |   7 +-
 .../ResolveVisualizerForm.java                  |  12 +-
 .../ResolveVisualizerPlugin.java                |   6 +-
 .../ResolveVisualizerView.java                  |  17 +-
 .../label/LabelDecoratorAlgorithmAdapter.java   |   6 +-
 .../label/ShortestRootPathAlgorithm.java        |   3 +-
 .../resolvevisualizer/model/IvyNodeElement.java |  18 +-
 .../model/IvyNodeElementAdapter.java            |  11 +-
 .../model/IvyNodeElementFilterAdapter.java      |   6 +-
 org.apache.ivyde.eclipse/.classpath             |   1 -
 .../src/etc/checkstyle/checkstyle-frames.xsl    |   5 +-
 .../src/etc/checkstyle/checkstyle-xdoc.xsl      |   5 +-
 .../completion/IvyCodeCompletionProcessor.java  |  48 +++--
 .../ivyde/common/ivyfile/IvyFileUpdater.java    |   3 +-
 .../common/ivysettings/IvySettingsModel.java    |  38 ++--
 .../common/model/IDocumentedValueProvider.java  |   2 -
 .../common/model/IvyBooleanTagAttribute.java    |   1 -
 .../org/apache/ivyde/common/model/IvyFile.java  |  74 +++----
 .../org/apache/ivyde/common/model/IvyTag.java   |   2 +-
 .../ivyde/common/model/IvyTagAttribute.java     |   2 +-
 .../ivyde/common/model/defaults.properties      |   6 +-
 .../ivyde/common/model/tagsdoc.properties       |  10 +-
 .../apache/ivyde/eclipse/IvyDEException.java    |  17 +-
 .../cp/IvyClasspathContainerConfiguration.java  |   6 +-
 .../eclipse/cp/IvyClasspathContainerHelper.java |  15 +-
 .../apache/ivyde/eclipse/cp/SecuritySetup.java  |  32 +--
 .../ivyde/eclipse/extension/IvyEditorPage.java  |   2 +-
 .../ivyde/internal/eclipse/CachedIvy.java       |   2 +-
 .../ivyde/internal/eclipse/IvyPlugin.java       |  64 +++---
 .../controller/SecuritySetupController.java     |   3 +-
 .../cpcontainer/ClasspathEntriesResolver.java   |   5 +-
 .../cpcontainer/IvyAttachementManager.java      | 205 -------------------
 .../cpcontainer/IvyAttachmentManager.java       | 200 ++++++++++++++++++
 .../IvyClasspathContainerConfAdapter.java       |  17 +-
 .../cpcontainer/IvyClasspathContainerImpl.java  |   8 +-
 .../IvyClasspathContainerMapper.java            |  14 +-
 .../IvyClasspathContainerSerializer.java        |  18 +-
 .../cpcontainer/IvyClasspathInitializer.java    |  15 +-
 .../eclipse/cpcontainer/IvyClasspathUtil.java   |  30 +--
 .../eclipse/cpcontainer/IvydeContainerPage.java |   7 +-
 .../internal/eclipse/resolve/IvyResolveJob.java |   4 +-
 .../internal/eclipse/resolve/IvyResolver.java   |  14 +-
 .../internal/eclipse/resolve/IvyRunner.java     |   4 +-
 .../internal/eclipse/resolve/ResolveResult.java |  29 ++-
 .../retrieve/StandaloneRetrieveSerializer.java  |   8 +-
 .../eclipse/revdepexplorer/IvyUtil.java         |   6 +-
 .../MultiRevDependencyDescriptor.java           |  21 +-
 .../internal/eclipse/ui/AbstractSetupTab.java   |   4 +-
 .../internal/eclipse/ui/AdvancedSetupTab.java   |   2 +-
 .../eclipse/ui/ClasspathSetupEditor.java        |   4 +-
 .../internal/eclipse/ui/ClasspathSetupTab.java  |   4 +-
 .../eclipse/ui/ClasspathTypeComposite.java      |   2 +-
 .../internal/eclipse/ui/ConfTableViewer.java    |   2 +-
 .../internal/eclipse/ui/IvyFilePathText.java    |   2 +-
 .../internal/eclipse/ui/MappingSetupTab.java    |   4 +-
 .../ivyde/internal/eclipse/ui/PathEditor.java   |  16 +-
 .../internal/eclipse/ui/RetrieveComposite.java  |   6 +-
 .../eclipse/ui/SecuritySetupEditor.java         |  35 ++--
 .../eclipse/ui/SettingsSetupEditor.java         |   2 +-
 .../internal/eclipse/ui/SettingsSetupTab.java   |   4 +-
 .../eclipse/ui/console/ConsoleDocument.java     |   3 +
 .../internal/eclipse/ui/console/IvyConsole.java |   8 +-
 .../ui/editors/IvyModuleDescriptorEditor.java   |  18 +-
 .../IvyModuleDescriptorEditorContributor.java   |   8 +-
 .../eclipse/ui/editors/IvySettingsEditor.java   |   8 +
 .../ui/editors/pages/IvyConfSection.java        |   1 -
 .../ui/editors/pages/IvyInfoSection.java        |  10 +-
 .../ui/editors/pages/OverviewFormPage.java      |   4 +-
 .../editors/xml/IvyContentAssistProcessor.java  |   4 +
 .../xml/NonRuleBasedDamagerRepairer.java        |  15 +-
 .../ui/editors/xml/XMLDocumentProvider.java     |   2 +-
 .../ui/menu/IvyMenuContributionItem.java        |   6 +-
 .../AdvancedSetupPreferencePage.java            |   2 +-
 .../ClasspathSetupPreferencePage.java           |   2 +-
 .../ui/preferences/IvyPreferencePage.java       |  10 +-
 .../preferences/MappingSetupPreferencePage.java |   2 +-
 .../ui/preferences/PreferenceConstants.java     |   4 +-
 .../SecuritySetupPreferencePage.java            |  15 +-
 .../SettingsSetupPreferencePage.java            |   2 +-
 .../WorkspaceResolverPreferencePage.java        |   2 +-
 .../preferences/XMLEditorPreferencesPage.java   |   4 +-
 .../ui/views/ReverseDependencyExplorerView.java |  13 +-
 .../eclipse/ui/wizards/IvyNewWizard.java        |  20 +-
 .../eclipse/ui/wizards/IvyNewWizardPage.java    |   8 +-
 .../eclipse/validator/BaseValidator.java        |   3 +-
 .../eclipse/validator/impl/HostValidator.java   |   2 +-
 .../eclipse/validator/impl/IdValidator.java     |   8 +-
 .../eclipse/validator/impl/RealmValidator.java  |   2 +-
 .../validator/impl/UserNameValidator.java       |   2 +-
 .../reaction/GeneralValidationReaction.java     |   6 +-
 .../workspaceresolver/IvyDEStrategy.java        |   2 +-
 .../workspaceresolver/WorkspaceIvySettings.java |   2 +-
 .../workspaceresolver/WorkspaceResolver.java    |  16 +-
 .../WorkspaceResourceChangeListener.java        |  11 +-
 .../common/ivyfile/IvyFileUpdaterTest.java      |   4 +-
 100 files changed, 729 insertions(+), 673 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/builder/component/build.properties
----------------------------------------------------------------------
diff --git a/builder/component/build.properties b/builder/component/build.properties
index 492131f..e6f55d1 100644
--- a/builder/component/build.properties
+++ b/builder/component/build.properties
@@ -37,7 +37,7 @@ runPackager=false
 # The prefix that will be used in the generated archive.
 archivePrefix=
 
-# The location underwhich all of the build output will be collected.
+# The location under which all of the build output will be collected.
 collectingFolder=${archivePrefix}
 
 # The list of {os, ws, arch} configurations to build.  This 
@@ -47,7 +47,7 @@ collectingFolder=${archivePrefix}
 configs = *, *, *
 #configs=win32, win32, x86 & \
 #	linux, gtk, ppc &\
-# linux, gtk, x86 & \
+#	linux, gtk, x86 & \
 #	linux, gtk, x86_64 & \
 #	linux, motif, x86 & \
 #	solaris, motif, sparc & \
@@ -65,15 +65,15 @@ configs = *, *, *
 #The list can only contain the configuration for which the desired format is different than zip.
 #archivesFormat=win32, win32, x86 - antZip& \
 #	linux, gtk, ppc - antZip &\
-#    linux, gtk, x86 - antZip& \
+#	linux, gtk, x86 - antZip& \
 #	linux, gtk, x86_64 - antZip& \
-# linux, motif, x86 - antZip& \
+#	linux, motif, x86 - antZip& \
 #	solaris, motif, sparc - antZip& \
 #	solaris, gtk, sparc - antZip& \
 #	aix, motif, ppc - antZip& \
 #	hpux, motif, PA_RISC - antZip& \
 #	macosx, carbon, ppc - antZip
-	
+
 #Set to true if you want the output to be ready for an update jar (no site.xml generated)
 # outputUpdateJars = false
 
@@ -223,4 +223,3 @@ bundleJavacSource=1.7
 # Default value for the version of the byte code targeted. This value is used when compiling plug-ins that do not set the Bundle-RequiredExecutionEnvironment or set javacTarget in build.properties.
 javacTarget=1.7
 bundleJavacTarget=1.7
-

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse.resolvevisualizer/.project
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse.resolvevisualizer/.project b/org.apache.ivyde.eclipse.resolvevisualizer/.project
index 9d88485..223e559 100644
--- a/org.apache.ivyde.eclipse.resolvevisualizer/.project
+++ b/org.apache.ivyde.eclipse.resolvevisualizer/.project
@@ -20,23 +20,19 @@
 <projectDescription>
 	<name>org.apache.ivyde.eclipse.resolvevisualizer</name>
 	<comment></comment>
-	<projects>
-	</projects>
+	<projects></projects>
 	<buildSpec>
 		<buildCommand>
 			<name>org.eclipse.jdt.core.javabuilder</name>
-			<arguments>
-			</arguments>
+			<arguments></arguments>
 		</buildCommand>
 		<buildCommand>
 			<name>org.eclipse.pde.ManifestBuilder</name>
-			<arguments>
-			</arguments>
+			<arguments></arguments>
 		</buildCommand>
 		<buildCommand>
 			<name>org.eclipse.pde.SchemaBuilder</name>
-			<arguments>
-			</arguments>
+			<arguments></arguments>
 		</buildCommand>
 	</buildSpec>
 	<natures>

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/IvyNodeLabelProvider.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/IvyNodeLabelProvider.java b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/IvyNodeLabelProvider.java
index 6d02fbe..987ea3d 100644
--- a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/IvyNodeLabelProvider.java
+++ b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/IvyNodeLabelProvider.java
@@ -60,7 +60,7 @@ public class IvyNodeLabelProvider implements ILabelProvider, IConnectionStylePro
     private GraphViewer viewer;
 
     private ILabelDecoratorAlgorithm autoSelectDecorator = new ShortestRootPathAlgorithm();
-    private DirectDependenciesAlgorithm rootDirectDependenciesDecorator = new DirectDependenciesAlgorithm();;
+    private DirectDependenciesAlgorithm rootDirectDependenciesDecorator = new DirectDependenciesAlgorithm();
     private ConfigurationConflictAlgorithm conflictDecorator = new ConfigurationConflictAlgorithm();
 
     private Color rootColor;
@@ -90,8 +90,9 @@ public class IvyNodeLabelProvider implements ILabelProvider, IConnectionStylePro
             String text = node.getOrganization() + "#" + node.getName() + ";";
             if (node.getRevision().indexOf("working@") != -1)
                 text += "WORKSPACE";
-            else
+            } else {
                 text += node.getRevision();
+            }
             return text;
         }
 
@@ -110,6 +111,9 @@ public class IvyNodeLabelProvider implements ILabelProvider, IConnectionStylePro
 
     /**
      * Colors all connections regardless of their selection status.
+     *
+     * @param rel Object
+     * @return Color
      */
     public Color getColor(Object rel) {
         if (highlightedRelationships.keySet().contains(rel)) {
@@ -124,8 +128,11 @@ public class IvyNodeLabelProvider implements ILabelProvider, IConnectionStylePro
     }
 
     /**
-     * Colors "highlighted" relationships. We want to differentiate between those highlighted programatically by the
-     * auto-select mechanism, and those hand-selected by the user.
+     * Colors "highlighted" relationships. We want to differentiate between those highlighted
+     * programmatically by the auto-select mechanism, and those hand-selected by the user.
+     *
+     * @param rel Object
+     * @return Color
      */
     public Color getHighlightColor(Object rel) {
         if (highlightedRelationships.keySet().contains(rel)) {
@@ -219,10 +226,10 @@ public class IvyNodeLabelProvider implements ILabelProvider, IConnectionStylePro
     }
 
     /**
-     * Sets the current selection
-     * 
-     * @param root
-     * @param currentSelection
+     * Sets the current selection.
+     *
+     * @param root IvyNodeElement
+     * @param currentSelection IvyNodeElement
      */
     public void setCurrentSelection(IvyNodeElement root, IvyNodeElement currentSelection) {
         for (Iterator iter = highlightedRelationships.keySet().iterator(); iter.hasNext();) {
@@ -303,4 +310,4 @@ public class IvyNodeLabelProvider implements ILabelProvider, IConnectionStylePro
     public void setAutoSelectDecorator(ILabelDecoratorAlgorithm decoratorAlgorithm) {
         this.autoSelectDecorator = decoratorAlgorithm;
     }
-}
\ No newline at end of file
+}

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/MessageContentProvider.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/MessageContentProvider.java b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/MessageContentProvider.java
index e5f7328..5752779 100644
--- a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/MessageContentProvider.java
+++ b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/MessageContentProvider.java
@@ -33,6 +33,8 @@ public class MessageContentProvider {
 
     /**
      * Called when the view selection changes and the message list needs to be rebuilt.
+     *
+     * @param root IvyNodeElement
      */
     public void selectionChanged(IvyNodeElement root) {
         if (root == null) {
@@ -47,8 +49,9 @@ public class MessageContentProvider {
             if (deepDependencies[i].getConflicts().length > 0) {
                 Collection/* <IvyNodeElement> */conflictParticipants = (Collection) conflicts.get(deepDependencies[i]
                         .getModuleRevisionId().getModuleId());
-                if (conflictParticipants == null)
+                if (conflictParticipants == null) {
                     conflictParticipants = new HashSet/* <IvyNodeElement> */();
+                }
                 conflictParticipants.add(deepDependencies[i]);
                 conflicts.put(deepDependencies[i].getModuleRevisionId().getModuleId(), conflictParticipants);
             }

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/Plugin.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/Plugin.java b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/Plugin.java
index ddf788c..753ca33 100644
--- a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/Plugin.java
+++ b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/Plugin.java
@@ -22,11 +22,11 @@ import org.eclipse.ui.plugin.AbstractUIPlugin;
 
 public class Plugin {
 
-	public static final String ID = "org.apache.ivyde.eclipse.resolvevisualizer";
+    public static final String ID = "org.apache.ivyde.eclipse.resolvevisualizer";
 
     /**
      * Returns an image descriptor for the image file at the given plug-in relative path.
-     * 
+     *
      * @param path
      *            the path
      * @return the image descriptor

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerContentProvider.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerContentProvider.java b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerContentProvider.java
index 16f8f84..41522c7 100644
--- a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerContentProvider.java
+++ b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerContentProvider.java
@@ -75,12 +75,13 @@ public class ResolveVisualizerContentProvider implements IGraphEntityContentProv
             IvyNodeElement element1 = (IvyNodeElement) arg1;
             IvyNodeElement element2 = (IvyNodeElement) arg2;
 
-            if (element1.getDepth() > element2.getDepth())
+            if (element1.getDepth() > element2.getDepth()) {
                 return -1;
-            else if (element1.getDepth() < element2.getDepth())
+            } else if (element1.getDepth() < element2.getDepth()) {
                 return 1;
+            }
 
             return element1.getModuleRevisionId().toString().compareTo(element2.getModuleRevisionId().toString());
         }
     }
-}
\ No newline at end of file
+}

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerForm.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerForm.java b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerForm.java
index 9261a31..8d5db19 100644
--- a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerForm.java
+++ b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerForm.java
@@ -77,7 +77,7 @@ import org.eclipse.zest.core.viewers.GraphViewer;
 import org.eclipse.zest.core.widgets.Graph;
 
 public class ResolveVisualizerForm {
-    public static final String HeaderText = "Ivy Resolve Visualization";
+    public static final String HEADER_TEXT = "Ivy Resolve Visualization";
 
     private FormToolkit toolkit;
     private GraphViewer viewer;
@@ -126,8 +126,8 @@ public class ResolveVisualizerForm {
 
     /**
      * Creates the section of the form where the graph is drawn
-     * 
-     * @param parent
+     *
+     * @param parent Composite
      */
     private void createGraphSection(Composite parent) {
         Section section = this.toolkit.createSection(parent, Section.TITLE_BAR);
@@ -156,7 +156,7 @@ public class ResolveVisualizerForm {
 
         toolkit.paintBordersFor(headClient);
         form.setHeadClient(headClient);
-        form.setText(HeaderText);
+        form.setText(HEADER_TEXT);
         enableSearchBox(false);
 
         form.getForm().addMessageHyperlinkListener(new HyperlinkAdapter() {
@@ -217,8 +217,8 @@ public class ResolveVisualizerForm {
 
     /**
      * Creates the sash form to separate the graph from the controls.
-     * 
-     * @param parent
+     *
+     * @param parent Composite
      */
     private void createSash(Composite parent) {
         sash = new SashForm(parent, SWT.NONE);

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerPlugin.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerPlugin.java b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerPlugin.java
index 5f8fb34..4a09b69 100644
--- a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerPlugin.java
+++ b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerPlugin.java
@@ -22,7 +22,7 @@ import org.eclipse.ui.plugin.AbstractUIPlugin;
 import org.osgi.framework.BundleContext;
 
 /**
- * The activator class controls the plug-in life cycle
+ * The activator class controls the plug-in life cycle.
  */
 public class ResolveVisualizerPlugin extends AbstractUIPlugin {
 
@@ -49,8 +49,8 @@ public class ResolveVisualizerPlugin extends AbstractUIPlugin {
     }
 
     /**
-     * Returns the shared instance
-     * 
+     * Returns the shared instance.
+     *
      * @return the shared instance
      */
     public static ResolveVisualizerPlugin getDefault() {

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerView.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerView.java b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerView.java
index 359fa2c..6dd6e7c 100644
--- a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerView.java
+++ b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerView.java
@@ -112,6 +112,8 @@ public class ResolveVisualizerView extends ViewPart implements IZoomableWorkbenc
 
     /**
      * This is a callback that will allow us to create the viewer and initialize it.
+     *
+     * @param parent Composite
      */
     public void createPartControl(Composite parent) {
         toolKit = new FormToolkit(parent.getDisplay());
@@ -366,13 +368,13 @@ public class ResolveVisualizerView extends ViewPart implements IZoomableWorkbenc
         viewer.getControl().setFocus();
     }
 
-    private final void focusOnContainer(IvyClasspathContainer container) {
+    private void focusOnContainer(IvyClasspathContainer container) {
         ResolveReport report = container.getResolveReport();
 
         if (report != null) {
             forceHiddenFilter.clearHidden();
             visualizationForm.getForm().setText(
-                    ResolveVisualizerForm.HeaderText + " - " + container.getConf().getIvyXmlPath() + " in \""
+                    ResolveVisualizerForm.HEADER_TEXT + " - " + container.getConf().getIvyXmlPath() + " in \""
                             + container.getConf().getJavaProject().getProject().getName() + "\"");
 
             IvyNodeElement nextRoot = IvyNodeElementAdapter.adapt(report);
@@ -389,9 +391,8 @@ public class ResolveVisualizerView extends ViewPart implements IZoomableWorkbenc
     /**
      * Update the view to focus on a particular bundle. If record history is set to true, and bundle does not equal the
      * current bundle, then the current bundle will be saved on the history stack
-     * 
-     * @param focus
-     * @param recordHistory
+     *
+     * @param focus IvyNodeElement
      */
     public void focusOn(IvyNodeElement focus) {
         viewer.setSelection(new StructuredSelection(focus));
@@ -423,8 +424,8 @@ public class ResolveVisualizerView extends ViewPart implements IZoomableWorkbenc
 
     /**
      * Handle the select changed. This will update the view whenever a selection occurs.
-     * 
-     * @param selectedItem
+     *
+     * @param selectedItem IvyNodeElement
      */
     private void selectionChanged(IvyNodeElement selectedItem) {
         currentSelection = selectedItem;
@@ -474,4 +475,4 @@ public class ResolveVisualizerView extends ViewPart implements IZoomableWorkbenc
             forceHidden.clear();
         }
     }
-}
\ No newline at end of file
+}

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/label/LabelDecoratorAlgorithmAdapter.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/label/LabelDecoratorAlgorithmAdapter.java b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/label/LabelDecoratorAlgorithmAdapter.java
index b592210..d8ad9cb 100644
--- a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/label/LabelDecoratorAlgorithmAdapter.java
+++ b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/label/LabelDecoratorAlgorithmAdapter.java
@@ -26,9 +26,9 @@ public abstract class LabelDecoratorAlgorithmAdapter implements ILabelDecoratorA
 
     /**
      * Specify custom colors for this algorithm instance.
-     * 
-     * @param entityColor
-     * @param relationshipColor
+     *
+     * @param entityColor Color
+     * @param relationshipColor ConnectionStyle
      */
     public void setStyles(Color entityColor, ConnectionStyle relationshipColor) {
         this.entityColor = entityColor;

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/label/ShortestRootPathAlgorithm.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/label/ShortestRootPathAlgorithm.java b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/label/ShortestRootPathAlgorithm.java
index 8fdec0a..8cf0764 100644
--- a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/label/ShortestRootPathAlgorithm.java
+++ b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/label/ShortestRootPathAlgorithm.java
@@ -59,8 +59,7 @@ public class ShortestRootPathAlgorithm extends LabelDecoratorAlgorithmAdapter {
                 q.addAll(Arrays.asList(head.getDependencies()));
             }
         }
-        IvyNodeElement[] path = fixedWeightDijkstraAlgorithm(orderedList, root, target);
-        return path;
+        return fixedWeightDijkstraAlgorithm(orderedList, root, target);
     }
 
     private IvyNodeElement[] fixedWeightDijkstraAlgorithm(LinkedList q, IvyNodeElement s, IvyNodeElement t) {

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/model/IvyNodeElement.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/model/IvyNodeElement.java b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/model/IvyNodeElement.java
index 5ae340d..24acba2 100644
--- a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/model/IvyNodeElement.java
+++ b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/model/IvyNodeElement.java
@@ -51,8 +51,9 @@ public class IvyNodeElement {
         if (obj instanceof IvyNodeElement) {
             IvyNodeElement elem = (IvyNodeElement) obj;
             if (elem.getOrganization().equals(getOrganization()) && elem.getName().equals(getName())
-                    && elem.getRevision().equals(getRevision()))
+                    && elem.getRevision().equals(getRevision())) {
                 return true;
+            }
         }
         return false;
     }
@@ -62,8 +63,8 @@ public class IvyNodeElement {
     }
 
     /**
-     * Recursive dependency retrieval
-     * 
+     * Recursive dependency retrieval.
+     *
      * @return The array of nodes that represents a node's immediate and transitive dependencies down to an arbitrary
      *         depth.
      */
@@ -76,9 +77,9 @@ public class IvyNodeElement {
 
     /**
      * Recursive dependency retrieval
-     * 
-     * @param node
-     * @return
+     *
+     * @param node IvyNodeElement
+     * @return Collection&lt;IvyNodeElement&gt;
      */
     private Collection/* <IvyNodeElement> */getDeepDependencies(IvyNodeElement node) {
         Collection/* <IvyNodeElement> */deepDependencies = new HashSet/* <IvyNodeElement> */();
@@ -93,6 +94,7 @@ public class IvyNodeElement {
     }
 
     /**
+     * @param caller IvyNodeElement
      * @return An array of configurations by which this module was resolved
      */
     public String[] getCallerConfigurations(IvyNodeElement caller) {
@@ -129,8 +131,8 @@ public class IvyNodeElement {
 
     /**
      * Set this node's depth and recursively update the node's children to relative to the new value.
-     * 
-     * @param depth
+     *
+     * @param depth int
      */
     public void setDepth(int depth) {
         this.depth = depth;

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/model/IvyNodeElementAdapter.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/model/IvyNodeElementAdapter.java b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/model/IvyNodeElementAdapter.java
index 1c3c71b..6f34ed1 100644
--- a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/model/IvyNodeElementAdapter.java
+++ b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/model/IvyNodeElementAdapter.java
@@ -33,8 +33,8 @@ import org.apache.ivy.core.resolve.IvyNodeCallers.Caller;
 public class IvyNodeElementAdapter {
     /**
      * Adapt all dependencies and evictions from the ResolveReport.
-     * 
-     * @param report
+     *
+     * @param report ResolveReport
      * @return the root node adapted from the ResolveReport
      */
     public static IvyNodeElement adapt(ResolveReport report) {
@@ -104,8 +104,8 @@ public class IvyNodeElementAdapter {
 
     /**
      * Derives configuration conflicts that exist between node and all of its descendant dependencies.
-     * 
-     * @param node
+     *
+     * @param node IvyNodeElement
      */
     private static void findConflictsBeneathNode(IvyNodeElement node) {
         // Derive conflicts
@@ -115,8 +115,9 @@ public class IvyNodeElementAdapter {
                                                                                        */();
         IvyNodeElement[] deepDependencies = node.getDeepDependencies();
         for (int i = 0; i < deepDependencies.length; i++) {
-            if (deepDependencies[i].isEvicted())
+            if (deepDependencies[i].isEvicted()) {
                 continue;
+            }
 
             ModuleId moduleId = deepDependencies[i].getModuleRevisionId().getModuleId();
             if (moduleRevisionMap.containsKey(moduleId)) {

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/model/IvyNodeElementFilterAdapter.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/model/IvyNodeElementFilterAdapter.java b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/model/IvyNodeElementFilterAdapter.java
index d32f039..a4a7d6b 100644
--- a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/model/IvyNodeElementFilterAdapter.java
+++ b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/model/IvyNodeElementFilterAdapter.java
@@ -24,13 +24,15 @@ public abstract class IvyNodeElementFilterAdapter implements IIvyNodeElementFilt
     protected boolean enabled = false;
 
     public IvyNodeElement[] filter(IvyNodeElement[] unfiltered) {
-        if (!enabled)
+        if (!enabled) {
             return unfiltered;
+        }
 
         Collection/* <IvyNodeElement> */filtered = new HashSet/* <IvyNodeElement> */();
         for (int i = 0; i < unfiltered.length; i++) {
-            if (accept(unfiltered[i]))
+            if (accept(unfiltered[i])) {
                 filtered.add(unfiltered[i]);
+            }
         }
 
         return (IvyNodeElement[]) filtered.toArray(new IvyNodeElement[filtered.size()]);

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/.classpath
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/.classpath b/org.apache.ivyde.eclipse/.classpath
index 5cc291e..74f2f57 100644
--- a/org.apache.ivyde.eclipse/.classpath
+++ b/org.apache.ivyde.eclipse/.classpath
@@ -17,7 +17,6 @@
    specific language governing permissions and limitations
    under the License.    
 -->
-<?xml version="1.0" encoding="UTF-8"?>
 <classpath>
 	<classpathentry kind="src" path="src/java"/>
 	<classpathentry kind="src" path="test/java"/>

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/src/etc/checkstyle/checkstyle-frames.xsl
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/src/etc/checkstyle/checkstyle-frames.xsl b/org.apache.ivyde.eclipse/src/etc/checkstyle/checkstyle-frames.xsl
index 7fe4954..3ad7901 100644
--- a/org.apache.ivyde.eclipse/src/etc/checkstyle/checkstyle-frames.xsl
+++ b/org.apache.ivyde.eclipse/src/etc/checkstyle/checkstyle-frames.xsl
@@ -1,7 +1,6 @@
 <xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform" version="1.0"
-    xmlns:lxslt="http://xml.apache.org/xslt"
-    xmlns:redirect="org.apache.xalan.lib.Redirect"
-    extension-element-prefixes="redirect">
+                xmlns:redirect="http://xml.apache.org/xalan/redirect"
+                extension-element-prefixes="redirect">
 
 <!--
    Licensed to the Apache Software Foundation (ASF) under one or more

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/src/etc/checkstyle/checkstyle-xdoc.xsl
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/src/etc/checkstyle/checkstyle-xdoc.xsl b/org.apache.ivyde.eclipse/src/etc/checkstyle/checkstyle-xdoc.xsl
index 4d7ab86..631fb01 100644
--- a/org.apache.ivyde.eclipse/src/etc/checkstyle/checkstyle-xdoc.xsl
+++ b/org.apache.ivyde.eclipse/src/etc/checkstyle/checkstyle-xdoc.xsl
@@ -1,7 +1,6 @@
 <xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform" version="1.0"
-    xmlns:lxslt="http://xml.apache.org/xslt"
-    xmlns:redirect="org.apache.xalan.lib.Redirect"
-    extension-element-prefixes="redirect">
+                xmlns:redirect="http://xml.apache.org/xalan/redirect"
+                extension-element-prefixes="redirect">
 
 <!--
    Licensed to the Apache Software Foundation (ASF) under one or more

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/completion/IvyCodeCompletionProcessor.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/completion/IvyCodeCompletionProcessor.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/completion/IvyCodeCompletionProcessor.java
index bfd7aad..a355218 100644
--- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/completion/IvyCodeCompletionProcessor.java
+++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/completion/IvyCodeCompletionProcessor.java
@@ -33,13 +33,17 @@ import org.apache.ivyde.common.model.Proposal;
 public class IvyCodeCompletionProcessor {
     private String errorMessage = null;
     private final IvyModel model;
-    
+
     public IvyCodeCompletionProcessor(IvyModel model) {
         this.model = model;
     }
 
     /**
-     * Call by viewer to retrieve a list of ICompletionProposal
+     * Call by viewer to retrieve a list of ICompletionProposal.
+     *
+     * @param ivyfile IvyFile
+     * @param caretOffset int
+     * @return CodeCompletionProposal[]
      */
     public CodeCompletionProposal[] computeCompletionProposals(IvyFile ivyfile, int caretOffset) {
         model.refreshIfNeeded(ivyfile);
@@ -61,14 +65,13 @@ public class IvyCodeCompletionProcessor {
     }
 
     /**
-     * Compute a list of possible attribute for the tag given in arguement.<br/> If attribute are
-     * already used in tag they are discard of the list
-     * 
-     * @param tagName
-     * @param doc
-     * @param documentOffset
-     * @param propList
-     * @param selectedRange
+     * Compute a list of possible attributes for the tag given in argument.<br/>
+     * If attributes are already used in tag, they are discarded from the list.
+     *
+     * @param tagName Ivy tag name
+     * @param ivyfile IvyFile
+     * @param propList List&lt;CodeCompletionProposal&gt;
+     * @param caretOffset ditto
      */
     private void computeTagAttributeProposals(String tagName, IvyFile ivyfile, List propList,
             int caretOffset) {
@@ -98,7 +101,7 @@ public class IvyCodeCompletionProcessor {
                     String text = att.getName() + "=\"\"";
                     // Construct proposal
                     CodeCompletionProposal proposal = new CodeCompletionProposal(
-                            text, ivyfile.getOffset() - qlen, qlen + caretOffset, 
+                            text, ivyfile.getOffset() - qlen, qlen + caretOffset,
                             text.length() - 1, att.getName(), att.getDoc());
                     // and add to result list
                     propList.add(proposal);
@@ -108,15 +111,14 @@ public class IvyCodeCompletionProcessor {
     }
 
     /**
-     * Compute a list of possible values for the current attribute of the given tag.<br>
-     * The list is retrieve by calling <code> IvyTag.getPossibleValuesForAttribute</code>
-     * 
-     * @see IvyTag#getPossibleValuesForAttribute(String, Map, String)
-     * @param tagName
-     * @param doc
-     * @param documentOffset
-     * @param propList
-     * @param selection
+     * Compute a list of possible values for the current attribute of the given tag.<br/>
+     * The list is retrieve by calling <code>IvyTag.getPossibleValuesForAttribute</code>
+     *
+     * @see org.apache.ivyde.common.model.IvyTag#getPossibleValuesForAttribute(String, IvyFile)
+     * @param tagName Ivy tag name
+     * @param ivyfile IvyFile
+     * @param propList List&lt;CodeCompletionProposal&gt;
+     * @param caretOffset ditto
      */
     private void computeValueProposals(String tagName, IvyFile ivyfile, List propList,
             int caretOffset) {
@@ -152,6 +154,10 @@ public class IvyCodeCompletionProcessor {
 
     /**
      * Compute xml structural proposition
+     *
+     * @param ivyfile IvyFile
+     * @param propList List&lt;CodeCompletionProposal&gt;
+     * @param caretOffset int
      */
     private void computeStructureProposals(IvyFile ivyfile, List propList, int caretOffset) {
         String parent = ivyfile.getParentTagName();
@@ -204,7 +210,7 @@ public class IvyCodeCompletionProcessor {
                     for (int i = 0; i < props.length; i++) {
                         // Construct proposal and add to result list
                         propList.add(new CodeCompletionProposal(
-                            props[i].getProposal(), ivyfile.getOffset() - qlen, qlen + caretOffset, 
+                            props[i].getProposal(), ivyfile.getOffset() - qlen, qlen + caretOffset,
                             props[i].getCursor(), null, props[i].getDoc()));
                     }
                 }

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/ivyfile/IvyFileUpdater.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/ivyfile/IvyFileUpdater.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/ivyfile/IvyFileUpdater.java
index ea4098c..4b0380d 100644
--- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/ivyfile/IvyFileUpdater.java
+++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/ivyfile/IvyFileUpdater.java
@@ -68,11 +68,12 @@ public class IvyFileUpdater {
      * Removes a direct dependency in the given Ivy file, or excludes it if it isn't a direct
      * dependency, unless the Ivy file declares no dependency at all, in which case the file isn't
      * changed.
-     * 
+     *
      * @param ivyFile
      *            the file pointing to the Ivy file to update
      * @param depId
      *            the module id of the dependency to remove or exclude
+     * @throws IOException failing to read the Ivy file
      */
     public void removeOrExcludeDependency(File ivyFile, ModuleId depId) throws IOException {
         String content = FileUtil.readEntirely(ivyFile);

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/ivysettings/IvySettingsModel.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/ivysettings/IvySettingsModel.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/ivysettings/IvySettingsModel.java
index fa3291b..6ef6a57 100644
--- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/ivysettings/IvySettingsModel.java
+++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/ivysettings/IvySettingsModel.java
@@ -85,19 +85,19 @@ public class IvySettingsModel extends IvyModel {
     private void doLoadModel() {
         IvyTag ivyTag = new IvyTag("ivysettings", "Root tag of Ivy settings file");
 
-        ivyTag.addChildIvyTag(new IvyTag("property",  
+        ivyTag.addChildIvyTag(new IvyTag("property",
             new IvyTagAttribute[] {
                 new IvyTagAttribute("name", true),
                 new IvyTagAttribute("value", true),
                 new IvyBooleanTagAttribute("override"),
         }));
-        ivyTag.addChildIvyTag(new IvyTag("properties",  
+        ivyTag.addChildIvyTag(new IvyTag("properties",
             new IvyTagAttribute[] {
                 new IvyTagAttribute("file", true),
                 new IvyTagAttribute("environment"),
                 new IvyBooleanTagAttribute("override"),
         }));
-        ivyTag.addChildIvyTag(new IvyTag("settings",  
+        ivyTag.addChildIvyTag(new IvyTag("settings",
             new IvyTagAttribute[] {
                 new IvyTagAttribute("defaultResolver"),
                 new IvyTagAttribute("defaultLatestStrategy"),
@@ -108,17 +108,17 @@ public class IvySettingsModel extends IvyModel {
                 new IvyBooleanTagAttribute("validate"),
                 new IvyBooleanTagAttribute("useRemoteConfig"),
         }));
-        ivyTag.addChildIvyTag(new IvyTag("include",  
+        ivyTag.addChildIvyTag(new IvyTag("include",
             new IvyTagAttribute[] {
                 new IvyTagAttribute("url"),
                 new IvyTagAttribute("file"),
         }));
-        ivyTag.addChildIvyTag(new IvyTag("classpath",  
+        ivyTag.addChildIvyTag(new IvyTag("classpath",
             new IvyTagAttribute[] {
                 new IvyTagAttribute("url"),
                 new IvyTagAttribute("file"),
         }));
-        ivyTag.addChildIvyTag(new IvyTag("typedef",  
+        ivyTag.addChildIvyTag(new IvyTag("typedef",
             new IvyTagAttribute[] {
                 new IvyTagAttribute("name"),
                 new IvyTagAttribute("classname"),
@@ -128,7 +128,7 @@ public class IvySettingsModel extends IvyModel {
         addTypedefChildren(tag, getChildClasses(typedefClasses, LockStrategy.class));
         ivyTag.addChildIvyTag(tag);
 
-        ivyTag.addChildIvyTag(new IvyTag("caches",  
+        ivyTag.addChildIvyTag(new IvyTag("caches",
             new IvyTagAttribute[] {
                 new IvyTagAttribute("default"),
                 new IvyTagAttribute("defaultCacheDir"),
@@ -139,7 +139,7 @@ public class IvySettingsModel extends IvyModel {
                 new IvyBooleanTagAttribute("checkUpToDate"),
                 new IvyBooleanTagAttribute("useOrigin"),
                 new IvyTagAttribute("lockStrategy"),
-            }).addChildIvyTag(new IvyTag("cache",  
+            }).addChildIvyTag(new IvyTag("cache",
                 new IvyTagAttribute[] {
                     new IvyTagAttribute("name"),
                     new IvyTagAttribute("basedir"),
@@ -148,7 +148,7 @@ public class IvySettingsModel extends IvyModel {
                     new IvyBooleanTagAttribute("useOrigin"),
                     new IvyTagAttribute("lockStrategy"),
                     new IvyTagAttribute("defaultTTL"),
-                }).addChildIvyTag(new IvyTag("ttl",  
+                }).addChildIvyTag(new IvyTag("ttl",
                     new IvyTagAttribute[] {
                         new IvyTagAttribute("organisation"),
                         new IvyTagAttribute("module"),
@@ -160,11 +160,11 @@ public class IvySettingsModel extends IvyModel {
         tag = new IvyTag("latest-strategies");
         addTypedefChildren(tag, getChildClasses(typedefClasses, LatestStrategy.class));
         ivyTag.addChildIvyTag(tag);
-        
+
         tag = new IvyTag("parsers");
         addTypedefChildren(tag, getChildClasses(typedefClasses, ModuleDescriptorParser.class));
         ivyTag.addChildIvyTag(tag);
-        
+
         tag = new IvyTag("namespaces");
         addTypedefChildren(tag, getChildClasses(typedefClasses, Namespace.class));
         ivyTag.addChildIvyTag(tag);
@@ -182,13 +182,13 @@ public class IvySettingsModel extends IvyModel {
         addTypedefChildren(tag, getChildClasses(typedefClasses, DependencyResolver.class));
         tag.addChildIvyTag(new IvyReferenceTag("resolver"));
         ivyTag.addChildIvyTag(tag);
-        
+
         tag = new IvyTag("conflict-managers");
         addTypedefChildren(tag, getChildClasses(typedefClasses, ConflictManager.class));
         ivyTag.addChildIvyTag(tag);
 
         ivyTag.addChildIvyTag(new IvyTag("modules")
-            .addChildIvyTag(new IvyTag("module",  
+            .addChildIvyTag(new IvyTag("module",
                 new IvyTagAttribute[] {
                     new IvyTagAttribute("organisation"),
                     new IvyTagAttribute("name"),
@@ -208,7 +208,7 @@ public class IvySettingsModel extends IvyModel {
             new IvyTagAttribute[] {
                     new IvyTagAttribute("default"),
                 })
-            .addChildIvyTag(new IvyTag("status",  
+            .addChildIvyTag(new IvyTag("status",
                 new IvyTagAttribute[] {
                     new IvyTagAttribute("name"),
                     new IvyTagAttribute("integration"),
@@ -243,17 +243,17 @@ public class IvySettingsModel extends IvyModel {
                 init();
                 return super.getAttributes();
             }
-            
+
             public List getChilds() {
                 init();
                 return super.getChilds();
             }
-            
+
             public boolean hasChild() {
                 init();
                 return super.hasChild();
             }
-            
+
             private void init() {
                 if (!init) {
                     try {
@@ -282,7 +282,7 @@ public class IvySettingsModel extends IvyModel {
                                 } else {
                                     addChildIvyTag(typedefedTag(name, m.getParameterTypes()[0]));
                                 }
-                            } else if (m.getName().startsWith("set") 
+                            } else if (m.getName().startsWith("set")
                                     && Void.TYPE.equals(m.getReturnType())
                                     && m.getParameterTypes().length == 1
                                     && isSupportedAttributeType(m.getParameterTypes()[0])) {
@@ -302,7 +302,7 @@ public class IvySettingsModel extends IvyModel {
                             null);
                     } catch (Exception e) {
                         getSettings().logError(
-                            "error occured while initializing tag for " + clazz + ": " + e,
+                            "error occurred while initializing tag for " + clazz + ": " + e,
                             e);
                     }
                     init = true;

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IDocumentedValueProvider.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IDocumentedValueProvider.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IDocumentedValueProvider.java
index 980d654..10e35ce 100644
--- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IDocumentedValueProvider.java
+++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IDocumentedValueProvider.java
@@ -18,7 +18,5 @@
 package org.apache.ivyde.common.model;
 
 public interface IDocumentedValueProvider extends IValueProvider {
-
     String getDocForValue(String value, IvyFile ivyFile);
-
 }

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyBooleanTagAttribute.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyBooleanTagAttribute.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyBooleanTagAttribute.java
index 25aaeae..0b80193 100644
--- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyBooleanTagAttribute.java
+++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyBooleanTagAttribute.java
@@ -25,7 +25,6 @@ public class IvyBooleanTagAttribute extends IvyTagAttribute {
         public String[] getValuesfor(IvyTagAttribute att, IvyFile ivyFile) {
             return BOOLEAN_VALUES;
         }
-
     };
 
     public IvyBooleanTagAttribute(String name, String doc, boolean mandatory) {

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyFile.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyFile.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyFile.java
index 38dd274..4e0044b 100644
--- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyFile.java
+++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyFile.java
@@ -71,7 +71,6 @@ public abstract class IvyFile {
     }
 
     public boolean inTag(int documentOffset) {
-        int lastSpaceIndex = documentOffset;
         boolean hasSpace = false;
         while (true) {
             // Read character backwards
@@ -100,9 +99,9 @@ public abstract class IvyFile {
     /**
      * Return the tag for the position. Note : the documentoffset is considered to be in a tag ie in
      * &lt; &gt;
-     * 
-     * @param documentOffset
-     * @return
+     *
+     * @param documentOffset int
+     * @return String
      */
     public String getTagName(int documentOffset) {
         int offset = documentOffset;
@@ -133,8 +132,7 @@ public abstract class IvyFile {
     }
 
     public int getStringIndexBackward(String string, int documentOffset) {
-        String text = doc.substring(0, documentOffset);
-        return text.lastIndexOf(string);
+        return doc.substring(0, documentOffset).lastIndexOf(string);
     }
 
     public int getStringIndexForward(String string) {
@@ -152,7 +150,6 @@ public abstract class IvyFile {
     public Map getAllAttsValues(int documentOffset) {
         Map result = new HashMap();
 
-        int offset = documentOffset;
         int start = reversed.indexOf('<', getReverseOffset(documentOffset));
         if (start != -1) {
             start = getReverseOffset(start);
@@ -186,7 +183,7 @@ public abstract class IvyFile {
                 }
             }
         } catch (Exception e) {
-            // FIXME : what is really catched here ?
+            // FIXME : what is really caught here ?
             if (settings != null) {
                 settings.logError("Something bad happened", e);
             }
@@ -199,21 +196,20 @@ public abstract class IvyFile {
     }
 
     /**
-     * Return the user typed string before calling completion stop on:<br>
+     * Return the user typed string before calling completion stop on:<br/>
      * &lt; to match tag,<br/>
      * space to found attribute name<br/>
-     * 
-     * @param documentOffset
-     * @return
+     *
+     * @param documentOffset int
+     * @return String
      */
     public String getQualifier(int documentOffset) {
-        Pattern p = QUALIFIER_PATTERN;
-        Matcher m = p.matcher(reversed);
+        Matcher m = QUALIFIER_PATTERN.matcher(reversed);
         if (m.find(getReverseOffset(documentOffset))) {
             return doc.substring(getReverseOffset(m.end()), documentOffset);
-        } else {
-            return "";
         }
+
+        return "";
     }
 
     public String getAttributeValueQualifier() {
@@ -221,39 +217,37 @@ public abstract class IvyFile {
     }
 
     /**
-     * Return the user typed string before calling completion on attribute value stop on:<br>
-     * " to match value for attribute
-     * 
-     * @param documentOffset
-     * @return
+     * Return the string typed by user before calling completion on attribute value.
+     * Stop on <code>&quot;</code> to match value for attribute.
+     *
+     * @param documentOffset int
+     * @return String
      */
     public String getAttributeValueQualifier(int documentOffset) {
         int index = reversed.indexOf("\"", getReverseOffset(documentOffset));
         if (index == -1) {
             return "";
-        } else {
-            return doc.substring(getReverseOffset(index), documentOffset);
         }
+
+        return doc.substring(getReverseOffset(index), documentOffset);
     }
 
     /**
-     * Returns the attribute name corresponding to the value currently edited
-     * 
-     * @return null if current offset is not in an attibute value
+     * Returns the attribute name corresponding to the value currently edited.
+     *
+     * @return null if current offset is not in an attribute value
      */
     public String getAttributeName() {
         return getAttributeName(currentOffset);
     }
 
     public String getAttributeName(int documentOffset) {
-        Pattern p = ATTRIBUTE_NAME_PATTERN;
-        Matcher m = p.matcher(reversed.substring(getReverseOffset(documentOffset)));
+        Matcher m = ATTRIBUTE_NAME_PATTERN.matcher(reversed.substring(getReverseOffset(documentOffset)));
         if (m.find() && m.start() == 0) {
-            String attName = new StringBuffer(m.group(1)).reverse().toString();
-            return attName;
-        } else {
-            return null;
+            return new StringBuffer(m.group(1)).reverse().toString();
         }
+
+        return null;
     }
 
     public String getParentTagName() {
@@ -263,15 +257,19 @@ public abstract class IvyFile {
     public String getParentTagName(int documentOffset) {
         int[] indexes = getParentTagIndex(documentOffset);
         String foundParent = getString(indexes);
-        return foundParent == null ? null : foundParent.trim();
+        if (foundParent == null) {
+            return null;
+        }
+
+        return foundParent.trim();
     }
 
     public String getString(int[] indexes) {
-        if (indexes != null) {
-            return doc.substring(indexes[0], indexes[1]);
-        } else {
+        if (indexes == null) {
             return null;
         }
+
+        return doc.substring(indexes[0], indexes[1]);
     }
 
     public String getString(int start, int end) {
@@ -299,7 +297,6 @@ public abstract class IvyFile {
                     lastSpaceIndex = offset;
                     // System.out.println("parentEndTagReached:"+doc.get(documentOffset-15,
                     // 15));
-                    continue;
                 } else { // simple tag
                     inSimpleTag = true;
                 }
@@ -311,7 +308,6 @@ public abstract class IvyFile {
                         parentEndTagReached = false;
                         stack.push(doc.substring(offset + 2, parentEndTagIndex).trim());
                         lastSpaceIndex = offset + 2;
-                        continue;
                     }
                 } else { // opening tag
                     if (doc.charAt(offset + 1) != '!' && doc.charAt(offset + 1) != '?') {
@@ -321,7 +317,6 @@ public abstract class IvyFile {
                             if (closedName.equalsIgnoreCase(doc.substring(offset + 1, offset + 1
                                     + closedName.length()))) {
                                 stack.pop();
-                                continue;
                             }
                         } else {
                             if (parentEndTagReached) {
@@ -332,7 +327,6 @@ public abstract class IvyFile {
                 }
             } else if (Character.isWhitespace(c)) {
                 lastSpaceIndex = offset;
-                continue;
             }
         }
         return null;

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyTag.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyTag.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyTag.java
index 7642817..9ceb33a 100644
--- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyTag.java
+++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyTag.java
@@ -43,7 +43,7 @@ public class IvyTag {
     private boolean allowNoChild = true;
 
     /**
-     * @param name
+     * @param name Ivy tag name
      */
     public IvyTag(String name) {
         super();

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyTagAttribute.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyTagAttribute.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyTagAttribute.java
index 330c6d9..dfbb58b 100644
--- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyTagAttribute.java
+++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyTagAttribute.java
@@ -35,7 +35,7 @@ public class IvyTagAttribute {
     private IValueProvider valueProvider = null;
 
     /**
-     * @param name
+     * @param name Ivy tag attribute name
      */
     public IvyTagAttribute(String name) {
         super();

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/defaults.properties
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/defaults.properties b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/defaults.properties
index ccec313..915bc29 100644
--- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/defaults.properties
+++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/defaults.properties
@@ -6,9 +6,9 @@
 #	 * to you under the Apache License, Version 2.0 (the
 #	 * "License"); you may not use this file except in compliance
 #	 * with the License.  You may obtain a copy of the License at
-#	 * 
+#	 *
 #	 *   http://www.apache.org/licenses/LICENSE-2.0
-#	 * 
+#	 *
 #	 * Unless required by applicable law or agreed to in writing,
 #	 * software distributed under the License is distributed on an
 #	 * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
@@ -19,4 +19,4 @@
 status = release, milestone, integration
 license = GPL, LGPL, BSD, CPL, Apache
 type = ivy, jar, war, ear
-ext = xml, jar, war, ear, zip 
+ext = xml, jar, war, ear, zip

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/tagsdoc.properties
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/tagsdoc.properties b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/tagsdoc.properties
index 6101696..cfc249b 100644
--- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/tagsdoc.properties
+++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/tagsdoc.properties
@@ -6,9 +6,9 @@
 #	 * to you under the Apache License, Version 2.0 (the
 #	 * "License"); you may not use this file except in compliance
 #	 * with the License.  You may obtain a copy of the License at
-#	 * 
+#	 *
 #	 *   http://www.apache.org/licenses/LICENSE-2.0
-#	 * 
+#	 *
 #	 * Unless required by applicable law or agreed to in writing,
 #	 * software distributed under the License is distributed on an
 #	 * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
@@ -31,7 +31,7 @@ ivysettings.resolvers.filesystem.@m2compatible = True if this resolver should be
 ivysettings.resolvers.filesystem.@local = True if this resolver should be considered local, false otherwise since 1.4. See useOrigin attribute on the caches element for details.
 ivysettings.resolvers.filesystem.@transactional = true to force the use of transaction, false to prevent the use of transaction, auto to get transaction when possible since 2.0. See above for details.
 ##### ivysettings.resolvers.ibiblio
-ivysettings.resolvers.ibiblio = This resolver usually uses ibiblio to find artifacts. 
+ivysettings.resolvers.ibiblio = This resolver usually uses ibiblio to find artifacts.
 ivysettings.resolvers.ibiblio.@root = the root of the artifacts repository.
 ivysettings.resolvers.ibiblio.@pattern = a pattern describing the layout of the artifacts repository.
 ivysettings.resolvers.ibiblio.@m2compatible = True if this resolver should be maven2 compatible, false otherwise since 1.3
@@ -158,7 +158,7 @@ ivysettings.namespaces.namespace.rule.fromsystem.src.@rev = the revision to matc
 ##### ivysettings.namespaces
 ivysettings.namespaces = Namespaces are an advanced feature of Ivy which let you use resolvers in which module names and organisations are not consistent between each other.
 ##### ivysettings.outputters
-ivysettings.outputters = Defines a list of report outputters usable in ivy. 
+ivysettings.outputters = Defines a list of report outputters usable in ivy.
 ##### ivysettings.parsers
 ivysettings.parsers = Defines a list of module descriptor parsers usable in ivy.
 ##### ivysettings.properties
@@ -214,4 +214,4 @@ ivysettings.typedef = Defines a new type in ivy. Useful to define new dependency
 ivysettings.typedef.@name = the name of the type to define. This name is then used as an xml tag.
 ivysettings.typedef.@classname = the fully qualified class name of the type to define.
 ##### ivysettings.version-matchers
-ivysettings.version-matchers = Defines a list of version matchers.
\ No newline at end of file
+ivysettings.version-matchers = Defines a list of version matchers.

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/IvyDEException.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/IvyDEException.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/IvyDEException.java
index 7e67ad0..5dac11a 100644
--- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/IvyDEException.java
+++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/IvyDEException.java
@@ -24,9 +24,10 @@ import org.eclipse.core.runtime.Status;
 import org.eclipse.jface.dialogs.MessageDialog;
 
 /**
- * Exception that will be displayed somehow to the end user. Once catched, depending of the context
- * the error could be popuped or just logged
+ * Exception that will be displayed somehow to the end user. Once caught, depending of the context
+ * the error could be popped up or just logged
  */
+@SuppressWarnings("serial")
 public class IvyDEException extends Exception {
 
     private final String shortMsg;
@@ -35,7 +36,7 @@ public class IvyDEException extends Exception {
 
     /**
      * Default constructor
-     * 
+     *
      * @param shortMsg
      *            a short description of the error, which doesn't need context information
      * @param msg
@@ -63,7 +64,7 @@ public class IvyDEException extends Exception {
 
     /**
      * Create a popup window to display the exception to the end user.
-     * 
+     *
      * @param status
      *            the status of the exception (error, waring or info)
      * @param title
@@ -98,7 +99,7 @@ public class IvyDEException extends Exception {
 
     /**
      * Log the exception in Eclipse log system.
-     * 
+     *
      * @param status
      *            the status of the exception (error, waring or info)
      * @param preMsg
@@ -111,7 +112,7 @@ public class IvyDEException extends Exception {
 
     /**
      * Convert the exception into an Eclipse status
-     * 
+     *
      * @param status
      *            the status of the exception (error, waring or info)
      * @param preMsg
@@ -124,8 +125,8 @@ public class IvyDEException extends Exception {
     }
 
     /**
-     * Show the exception in the Ivy console
-     * 
+     * Show the exception in the Ivy console.
+     *
      * @param status
      *            the status of the exception (error, waring or info)
      * @param preMsg

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cp/IvyClasspathContainerConfiguration.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cp/IvyClasspathContainerConfiguration.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cp/IvyClasspathContainerConfiguration.java
index 88b53b8..76eebd9 100644
--- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cp/IvyClasspathContainerConfiguration.java
+++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cp/IvyClasspathContainerConfiguration.java
@@ -62,7 +62,7 @@ public class IvyClasspathContainerConfiguration {
 
     /**
      * Constructor
-     * 
+     *
      * @param javaProject
      *            the classpath container's Java project, <code>null</code> is not bind to a project
      * @param ivyXmlPath
@@ -79,7 +79,7 @@ public class IvyClasspathContainerConfiguration {
 
     /**
      * Constructor
-     * 
+     *
      * @param javaProject
      *            the classpath container's Java project, <code>null</code> if not bind to a project
      * @param path
@@ -87,7 +87,7 @@ public class IvyClasspathContainerConfiguration {
      * @param editing
      *            if set to true, this bean will be used for edition purpose, so no need to trigger
      *            UI notification about some errors in there
-     * @param attributes
+     * @param attributes an array of IClasspathAttribute
      */
     public IvyClasspathContainerConfiguration(IJavaProject javaProject, IPath path,
             boolean editing, IClasspathAttribute[] attributes) {

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cp/IvyClasspathContainerHelper.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cp/IvyClasspathContainerHelper.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cp/IvyClasspathContainerHelper.java
index 5e3298f..53c4d1c 100644
--- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cp/IvyClasspathContainerHelper.java
+++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cp/IvyClasspathContainerHelper.java
@@ -48,11 +48,10 @@ public final class IvyClasspathContainerHelper {
 
     /**
      * Get the Ivy classpath container from the selection in the Java package view
-     * 
+     *
      * @param selection
      *            the selection
-     * @return
-     * @throws JavaModelException
+     * @return IvyClasspathContainer
      */
     public static IvyClasspathContainer getContainer(IStructuredSelection selection) {
         if (selection == null) {
@@ -81,7 +80,7 @@ public final class IvyClasspathContainerHelper {
 
     /**
      * Search the Ivy classpath containers within the specified Java project
-     * 
+     *
      * @param javaProject
      *            the project to search into
      * @return the Ivy classpath container if found
@@ -199,8 +198,8 @@ public final class IvyClasspathContainerHelper {
     }
 
     /**
-     * Search the Ivy classpath entry within the specified Java project with the specific path
-     * 
+     * Search the Ivy classpath entry within the specified Java project with the specific path.
+     *
      * @param containerPath
      *            the path of the container
      * @param javaProject
@@ -237,8 +236,8 @@ public final class IvyClasspathContainerHelper {
     }
 
     /**
-     * This will return all ivy projects in the workspace <br>
-     * 
+     * This will return all ivy projects in the workspace.
+     *
      * @return collection of ivy projects
      */
     public static IProject[] getIvyProjectsInWorkspace() {

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cp/SecuritySetup.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cp/SecuritySetup.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cp/SecuritySetup.java
index ae8f95b..2102f03 100644
--- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cp/SecuritySetup.java
+++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cp/SecuritySetup.java
@@ -34,10 +34,10 @@ public class SecuritySetup implements Comparable<SecuritySetup> {
     }
 
     /**
-     * @param host
-     * @param realm
-     * @param userName
-     * @param pwd
+     * @param host String
+     * @param realm String
+     * @param userName String
+     * @param pwd String
      */
     public SecuritySetup(String host, String realm, String userName, String pwd) {
         this.id = host + "@" + realm;
@@ -132,7 +132,7 @@ public class SecuritySetup implements Comparable<SecuritySetup> {
 
     /*
      * (non-Javadoc)
-     * 
+     *
      * @see java.lang.Object#hashCode()
      */
     @Override
@@ -146,28 +146,32 @@ public class SecuritySetup implements Comparable<SecuritySetup> {
 
     /*
      * (non-Javadoc)
-     * 
+     *
      * @see java.lang.Object#equals(java.lang.Object)
      */
     @Override
     public boolean equals(Object obj) {
-        if (this == obj)
+        if (this == obj) {
             return true;
-        if (obj == null)
-            return false;
-        if (getClass() != obj.getClass())
+        }
+        if (obj == null || getClass() != obj.getClass()) {
             return false;
+        }
         SecuritySetup other = (SecuritySetup) obj;
         if (host == null) {
-            if (other.host != null)
+            if (other.host != null) {
                 return false;
-        } else if (!host.equals(other.host))
+            }
+        } else if (!host.equals(other.host)) {
             return false;
+        }
         if (realm == null) {
-            if (other.realm != null)
+            if (other.realm != null) {
                 return false;
-        } else if (!realm.equals(other.realm))
+            }
+        } else if (!realm.equals(other.realm)) {
             return false;
+        }
         return true;
     }
 

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/extension/IvyEditorPage.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/extension/IvyEditorPage.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/extension/IvyEditorPage.java
index 6286234..d09127a 100644
--- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/extension/IvyEditorPage.java
+++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/extension/IvyEditorPage.java
@@ -22,7 +22,7 @@ import org.eclipse.ui.forms.editor.IFormPage;
 public interface IvyEditorPage extends IFormPage {
 
     public final static String EXTENSION_POINT = "org.apache.ivyde.eclipse.editorPage";
- 
+
     public String getPageName();
 
 }

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/CachedIvy.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/CachedIvy.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/CachedIvy.java
index 5a2bcfd..3b5d0cb 100644
--- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/CachedIvy.java
+++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/CachedIvy.java
@@ -250,7 +250,7 @@ public abstract class CachedIvy {
             ivySettings.setDefaultIvyUserDir(ivyUserDir.getFile());
         }
         Collection propFiles = getPropertyFiles();
-        if (propFiles == null || propFiles.isEmpty()) { 
+        if (propFiles == null || propFiles.isEmpty()) {
             IvyDEMessage.verbose("No property files to load");
         } else {
             IvyDEMessage.verbose(propFiles.size() + " property file(s) to load");

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/IvyPlugin.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/IvyPlugin.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/IvyPlugin.java
index 3ae72c7..fc96bb3 100644
--- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/IvyPlugin.java
+++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/IvyPlugin.java
@@ -32,7 +32,7 @@ import org.apache.ivyde.common.ivyfile.IvyFileResourceListener;
 import org.apache.ivyde.eclipse.IvyDEsecurityHelper;
 import org.apache.ivyde.eclipse.cp.IvyClasspathContainer;
 import org.apache.ivyde.eclipse.cp.IvyClasspathContainerHelper;
-import org.apache.ivyde.internal.eclipse.cpcontainer.IvyAttachementManager;
+import org.apache.ivyde.internal.eclipse.cpcontainer.IvyAttachmentManager;
 import org.apache.ivyde.internal.eclipse.cpcontainer.IvyClasspathContainerImpl;
 import org.apache.ivyde.internal.eclipse.cpcontainer.IvyClasspathContainerSerializer;
 import org.apache.ivyde.internal.eclipse.resolve.IvyResolveJob;
@@ -75,14 +75,14 @@ public class IvyPlugin extends AbstractUIPlugin {
     private static final Pattern IVY_VERSION_PATTERN = Pattern
             .compile("([0-9]+)\\.([0-9]+)\\.([0-9]+).*");
 
-    /** The ID of IvyDE plugin */
+    /** The ID of IvyDE plugin. */
     public static final String ID = "org.apache.ivyde.eclipse";
 
-    /** The ID of IvyDE problem markers */
+    /** The ID of IvyDE problem markers. */
     public static final String MARKER_ID = ID + ".marker";
 
     // The shared instance.
-    private volatile static IvyPlugin plugin;
+    private static volatile IvyPlugin plugin;
 
     // Resource bundle.
     private ResourceBundle resourceBundle;
@@ -113,7 +113,7 @@ public class IvyPlugin extends AbstractUIPlugin {
 
     private IvyClasspathContainerSerializer ivyCpcSerializer;
 
-    private IvyAttachementManager ivyAttachementManager;
+    private IvyAttachmentManager ivyAttachmentManager;
 
     private int ivyVersionMajor = 0;
 
@@ -130,7 +130,10 @@ public class IvyPlugin extends AbstractUIPlugin {
     }
 
     /**
-     * This method is called upon plug-in activation
+     * This method is called upon plug-in activation.
+     *
+     * @param context BundleContext
+     * @throws Exception if something goes wrong
      */
     public void start(BundleContext context) throws Exception {
         super.start(context);
@@ -206,14 +209,14 @@ public class IvyPlugin extends AbstractUIPlugin {
         ivyMarkerManager = new IvyMarkerManager();
 
         File stateLocation = getStateLocation().toFile();
-        ivyAttachementManager = new IvyAttachementManager(
-                new File(stateLocation, "attachements.properties"));
+        ivyAttachmentManager = new IvyAttachmentManager(
+                new File(stateLocation, "attachment.properties"));
         File containersStateDir = new File(stateLocation, "cpstates");
         if (!containersStateDir.exists()) {
             containersStateDir.mkdirs();
         }
         ivyCpcSerializer = new IvyClasspathContainerSerializer(containersStateDir,
-                ivyAttachementManager);
+                ivyAttachmentManager);
 
         try {
             Class.forName("org.apache.ivy.osgi.core.ManifestParser");
@@ -234,12 +237,15 @@ public class IvyPlugin extends AbstractUIPlugin {
     }
 
     /**
-     * This method is called when the plug-in is stopped
+     * This method is called when the plug-in is stopped.
+     *
+     * @param context BundleContext
+     * @throws Exception if something goes wrong
      */
     public void stop(BundleContext context) throws Exception {
         super.stop(context);
         ivyCpcSerializer = null;
-        ivyAttachementManager = null;
+        ivyAttachmentManager = null;
         resourceBundle = null;
         IWorkspace workspace = ResourcesPlugin.getWorkspace();
         workspace.removeSaveParticipant(this);
@@ -279,8 +285,8 @@ public class IvyPlugin extends AbstractUIPlugin {
     }
 
     /**
-     * Convenience method for logging statuses to the plugin log
-     * 
+     * Convenience method for logging statuses to the plugin log.
+     *
      * @param status
      *            the status to log
      */
@@ -306,7 +312,11 @@ public class IvyPlugin extends AbstractUIPlugin {
     }
 
     /**
-     * Log the given exception along with the provided message and severity indicator
+     * Log the given exception along with the provided message and severity indicator.
+     *
+     * @param severity int
+     * @param message String
+     * @param e Throwable
      */
     public static void log(int severity, String message, Throwable e) {
         log(new Status(severity, ID, 0, message, e));
@@ -334,7 +344,7 @@ public class IvyPlugin extends AbstractUIPlugin {
 
     /**
      * Returns the shared instance.
-     * 
+     *
      * @return the plugin instance
      */
     public static IvyPlugin getDefault() {
@@ -350,8 +360,8 @@ public class IvyPlugin extends AbstractUIPlugin {
     }
 
     /**
-     * Returns the active workbench shell
-     * 
+     * Returns the active workbench shell.
+     *
      * @return the active workbench shell
      */
     public static Shell getActiveWorkbenchShell() {
@@ -364,7 +374,7 @@ public class IvyPlugin extends AbstractUIPlugin {
 
     /**
      * Returns the active workbench page or <code>null</code> if none.
-     * 
+     *
      * @return the active workbench page
      */
     public static IWorkbenchPage getActivePage() {
@@ -376,8 +386,8 @@ public class IvyPlugin extends AbstractUIPlugin {
     }
 
     /**
-     * Returns the active workbench window
-     * 
+     * Returns the active workbench window.
+     *
      * @return the active workbench window
      */
     public static IWorkbenchWindow getActiveWorkbenchWindow() {
@@ -393,6 +403,8 @@ public class IvyPlugin extends AbstractUIPlugin {
 
     /**
      * Returns the string from the plugin's resource bundle, or 'key' if not found.
+     *
+     * @param key String
      */
     public static String getResourceString(String key) {
         ResourceBundle bundle = IvyPlugin.getDefault().getResourceBundle();
@@ -405,7 +417,7 @@ public class IvyPlugin extends AbstractUIPlugin {
 
     /**
      * Utility class that tries to adapt a non null object to the specified type
-     * 
+     *
      * @param object
      *            the object to adapt
      * @param type
@@ -423,7 +435,9 @@ public class IvyPlugin extends AbstractUIPlugin {
     }
 
     /**
-     * Returns the plugin's resource bundle,
+     * Returns the plugin's resource bundle.
+     *
+     * @return ResourceBundle
      */
     public ResourceBundle getResourceBundle() {
         try {
@@ -448,7 +462,7 @@ public class IvyPlugin extends AbstractUIPlugin {
 
     /**
      * Returns an image descriptor for the image file at the given plug-in relative path.
-     * 
+     *
      * @param path
      *            the path
      * @return the image descriptor
@@ -484,8 +498,8 @@ public class IvyPlugin extends AbstractUIPlugin {
         return ivyCpcSerializer;
     }
 
-    public IvyAttachementManager getIvyAttachementManager() {
-        return ivyAttachementManager;
+    public IvyAttachmentManager getIvyAttachmentManager() {
+        return ivyAttachmentManager;
     }
 
     public IvyResolveJob getIvyResolveJob() {

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/controller/SecuritySetupController.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/controller/SecuritySetupController.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/controller/SecuritySetupController.java
index 21913dc..53516c6 100644
--- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/controller/SecuritySetupController.java
+++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/controller/SecuritySetupController.java
@@ -76,8 +76,7 @@ public class SecuritySetupController {
     private DataBindingContext ctx = new DataBindingContext();
 
     /**
-     * @param setupEditorGUI
-     * @param addDialog
+     * @param setupEditorGUI SecuritySetupEditor
      */
     public SecuritySetupController(SecuritySetupEditor setupEditorGUI) {
         this.setupEditorGUI = setupEditorGUI;

http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/fbb9bd31/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/cpcontainer/ClasspathEntriesResolver.java
----------------------------------------------------------------------
diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/cpcontainer/ClasspathEntriesResolver.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/cpcontainer/ClasspathEntriesResolver.java
index c6e855c..6901eb1 100644
--- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/cpcontainer/ClasspathEntriesResolver.java
+++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/cpcontainer/ClasspathEntriesResolver.java
@@ -84,7 +84,10 @@ public class ClasspathEntriesResolver extends IvyResolver {
      * Trigger a warn if there are duplicates entries due to configuration conflict.
      * <p>
      * TODO: the algorithm can be more clever and find which configuration are conflicting.
-     * 
+     * </p>
+     * @param ivy Ivy
+     * @param mapper IvyClasspathContainerMapper
+     * @param artifactReports Set&lt;ArtifactDownloadReport&gt;
      */
     private void warnIfDuplicates(Ivy ivy, IvyClasspathContainerMapper mapper, Set artifactReports) {
         ArtifactDownloadReport[] reports = (ArtifactDownloadReport[]) artifactReports


Mime
View raw message