ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IVY-511) Use standard coding conventions
Date Sat, 03 Jun 2017 09:46:04 GMT

    [ https://issues.apache.org/jira/browse/IVY-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035911#comment-16035911
] 

ASF GitHub Bot commented on IVY-511:
------------------------------------

GitHub user twogee opened a pull request:

    https://github.com/apache/ant-ivy/pull/41

    Checkstyle

    Now that checkstyle rules are sync'ed with Ant, here come the consequences 😃 
    I guess the famous https://issues.apache.org/jira/browse/IVY-511 is due for an update...

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twogee/ant-ivy checkstyle

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant-ivy/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #41
    
----
commit 838aa1bd37ff2f60a51c60969204964839937eb9
Author: twogee <g.grigelionis@gmail.com>
Date:   2017-06-02T15:37:04Z

    first batch of SVG replacements

commit 57ee0f2d15768efd10c15c7ef14da8a7db94deaa
Author: twogee <g.grigelionis@gmail.com>
Date:   2017-06-03T07:58:10Z

    Inline warning icon

commit 1ca5f08e25401ad9861d6de333f8e53791384be6
Author: twogee <g.grigelionis@gmail.com>
Date:   2017-06-03T09:42:00Z

    Checkstyle-driven cleanup (whitespace, javadoc, JLS)

----


> Use standard coding conventions
> -------------------------------
>
>                 Key: IVY-511
>                 URL: https://issues.apache.org/jira/browse/IVY-511
>             Project: Ivy
>          Issue Type: Improvement
>            Reporter: Xavier Hanin
>              Labels: patch
>         Attachments: ivy.diff
>
>
> At the moment Ivy code base is using sun standard coding conventions, except for private
fields which use an underscore prefix.
> Using the plain standard conventions would help developers read the code more easily,
and thus could attract more developers.
> The coding conventions are described here:
> http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message