Mailing-List: contact notifications-help@ant.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ant.apache.org
Date: Sun, 11 Dec 2016 08:50:59 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: notifications@ant.apache.org
Message-ID: <JIRA.12733851.1407957490000.493033.1481446259805@Atlassian.JIRA>
In-Reply-To: <JIRA.12733851.1407957490000@Atlassian.JIRA>
References: <JIRA.12733851.1407957490000@Atlassian.JIRA> <JIRA.12733851.1407957490315@arcas>
Subject: [jira] [Commented] (IVY-1482) NPE in XmlReportOutputter
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 11 Dec 2016 08:51:01 -0000


    [ https://issues.apache.org/jira/browse/IVY-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15739376#comment-15739376 ] 

ASF GitHub Bot commented on IVY-1482:
-------------------------------------

GitHub user jaikiran opened a pull request:

    https://github.com/apache/ant-ivy/pull/12

    IVY-1482 Fix potential NPE in XmlReportOutputter

    The commit here adds a null check to prevent potential NPE reported in JIRA https://issues.apache.org/jira/browse/IVY-1482


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaikiran/ant-ivy ivy-1482

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant-ivy/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12
    
----
commit 0dc25d1d378861f2528b3de655afbced7c2f5a06
Author: Jaikiran Pai <jaikiran.pai@gmail.com>
Date:   2016-12-11T08:48:37Z

    IVY-1482 Fix potential NPE in XmlReportOutputter

----


> NPE in XmlReportOutputter
> -------------------------
>
>                 Key: IVY-1482
>                 URL: https://issues.apache.org/jira/browse/IVY-1482
>             Project: Ivy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.4.0-RC1
>            Reporter: M Kim
>
> {code}
> public void output(ConfigurationResolveReport report, String resolveId, String[] confs, ResolutionCacheManager cacheMgr) throws IOException {
>      File reportFile = cacheMgr.getConfigurationResolveReportInCache(resolveId,
>             report.getConfiguration());
>      File reportParentDir = reportFile.getParentFile();
>      reportParentDir.mkdirs(); // NPE
>      OutputStream stream = new FileOutputStream(reportFile);
>      writer.output(report, confs, stream);
>      stream.close();
>      //...
> }
> {code}
> In XmlReportOutputter.output method, NPE occurs when reportFile.getParentFile() returns null. I think a proper error handling is needed for reportFile and reportParentDir before OutputStream is created.
> <Test case>
> {code}
> public void test1() {
>   Ivy14 ivy = new org.apache.ivy.Ivy14();
>   ManifestHeaderElement header = new ManifestHeaderElement();
>   ModuleRevisionId resolveId = ModuleRevisionId.newInstance("", "ISO-8859-1", "default", "default", header.getAttributes(), true);
>   Pack200Packing pack = new Pack200Packing();
>   String[] strings = pack.getNames();
>   ResolveReport report = ivy.resolve(resolveId, strings);
>   ResolveOptions options = new ResolveOptions();
>   report.output(new ReportOutputter[]{new XmlReportOutputter()}, (ResolutionCacheManager)new DefaultResolutionCacheManager(), options.setResolveId("latest-revision").setOutputReport(true));
> }
> {code}
> <Stack trace>
> {code}
> 1) test1(Test0)java.lang.NullPointerException
> at org.apache.ivy.plugins.report.XmlReportOutputter.output(XmlReportOutputter.java:56)
> at org.apache.ivy.plugins.report.XmlReportOutputter.output(XmlReportOutputter.java:47)
> at org.apache.ivy.core.report.ResolveReport.output(ResolveReport.java:106)
> at Test0.test1(Test0.java:48)
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)