ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bode...@apache.org
Subject [1/3] ant git commit: false positives for exceptions thrown from finally
Date Wed, 21 Dec 2016 06:25:55 GMT
Repository: ant
Updated Branches:
  refs/heads/master 20026444c -> 451c42444


false positives for exceptions thrown from finally


Project: http://git-wip-us.apache.org/repos/asf/ant/repo
Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/7ffc0970
Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/7ffc0970
Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/7ffc0970

Branch: refs/heads/master
Commit: 7ffc0970d55e6f9285e474cdb443b085bafad76c
Parents: fba969e
Author: Stefan Bodewig <bodewig@apache.org>
Authored: Wed Dec 21 07:23:59 2016 +0100
Committer: Stefan Bodewig <bodewig@apache.org>
Committed: Wed Dec 21 07:23:59 2016 +0100

----------------------------------------------------------------------
 src/main/org/apache/tools/ant/Main.java                          | 2 +-
 src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java     | 4 ++--
 .../tools/ant/taskdefs/optional/net/FTPTaskMirrorImpl.java       | 4 ++--
 .../apache/tools/ant/taskdefs/optional/splash/SplashTask.java    | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ant/blob/7ffc0970/src/main/org/apache/tools/ant/Main.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/Main.java b/src/main/org/apache/tools/ant/Main.java
index 81e4ef1..075ec83 100644
--- a/src/main/org/apache/tools/ant/Main.java
+++ b/src/main/org/apache/tools/ant/Main.java
@@ -887,7 +887,7 @@ public class Main implements AntMain {
                                            + " that:");
                         error.printStackTrace();
                     }
-                    throw new BuildException(t);
+                    throw new BuildException(t); //NOSONAR
                 }
             } else if (error != null) {
                 project.log(error.toString(), Project.MSG_ERR);

http://git-wip-us.apache.org/repos/asf/ant/blob/7ffc0970/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java b/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java
index cef9dda..b6360ca 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java
@@ -747,7 +747,7 @@ public class FTP extends Task implements FTPTaskConfig {
                     try {
                         ftp.changeWorkingDirectory(directory);
                     } catch (IOException ioe) {
-                        throw new BuildException(ioe, getLocation());
+                        throw new BuildException(ioe, getLocation()); //NOSONAR
                     }
                 }
                 getProject().log("remote system is case sensitive : " + remoteSystemCaseSensitive,
@@ -1155,7 +1155,7 @@ public class FTP extends Task implements FTPTaskConfig {
                                      Project.MSG_ERR);
                 } finally {
                     if (!comeback) {
-                        throw new BuildException("could not cd back to " + dir
+                        throw new BuildException("could not cd back to " + dir //NOSONAR
                                                  + " while checking a symlink");
                     }
                 }

http://git-wip-us.apache.org/repos/asf/ant/blob/7ffc0970/src/main/org/apache/tools/ant/taskdefs/optional/net/FTPTaskMirrorImpl.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/net/FTPTaskMirrorImpl.java b/src/main/org/apache/tools/ant/taskdefs/optional/net/FTPTaskMirrorImpl.java
index 81752b3..6cb79c8 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/net/FTPTaskMirrorImpl.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/net/FTPTaskMirrorImpl.java
@@ -648,7 +648,7 @@ public class FTPTaskMirrorImpl implements FTPTaskMirror {
                     try {
                         ftp.changeWorkingDirectory(directory);
                     } catch (IOException ioe) {
-                        throw new BuildException(ioe, task.getLocation());
+                        throw new BuildException(ioe, task.getLocation()); //NOSONAR
                     }
                 }
                 task.log("remote system is case sensitive : "
@@ -1061,7 +1061,7 @@ public class FTPTaskMirrorImpl implements FTPTaskMirror {
                                           Project.MSG_ERR);
                 } finally {
                     if (!comeback) {
-                        throw new BuildException("could not cd back to " + dir
+                        throw new BuildException("could not cd back to " + dir //NOSONAR
                                                  + " while checking a symlink");
                     }
                 }

http://git-wip-us.apache.org/repos/asf/ant/blob/7ffc0970/src/main/org/apache/tools/ant/taskdefs/optional/splash/SplashTask.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/splash/SplashTask.java b/src/main/org/apache/tools/ant/taskdefs/optional/splash/SplashTask.java
index 3a73bdf..146e0ff 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/splash/SplashTask.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/splash/SplashTask.java
@@ -262,7 +262,7 @@ public class SplashTask extends Task {
                     // swallow if there was an error before so that
                     // original error will be passed up
                     if (success) {
-                        throw new BuildException(ioe);
+                        throw new BuildException(ioe); //NOSONAR
                     }
                 }
             }


Mime
View raw message