ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bode...@apache.org
Subject [6/6] ant git commit: false positives
Date Wed, 21 Dec 2016 19:12:03 GMT
false positives


Project: http://git-wip-us.apache.org/repos/asf/ant/repo
Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/121043fe
Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/121043fe
Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/121043fe

Branch: refs/heads/1.9.x
Commit: 121043fe596097cbcdde3fa54600848b1c67935c
Parents: 984a03d
Author: Stefan Bodewig <bodewig@apache.org>
Authored: Wed Dec 21 20:11:36 2016 +0100
Committer: Stefan Bodewig <bodewig@apache.org>
Committed: Wed Dec 21 20:11:36 2016 +0100

----------------------------------------------------------------------
 src/main/org/apache/tools/ant/ArgumentProcessorRegistry.java    | 2 +-
 src/main/org/apache/tools/ant/ComponentHelper.java              | 2 +-
 src/main/org/apache/tools/ant/Diagnostics.java                  | 2 +-
 src/main/org/apache/tools/ant/taskdefs/HostInfo.java            | 4 ++--
 src/main/org/apache/tools/ant/taskdefs/optional/sos/SOSCmd.java | 2 +-
 src/main/org/apache/tools/ant/util/ProxySetup.java              | 4 ++--
 src/main/org/apache/tools/ant/util/StringUtils.java             | 2 +-
 7 files changed, 9 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ant/blob/121043fe/src/main/org/apache/tools/ant/ArgumentProcessorRegistry.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/ArgumentProcessorRegistry.java b/src/main/org/apache/tools/ant/ArgumentProcessorRegistry.java
index 0c7c35b..1ede565 100644
--- a/src/main/org/apache/tools/ant/ArgumentProcessorRegistry.java
+++ b/src/main/org/apache/tools/ant/ArgumentProcessorRegistry.java
@@ -93,7 +93,7 @@ public class ArgumentProcessorRegistry {
                     + SERVICE_ID + " (" + e.getClass().getName() + ": "
                     + e.getMessage() + ")");
             if (DEBUG) {
-                e.printStackTrace(System.err);
+                e.printStackTrace(System.err); //NOSONAR
             }
         }
     }

http://git-wip-us.apache.org/repos/asf/ant/blob/121043fe/src/main/org/apache/tools/ant/ComponentHelper.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/ComponentHelper.java b/src/main/org/apache/tools/ant/ComponentHelper.java
index eceedee..4942d24 100644
--- a/src/main/org/apache/tools/ant/ComponentHelper.java
+++ b/src/main/org/apache/tools/ant/ComponentHelper.java
@@ -971,7 +971,7 @@ public class ComponentHelper  {
                     Throwable t = ex.getTargetException();
                     out.println("Cause: The constructor threw the exception");
                     out.println(t.toString());
-                    t.printStackTrace(out);
+                    t.printStackTrace(out); //NOSONAR
                 }  catch (NoClassDefFoundError ncdfe) {
                     jars = true;
                     out.println("Cause:  A class needed by class " + classname

http://git-wip-us.apache.org/repos/asf/ant/blob/121043fe/src/main/org/apache/tools/ant/Diagnostics.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/Diagnostics.java b/src/main/org/apache/tools/ant/Diagnostics.java
index 6389f6e..4ad57a0 100644
--- a/src/main/org/apache/tools/ant/Diagnostics.java
+++ b/src/main/org/apache/tools/ant/Diagnostics.java
@@ -471,7 +471,7 @@ public final class Diagnostics {
         // report error if something weird happens...this is diagnostic.
         if (error != null) {
             out.println("Error while running org.apache.env.Which");
-            error.printStackTrace();
+            error.printStackTrace(out); //NOSONAR
         }
     }
 

http://git-wip-us.apache.org/repos/asf/ant/blob/121043fe/src/main/org/apache/tools/ant/taskdefs/HostInfo.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/HostInfo.java b/src/main/org/apache/tools/ant/taskdefs/HostInfo.java
index 5cd433c..43a1211 100644
--- a/src/main/org/apache/tools/ant/taskdefs/HostInfo.java
+++ b/src/main/org/apache/tools/ant/taskdefs/HostInfo.java
@@ -43,11 +43,11 @@ import org.apache.tools.ant.Task;
 public class HostInfo extends Task {
     private static final String DEF_REM_ADDR6 = "::";
 
-    private static final String DEF_REM_ADDR4 = "0.0.0.0";
+    private static final String DEF_REM_ADDR4 = "0.0.0.0"; //NOSONAR
 
     private static final String DEF_LOCAL_ADDR6 = "::1";
 
-    private static final String DEF_LOCAL_ADDR4 = "127.0.0.1";
+    private static final String DEF_LOCAL_ADDR4 = "127.0.0.1"; //NOSONAR
 
     private static final String DEF_LOCAL_NAME = "localhost";
     private static final String DEF_DOMAIN = "localdomain";

http://git-wip-us.apache.org/repos/asf/ant/blob/121043fe/src/main/org/apache/tools/ant/taskdefs/optional/sos/SOSCmd.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/sos/SOSCmd.java b/src/main/org/apache/tools/ant/taskdefs/optional/sos/SOSCmd.java
index 3543c41..9d7d543 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/sos/SOSCmd.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/sos/SOSCmd.java
@@ -53,7 +53,7 @@ public interface SOSCmd {
     /** The username option */
     String FLAG_USERNAME = "-name";
     /** The password option */
-    String FLAG_PASSWORD = "-password";
+    String FLAG_PASSWORD = "-password"; //NOSONAR
     /** The log option */
     String FLAG_COMMENT = "-log";
     /** The workdir option */

http://git-wip-us.apache.org/repos/asf/ant/blob/121043fe/src/main/org/apache/tools/ant/util/ProxySetup.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/util/ProxySetup.java b/src/main/org/apache/tools/ant/util/ProxySetup.java
index f077f87..ea69e72 100644
--- a/src/main/org/apache/tools/ant/util/ProxySetup.java
+++ b/src/main/org/apache/tools/ant/util/ProxySetup.java
@@ -57,7 +57,7 @@ public class ProxySetup {
     /** the http proxy username property */
     public static final String HTTP_PROXY_USERNAME = "http.proxyUser";
     /** the http proxy password property */
-    public static final String HTTP_PROXY_PASSWORD = "http.proxyPassword";
+    public static final String HTTP_PROXY_PASSWORD = "http.proxyPassword"; //NOSONAR
     /** the socks proxy host property */
     public static final String SOCKS_PROXY_HOST = "socksProxyHost";
     /** the socks proxy port property */
@@ -65,7 +65,7 @@ public class ProxySetup {
     /** the socks proxy username property */
     public static final String SOCKS_PROXY_USERNAME = "java.net.socks.username";
     /** the socks proxy password property */
-    public static final String SOCKS_PROXY_PASSWORD = "java.net.socks.password";
+    public static final String SOCKS_PROXY_PASSWORD = "java.net.socks.password"; //NOSONAR
 
     /**
      * create a proxy setup class bound to this project

http://git-wip-us.apache.org/repos/asf/ant/blob/121043fe/src/main/org/apache/tools/ant/util/StringUtils.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/util/StringUtils.java b/src/main/org/apache/tools/ant/util/StringUtils.java
index 626fb22..dcae2b8 100644
--- a/src/main/org/apache/tools/ant/util/StringUtils.java
+++ b/src/main/org/apache/tools/ant/util/StringUtils.java
@@ -93,7 +93,7 @@ public final class StringUtils {
     public static String getStackTrace(Throwable t) {
         StringWriter sw = new StringWriter();
         PrintWriter pw = new PrintWriter(sw, true);
-        t.printStackTrace(pw);
+        t.printStackTrace(pw); //NOSONAR
         pw.flush();
         pw.close();
         return sw.toString();


Mime
View raw message