Return-Path: X-Original-To: apmail-ant-notifications-archive@minotaur.apache.org Delivered-To: apmail-ant-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E648D19E0D for ; Sun, 17 Apr 2016 04:48:11 +0000 (UTC) Received: (qmail 63833 invoked by uid 500); 17 Apr 2016 04:48:11 -0000 Delivered-To: apmail-ant-notifications-archive@ant.apache.org Received: (qmail 63773 invoked by uid 500); 17 Apr 2016 04:48:11 -0000 Mailing-List: contact notifications-help@ant.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ant.apache.org Delivered-To: mailing list notifications@ant.apache.org Received: (qmail 63762 invoked by uid 99); 17 Apr 2016 04:48:11 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 17 Apr 2016 04:48:11 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 843E9DFE65; Sun, 17 Apr 2016 04:48:11 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: bodewig@apache.org To: notifications@ant.apache.org Date: Sun, 17 Apr 2016 04:48:11 -0000 Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: [1/2] ant git commit: lower-case macro attribute names set via API Repository: ant Updated Branches: refs/heads/master abdaa5845 -> f6e6c20a8 lower-case macro attribute names set via API For normal build files IntrospectionHelper has already handled the lower-casing. Bugzilla Report 59339 Project: http://git-wip-us.apache.org/repos/asf/ant/repo Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/03481a6b Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/03481a6b Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/03481a6b Branch: refs/heads/master Commit: 03481a6b0cc6a512faea9a1c58021eb1c3c29031 Parents: d8e3aa7 Author: Stefan Bodewig Authored: Sun Apr 17 06:43:45 2016 +0200 Committer: Stefan Bodewig Committed: Sun Apr 17 06:46:21 2016 +0200 ---------------------------------------------------------------------- WHATSNEW | 5 +++++ src/main/org/apache/tools/ant/taskdefs/MacroInstance.java | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ant/blob/03481a6b/WHATSNEW ---------------------------------------------------------------------- diff --git a/WHATSNEW b/WHATSNEW index 42eab47..681b5cf 100644 --- a/WHATSNEW +++ b/WHATSNEW @@ -7,6 +7,11 @@ Changes that could break older environments: Fixed bugs: ----------- + * setDynamicAttribute on MacroInstance now lower-cases the attribute + name in order to allow users of the API to use the attributes names + they have specified. + Bugzilla Report 59339 + Other changes: -------------- http://git-wip-us.apache.org/repos/asf/ant/blob/03481a6b/src/main/org/apache/tools/ant/taskdefs/MacroInstance.java ---------------------------------------------------------------------- diff --git a/src/main/org/apache/tools/ant/taskdefs/MacroInstance.java b/src/main/org/apache/tools/ant/taskdefs/MacroInstance.java index 32b1a1a..682ca12 100644 --- a/src/main/org/apache/tools/ant/taskdefs/MacroInstance.java +++ b/src/main/org/apache/tools/ant/taskdefs/MacroInstance.java @@ -81,7 +81,7 @@ public class MacroInstance extends Task implements DynamicAttribute, TaskContain * @param value the value of the attribute */ public void setDynamicAttribute(String name, String value) { - map.put(name, value); + map.put(name.toLowerCase(Locale.ENGLISH), value); } /**