ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bode...@apache.org
Subject ant git commit: lower-case macro attribute names set via API
Date Sun, 17 Apr 2016 04:46:38 GMT
Repository: ant
Updated Branches:
  refs/heads/1.9.x d8e3aa781 -> 03481a6b0


lower-case macro attribute names set via API

For normal build files IntrospectionHelper has already handled the
lower-casing.

Bugzilla Report 59339


Project: http://git-wip-us.apache.org/repos/asf/ant/repo
Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/03481a6b
Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/03481a6b
Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/03481a6b

Branch: refs/heads/1.9.x
Commit: 03481a6b0cc6a512faea9a1c58021eb1c3c29031
Parents: d8e3aa7
Author: Stefan Bodewig <bodewig@apache.org>
Authored: Sun Apr 17 06:43:45 2016 +0200
Committer: Stefan Bodewig <bodewig@apache.org>
Committed: Sun Apr 17 06:46:21 2016 +0200

----------------------------------------------------------------------
 WHATSNEW                                                  | 5 +++++
 src/main/org/apache/tools/ant/taskdefs/MacroInstance.java | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ant/blob/03481a6b/WHATSNEW
----------------------------------------------------------------------
diff --git a/WHATSNEW b/WHATSNEW
index 42eab47..681b5cf 100644
--- a/WHATSNEW
+++ b/WHATSNEW
@@ -7,6 +7,11 @@ Changes that could break older environments:
 Fixed bugs:
 -----------
 
+ * setDynamicAttribute on MacroInstance now lower-cases the attribute
+   name in order to allow users of the API to use the attributes names
+   they have specified.
+   Bugzilla Report 59339
+
 Other changes:
 --------------
 

http://git-wip-us.apache.org/repos/asf/ant/blob/03481a6b/src/main/org/apache/tools/ant/taskdefs/MacroInstance.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/MacroInstance.java b/src/main/org/apache/tools/ant/taskdefs/MacroInstance.java
index 32b1a1a..682ca12 100644
--- a/src/main/org/apache/tools/ant/taskdefs/MacroInstance.java
+++ b/src/main/org/apache/tools/ant/taskdefs/MacroInstance.java
@@ -81,7 +81,7 @@ public class MacroInstance extends Task implements DynamicAttribute, TaskContain
      * @param value the value of the attribute
      */
     public void setDynamicAttribute(String name, String value) {
-        map.put(name, value);
+        map.put(name.toLowerCase(Locale.ENGLISH), value);
     }
 
     /**


Mime
View raw message