ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antoine Levy-Lambert (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IVY-1465) ModuleRules.getRule is O(n) leading to resolution slowness
Date Sun, 27 Apr 2014 20:04:14 GMT

    [ https://issues.apache.org/jira/browse/IVY-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982447#comment-13982447
] 

Antoine Levy-Lambert commented on IVY-1465:
-------------------------------------------

Patch committed in ivy trunk, thanks.

> ModuleRules.getRule is O(n) leading to resolution slowness
> ----------------------------------------------------------
>
>                 Key: IVY-1465
>                 URL: https://issues.apache.org/jira/browse/IVY-1465
>             Project: Ivy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.3.0
>         Environment: OpenJDK 6,7, MacOSX + Ubuntu
>            Reporter: Joshua Suereth
>            Priority: Minor
>              Labels: performance
>
> So, for the sbt project we noticed significant resolution time improvements with the
following patch:
> https://github.com/sbt/ivy/pull/1
> The reasoning:
> A lot of artifacts being resolved use Maven's "dependencyManagement" conventions
> Ivy appears to turn these into "exact matcher" rules
> A ton of resolution time is spent filtering through these rules
> The existing solution is O(n) for all overrides
> What the patch does:
> Creates a key'd store for all "exact matcher" rules
> When executing rules, ensure that we only traverse what we have to (non-exact, exact
specific to our key and "default").
> As I said, this represents a significant speed bump for sbt builds using Ivy.  All existing
tests pass, and I think they cover this aspect of ivy pretty well, from what I could see.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message