ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 21525] [PATCH] XSLT/param@expression used as string instead of as expression as documented
Date Wed, 11 Sep 2013 10:57:02 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=21525

--- Comment #7 from Stefan Bodewig <bodewig@apache.org> ---
I've only got one not-so-small issue with your patch - you change a method
signature in XSLTLiaison and thus may break existing implementations outside of
Ant.  Right now I don't see a simple way to resolve this, other than
introducing an additional interface with a new add method that was implemented
by TraxLiaiison and checked by XSLTProcess before setting parameters.

Other than that I'd probably only suggest to use an EnumeratedAttribute for the
new type attribute.

And of course I'd love to see your examples turned into documentation and tests
;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

Mime
View raw message