ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Enderling (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (EASYANT-55) The attribute onMissingExtensionPoint of the bindtargets task is ignored
Date Tue, 21 May 2013 21:38:20 GMT

     [ https://issues.apache.org/jira/browse/EASYANT-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tim Enderling updated EASYANT-55:
---------------------------------

    Attachment: EASYANT-55-EasyAnt-respects-the-onMissingExtensionPo.patch

The attached patch is based on the current trunk (SVN revision 1480665).

It addresses the issue by the following changes:
* {{ProjectUtils}} will actually read the third field in the extension infos (if given) instead
of using {{OnMissingExtensionPoint.FAIL}} as behavior for all bindings to missing extension
points.

I know that extension points are originating from EasyAnt and the EasyAnt's {{bindtarget}}
task doesn't have this attribute, but it's odd that the code in EasyAnt's {{ProjectUtils}}
knows of {{OnMissingExtensionPoint}}, but does not know that it can be specified in the third
array field. Also I was wondering, why those extension infos are presented as arrays. Is there
a good reason for this or just convenience that prevented the developer from properly using
the type system? ;-)

Like for my patch for EASYANT-54, I could provide a simple test case here to prevent re-breaking.
                
> The attribute onMissingExtensionPoint of the bindtargets task is ignored
> ------------------------------------------------------------------------
>
>                 Key: EASYANT-55
>                 URL: https://issues.apache.org/jira/browse/EASYANT-55
>             Project: EasyAnt
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.9
>            Reporter: Tim Enderling
>         Attachments: EASYANT-55-EasyAnt-respects-the-onMissingExtensionPo.patch
>
>
> When using the {{bindtargets}} task that is now part of Ant with a non-existing extension
point, EasyAnt will complain about the missing extension point and fail, no matter which value
was specified for the {{onMissingExtensionPoint}} attribute.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message