ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maart...@apache.org
Subject svn commit: r1424754 - /ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/resolver/IBiblioResolver.java
Date Thu, 20 Dec 2012 23:23:55 GMT
Author: maartenc
Date: Thu Dec 20 23:23:55 2012
New Revision: 1424754

URL: http://svn.apache.org/viewvc?rev=1424754&view=rev
Log:
Improved performance by not checking if the resource exist when listing the availabe ibiblio
revisions using Maven metadata.

Modified:
    ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/resolver/IBiblioResolver.java

Modified: ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/resolver/IBiblioResolver.java
URL: http://svn.apache.org/viewvc/ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/resolver/IBiblioResolver.java?rev=1424754&r1=1424753&r2=1424754&view=diff
==============================================================================
--- ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/resolver/IBiblioResolver.java (original)
+++ ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/resolver/IBiblioResolver.java Thu Dec
20 23:23:55 2012
@@ -409,7 +409,10 @@ public class IBiblioResolver extends URL
                         patternForRev, historicalMrid, artifact);
                     try {
                         Resource res = repository.getResource(resolvedPattern);
-                        if ((res != null) && res.exists()) {
+                        if (res != null) {
+                            // we do not test if the resource actually exist here, it would
cause
+                            // a lot of checks which are not always necessary depending on
the usage
+                            // which is done of the returned ResolvedResource array
                             rres.add(new ResolvedResource(res, rev));
                         }
                     } catch (IOException e) {



Mime
View raw message