ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 53959] New: delete task w/ removeNotFollowedSymlinks="true" and includes,followSymLinks="false" on fileset does not filter symlinks correctly
Date Wed, 03 Oct 2012 15:12:18 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=53959

          Priority: P2
            Bug ID: 53959
          Assignee: notifications@ant.apache.org
           Summary: delete task w/ removeNotFollowedSymlinks="true" and
                    includes,followSymLinks="false" on fileset does not
                    filter symlinks correctly
          Severity: normal
    Classification: Unclassified
                OS: Linux
          Reporter: jrojas@redlinesolutions.co
          Hardware: PC
            Status: NEW
           Version: 1.8.4
         Component: Core
           Product: Ant

For example:

<delete removeNotFollowedSymlinks="true">
   <fileset dir="someDir/" followSymlinks="false" includes="**/*.todelete" />
</delete>

This should only delete files with .todelete as the final extension, and remove
symlinks with .todelete as the extension as well.

However ANT removes ALL symlinks instead without filtering based on the
includes attribute.

The culprit is line 1229 in org.apache.tools.ant.DirectoryScanner.  The line
should be:

if (isIncluded(name) && !isExcluded(name)) {

So that the included patterns are checked for symlinks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Mime
View raw message