ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Haberman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IVY-1141) dependencies failed using branch attribute (and extra attrubutes)
Date Wed, 12 Sep 2012 15:11:07 GMT

    [ https://issues.apache.org/jira/browse/IVY-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454054#comment-13454054
] 

Stephen Haberman commented on IVY-1141:
---------------------------------------

I believe the attached "branch-fix.diff" fixes this bug; at least it did for my local reproduction
of the issue.

I no longer get a ParseException and the correct "latest.integration" version is found even
if a version from a newer branch has been published (the fix makes LatestVersionMatcher skip
newer artifacts if their branch does not match).

Maarten, can you sanity check that this approach is valid?

If so, I can follow up with a test case in ResolverTest.java (which still passes with my change)
that reproduces the issue.

Thanks!
                
> dependencies failed using branch attribute (and extra attrubutes)
> -----------------------------------------------------------------
>
>                 Key: IVY-1141
>                 URL: https://issues.apache.org/jira/browse/IVY-1141
>             Project: Ivy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.1.0
>         Environment: windows 
>            Reporter: Daniel Schwager
>         Attachments: branch-fix.diff
>
>
> *** Investigation
> i tried to use the branch attribute inside my projekt DEV like this:
> 	<ivy-module version="1.1">
> 		<info ... module="DEV" ....
> 		<dependency org="testng" name="testng" 
> 			branch="mybranch1" rev="latest.integration"  
> 			conf="compile,tests->default"/>
> 		.....
> If I now try to resolve my dependencies, it failed
> because ivy 2.1.0 try to resolve the latest version (5.6) of testng/testng
> which has NO branch-keyword inside it's ivy.xml. The ivy.xml
> of version testng/testng/4.6 contains the following:
> <ivy-module version="1.1">
>     <info
>         organisation="testng" module="testng"
>         branch="mybranch1"  revision="4.6.1.2"
>         status="release"         
>         publication="20060227000000">
>       .....
> It looks like the resolver skip this 4.6.1.2 version (which is the only one containing
the 
> branch attribute "mybranch1") and try to download the 5.6 (containing NO branch attribute
!). 
> I go the following error message:
> [ivy:configure] :: Ivy 2.1.0 - 20090925235825 :: http://ant.apache.org/ivy/ ::
> ...
> 	---------------------------------------------------------------------
> [ivy:resolve] :: problems summary ::
> [ivy:resolve] :::: WARNINGS
> [ivy:resolve] 		::::::::::::::::::::::::::::::::::::::::::::::
> [ivy:resolve] 		::          UNRESOLVED DEPENDENCIES         ::
> [ivy:resolve] 		::::::::::::::::::::::::::::::::::::::::::::::
> [ivy:resolve] 		:: testng#testng#mybranch1;latest.integration: several problems occured
while resolving dependency: testng#testng#mybranch1;latest.integration {compile=[default],
tests=[default]}:
> [ivy:resolve] 	java.text.ParseException: inconsistent module descriptor file found in
'I:\testng\testng\5.6\ivy.xml': bad branch name: expected='mybranch1' found='null'; 
> [ivy:resolve] 	java.text.ParseException: inconsistent module descriptor file found in
'http://ivyrepos.dtnet.de/testng/testng/5.6/ivy.xml': bad branch name: expected='mybranch1'
found='null'; 
> [ivy:resolve] 		::::::::::::::::::::::::::::::::::::::::::::::
> [ivy:resolve] 
> [ivy:resolve] :::: ERRORS
> [ivy:resolve] 		shared-filesystem: bad branch name found in I:\testng\testng\5.6\ivy.xml:
expected='mybranch1 found='null'
> [ivy:resolve] 		shared-web: bad branch name found in http://ivyrepos.dtnet.de/testng/testng/5.6/ivy.xml:
expected='mybranch1 found='null'
> [ivy:resolve] 
> [ivy:resolve] :: USE VERBOSE OR DEBUG MESSAGE LEVEL FOR MORE DETAILS
> *** Make it reproducable
> I create a VERY small sample project (build.xml & ivy.xml)
> using a sample ivyrepos on our server.
> Could somebody look closer to the problem by downloading the project from
>     http://www.opensource-online.org/fileadmin/swd/ivy/ivy-test.zip
> To run, yust unzip and start "ant -f build.xml" and you can see the failure:
> [ivy:resolve]           ::::::::::::::::::::::::::::::::::::::::::::::
> [ivy:resolve]           ::          UNRESOLVED DEPENDENCIES         ::
> [ivy:resolve]           ::::::::::::::::::::::::::::::::::::::::::::::
> [ivy:resolve]           :: testng#testng#mybranch1;latest.integration: java.text.ParseException:
inconsistent module descriptor file found in 'http:/
> www.opensource-online.org/fileadmin/swd/ivy/testng/testng/5.6/ivy.xml': bad branch name:
expected='mybranch1' found='';
> [ivy:resolve]           ::::::::::::::::::::::::::::::::::::::::::::::
> [ivy:resolve]
> [ivy:resolve] :::: ERRORS
> [ivy:resolve]           default: bad branch name found in http://www.opensource-online.org/fileadmin/swd/ivy/testng/testng/5.6/ivy.xml:
expected='myb
> anch1 found=''
> [ivy:resolve]
> [ivy:resolve] :: USE VERBOSE OR DEBUG MESSAGE LEVEL FOR MORE DETAILS
> *** Same problem using extra attributes instead auf branch attribute
> if tried a workaround not using the branch-keyword but defining a own extra atrribute
like this:
> <ivy-module version="2.0" xmlns:swd="http://softwaredemo.de/ivy/extra">
>  ...
> 		<dependency org="testng" name="testng"  swd:suite="mybranch-e2" rev="latest.integration"
 
> 					conf="compile,tests->default"/>
> But this tells me a similar result - also a failure.
> regards
> Danny
> P.S.: refer also to http://old.nabble.com/dependencies-failed-using-branch-attribute-td26411302.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message