ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 53550] [PATCH] extensionOf settings applied when task is discarded because of previous declaration
Date Mon, 16 Jul 2012 01:20:39 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=53550

--- Comment #4 from Tim Pokorny <tpokorny@gmail.com> ---
Created attachment 29066
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29066&action=edit
[PATCH] Updated patch file (second attempt)

OK, so looking harder at the problem there is a simple one-line fix for the
immediate issue. When importing, if the target overlaps with an existing one,
at a point right before extension processing the internal Target object is
replaced by a new one that has the prefixed name.

After this, if the target has an extensionOf value, the basic information is
bundled up and stored in the extension point stack for later processing, the
the relevant target identified by name (as a String). However, when this
happens, the original name of the target is used, even if the target has been
"replaced" by a prefixed on. The second patch contains a one-line fix that gets
the name of the target from the target itself, rather than a previous stored
local variable, thus keeping things happy whether the target has been replaced
with a prefixed-version or not.

Apologies. Too much typing for a one-line patch! :P

-- 
You are receiving this mail because:
You are the assignee for the bug.

Mime
View raw message