ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Louis Boudart (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IVY-1363) ivy:buildlist task confused by extends feature using two parents
Date Wed, 18 Jul 2012 19:31:34 GMT

    [ https://issues.apache.org/jira/browse/IVY-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417397#comment-13417397
] 

Jean-Louis Boudart commented on IVY-1363:
-----------------------------------------

Mitch,
I just checked your patches and think it definitively takes the good direction.
You were right, there was lots of issue with how extends mechanism locates unpublished parents
in the file system and as original author of this feature, i really apologize!

I have question through according to following comment  :
{code}
// Do we even need to be adding this resolver to the Ivy settings considering that it's being
placed in the map and not being used elsewhere?
ivyContext.getSettings().addResolver(parentModuleResolver);
{code}

I would ask the opposite question :) Do we really need to use a Map for this ?
I'm not sure other pieces of code needs to use parent resolver (or at least i don't remember
if ivy needs it), but it looks like more extendable for me to store it as a resolver. 

Even if it's only used for now inside XmlModuleDescriptorParser, we could imagine it could
be used by reports to display resolver's name used while fetching artefacts.
In Ivy, resolution is usually done by relying on resolvers, and locating a parent looks likes
asking a resolver. That's why it was originally made like this.

Now to get back to your patch i don't see any benefit to store it on a Map as it is not the
way ivy consider resolver.

Did i missed something?


                
> ivy:buildlist task confused by extends feature using two parents
> ----------------------------------------------------------------
>
>                 Key: IVY-1363
>                 URL: https://issues.apache.org/jira/browse/IVY-1363
>             Project: Ivy
>          Issue Type: Bug
>          Components: Ant, Core
>    Affects Versions: 2.3.0-RC1
>         Environment: Ant 1.7.1 (but should be the same with Ant 1.8.3)
>            Reporter: Mitch Gitman
>              Labels: testcase
>         Attachments: BuildlistAndExtendsIntegrationTest.zip, ivy-2.3.x.patch, ivy-trunk.patch
>
>
> I'm finding that the ivy:buildlist Ant task is erroring when it encounters more than
one parent Ivy module that's pulled in through the /ivy-module/info/extends element. This
problem is new to Ivy 2.3.0-rc1; I did not encounter it with Ivy 2.2.0. There is no relationship
or interaction between the two different parent Ivy modules, i.e. no nesting of parents.
> In my test case, which I explain shortly, when I point the ivy:buildlist Ant task at
a project stack that includes a mix of both parents and their children, I see this error:
> ...\multimodule-build\build.xml:28: impossible to parse ivy file for ...\testTwoParents\germany\build.xml:
ivyfile=...\testTwoParents\germany\ivy.xml exception=java.text.ParseException: Problem occurred
while parsing ivy file: inconsistent module descriptor file found in 'file:/.../testTwoParents/master-parent/ivy.xml':
bad module name: expected='bootstrap-parent' found='master-parent';  in file:/.../testTwoParents/germany/ivy.xml
> What's happening is, the germany module extends bootstrap-parent, but somehow the relative
path to master-parent/ivy.xml is supplanting the relative path to bootstrap-parent/ivy.xml.
It appears buildlist doesn't know how to deal with more than one parent.
> This is what occurs when the haltOnError attribute is set to "true" on ivy:buildlist.
If I set haltOnError="false" in my test case, the exception goes away, but I see the following
build order:
> 1. germany
> 2. ireland
> 3. bootstrap-parent
> 4. master-parent
> 5. croatia
> What's wrong about this build order is that germany depends on ireland and ireland depends
on bootstrap-parent, so the order of the first three entries is reversed. If I removed the
dependency of ireland on bootstrap-parent, the order would be the same. This misordering is
clearly related to the presence of more than one parent because comparable tests using (A)
the extends feature with a single parent and (B) no extends feature at all get the order right.
Plus, I see this unexpected output when haltOnError="false":
> [ivy:buildlist] 	=> adding it at the beginning of the path
> [ivy:buildlist] 	=> adding it at the beginning of the path
> TEST CASE INSTRUCTIONS:
> I've attached a ZIP containing three standalone test cases, each consisting of a suite
of Ant projects that together comprise a multimodule build whose build order is to be determined
by the ivy:buildlist task:
> * testNoParents: The extends feature is not used.
> * testOneParent: The extends feature is used to pull in content from a single parent
Ivy module.
> * testTwoParents: The extends feature is used where one Ivy module pulls in content from
one parent and two other Ivy modules pull in content from a different parent.
> The testNoParents and testOneParent tests are the control groups. The testTwoParents
test is where things fail.
> When running Ant from one of these test cases, you need to specify the location of the
Ivy 2.3.0-rc1 installation using one of the following:
> * an IVY_DIR environment variable
> * an env.IVY_DIR user property, i.e. -Denv.IVY_DIR=...
> * an ivy.dir user property, i.e. -Divy.dir=...
> To run the build in any of these suites, go to the multimodule-build directory, and execute
"ant" or "ant init"—while specifying the Ivy installation location. You can also run "ant
cleancache" to clear out the Ivy cache. However, you shouldn't need to do this regularly because
each of these test cases uses its own dedicated Ivy cache.
> NOTE: This issue is broached in the email thread "extends & buildlist on 2.3.0-rc1
… it gets worse" on the ivy-user and ant-dev mailing lists.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message