ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 52706] [PATCH] Make Execute class extensible to allow custom CommandLauncher implementation
Date Mon, 11 Jun 2012 16:29:51 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=52706

--- Comment #2 from Vimil <vimilsaju@yahoo.com> ---
I think CommandLauncher can be extracted to a new class. The CommandLauncher
class accesses 'environmentCaseInSensitive' which is internal to Execute class,
but that can be moved to a static constructor block within the Execute class
itself. However the sub-classes of CommandLauncher class i.e
PerlScriptCommandLauncher, ScriptCommandLauncher and VmsCommandLauncher access
FILE_UTILS singleton which is internal to Execute, So I am wondering whether
they should remain within the Execute class itself.

I wanted to do a diff, but I couldn't find a suitable tool in windows that
generates a diff? Do you know of any tool that would do that?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Mime
View raw message