https://issues.apache.org/bugzilla/show_bug.cgi?id=52706
--- Comment #3 from Stefan Bodewig <bodewig@apache.org> ---
(In reply to comment #2)
> I think CommandLauncher can be extracted to a new class. The CommandLauncher
> class accesses 'environmentCaseInSensitive' which is internal to Execute
> class, but that can be moved to a static constructor block within the
> Execute class itself.
Yes, sounds good.
> However the sub-classes of CommandLauncher class i.e
> PerlScriptCommandLauncher, ScriptCommandLauncher and VmsCommandLauncher
> access FILE_UTILS singleton which is internal to Execute, So I am wondering
> whether they should remain within the Execute class itself.
The FILE_UTILS is just a performance enhancement, it is backed by a Singleton
instance in FileUtils so it wouldn't cause too much overhead to copy it around
to each class (or add a protected one in CommandLauncher).
> I wanted to do a diff, but I couldn't find a suitable tool in windows that
> generates a diff? Do you know of any tool that would do that?
Subversion ;-)
svn diff
inside a working copy.
--
You are receiving this mail because:
You are the assignee for the bug.
|