ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 52706] [PATCH] Make Execute class extensible to allow custom CommandLauncher implementation
Date Sat, 09 Jun 2012 17:53:18 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=52706

--- Comment #1 from Stefan Bodewig <bodewig@apache.org> ---
Would it make sense to extract CommadLauncher into a separate class or do you
need access to internals of Execute?

Other than that the changes look good to me.

For the future, please provide a diff rather than complete classes since it
helps with reviews and survives some code changes to the class in svn.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Mime
View raw message